devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org, Andrew Davis <afd@ti.com>
Subject: Re: [PATCH v2] dt-bindings: omap: Convert omap.txt to yaml
Date: Fri, 31 Mar 2023 09:41:07 +0300	[thread overview]
Message-ID: <20230331064107.GU7501@atomide.com> (raw)
In-Reply-To: <20230330181506.4d5fcf51@aktux>

* Andreas Kemnade <andreas@kemnade.info> [230330 16:15]:
> On Thu, 30 Mar 2023 14:39:18 +0300
> Tony Lindgren <tony@atomide.com> wrote:
> 
> > * Andreas Kemnade <andreas@kemnade.info> [230329 22:22]:
> > > From: Andrew Davis <afd@ti.com>
> > > 
> > > Convert omap.txt to yaml.
> > >  Documentation/devicetree/bindings/arm/ti.yaml | 157 ++++++++++++++++++
> > >  1 file changed, 157 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/arm/ti.yaml  
> > 
> > Great, can we also drop the old txt file or is more changes needed before
> > we can do that?
> >
> we have still 
> - ti,hwmods: list of hwmod names (ascii strings), that comes from the OMAP
>   HW documentation, attached to a device. Must contain at least
>   one hwmod.
> 
> Optional properties:
> - ti,no_idle_on_suspend: When present, it prevents the PM to idle the module
>   during suspend.
> - ti,no-reset-on-init: When present, the module should not be reset at init
> - ti,no-idle-on-init: When present, the module should not be idled at init
> - ti,no-idle: When present, the module is never allowed to idle.

These are documented in the ti-sysc.yaml for the current SoCs, but not for
the legacy SoC still using ti,hwmods.

> These optional properties are not in the root node but in subnodes.
> From my guts feeling this belongs in a separate file and should
> be somehow dealed with in a second step.

Agreed.

> So how to proceed?

How about just rename the hwmods related parts of omap.txt to something like
ti-hwmods.txt?

> BTW: I think this file then also belongs into
> OMAP2+ SUPPORT section of MAINTAINERS

Yeah that helps for receiving related emails :)

Regards,

Tony

  reply	other threads:[~2023-03-31  6:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 22:22 [PATCH v2] dt-bindings: omap: Convert omap.txt to yaml Andreas Kemnade
2023-03-30 11:39 ` Tony Lindgren
2023-03-30 13:24   ` Krzysztof Kozlowski
2023-03-30 16:15   ` Andreas Kemnade
2023-03-31  6:41     ` Tony Lindgren [this message]
2023-03-31  9:43     ` Krzysztof Kozlowski
2023-03-31 11:37       ` Tony Lindgren
  -- strict thread matches above, loose matches on Subject: below --
2023-03-29 22:07 Andreas Kemnade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230331064107.GU7501@atomide.com \
    --to=tony@atomide.com \
    --cc=afd@ti.com \
    --cc=andreas@kemnade.info \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).