From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FEB4C6FD18 for ; Fri, 31 Mar 2023 07:44:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230199AbjCaHoW (ORCPT ); Fri, 31 Mar 2023 03:44:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230096AbjCaHoV (ORCPT ); Fri, 31 Mar 2023 03:44:21 -0400 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A58C012D for ; Fri, 31 Mar 2023 00:44:20 -0700 (PDT) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 0672A20010; Fri, 31 Mar 2023 07:44:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1680248659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SDE65/9UMQcVJEA+MrPuDNWDnBd+1E2AaSdY+g9jmkk=; b=bxbMf2OIFqouKOHScTviVUqivPdZh176KPQb9VRlmU5Bc9U/A81xFq7Hb6fFKzYRVtnUJl J0EqalrRu7ywflqCWsj+kA4VbJ07iLQBGGG9doUYcGZm+lprMtEDZwsjaSQ8LmtFaUgamv omquqS173IkTauYZroHrkaxw7Z2+NyH9qgMjv0um21pLnCJUbls1QXYGED+j41mTan5FNG NvFHoiidu5RVfPsAltT1x/CHULjdkbQoUl6qqP/E6FXKN2H5w+U0UcRvJhb8Jro0xltnqC +k+m0xalKUzviTltWz9zcniMpdcG7A24yv77qllBr+gE/ezZJ1RKZS81+c3TZA== Date: Fri, 31 Mar 2023 09:44:14 +0200 From: Alexandre Belloni To: Jeremy Kerr Cc: Jack Chen , linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, Matt Johnston , Vitor Soares , Billy Tsai , Dylan Hung , Joel Stanley , Andrew Jeffery Subject: Re: [PATCH v2 0/3] i3c dw,ast2600: Add a driver for the AST2600 i3c controller Message-ID: <202303310744148a8192e9@mail.local> References: <48906ed40dbf34a28cb9bcc2569d113abd88e409.camel@codeconstruct.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48906ed40dbf34a28cb9bcc2569d113abd88e409.camel@codeconstruct.com.au> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/03/2023 10:33:35+0800, Jeremy Kerr wrote: > Hi Zenghu, > > > Thanks for the change, especially IBI features in other threads. > > From my understanding, ASPEED AST2600 is a SoC which uses Synopsys' > > I3C IP core, and several different registers, especially the pull-up > > resistor. > > If so, I am wondering if this is the right place to add > > ast2600-i3c-master.c, given that all current three xxx-i3c-master.c > > drivers in this directory are from IP providers directly. > > What about moving it under ~/driver/soc/? > > It's my understanding that drivers/soc/ is for smaller parts of > SoC-specific functions, rather than implementing SoC driver instances > for existing subsystems. > > I'd prefer to keep it with the i3c controller drivers; this means we can > keep the dw platform API as contained as possible (ie., within > drivers/i3c/master/). I expect that we will need some coordination of > changes until we have the platform-specific behaviour mostly described > (see the IBI series for another hook), and so coordinating changes > between drivers/soc/ and drivers/i3c/ may make things more complicated > than necessary. > > There's certainly precedence for this pattern: > > * the aspeed ethernet mac is provided by the ftgmac100 driver plus some > SoC-specific behaviour; that's entirely within drivers/net/ > > * the aspeed VUART device is essentially a 16550 plus extra registers; > that's entirely within drivers/tty/ > I confirm this has to be in drivers/i3c -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com