From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org
Subject: [PATCH v2 12/22] arm64: dts: qcom: pm8350: allow overriding SID and label
Date: Sun, 2 Apr 2023 01:08:00 +0300 [thread overview]
Message-ID: <20230401220810.3563708-13-dmitry.baryshkov@linaro.org> (raw)
In-Reply-To: <20230401220810.3563708-1-dmitry.baryshkov@linaro.org>
The platform can use several instances of PM8350 PMIC. Allow overriding
the SID and node labels inside pm8350.dtsi.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
arch/arm64/boot/dts/qcom/pm8350.dtsi | 29 ++++++++++++++-----
| 3 ++
| 6 ++++
3 files changed, 30 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/pm8350.dtsi b/arch/arm64/boot/dts/qcom/pm8350.dtsi
index 9fb963df4b41..b7b14b5fe67d 100644
--- a/arch/arm64/boot/dts/qcom/pm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8350.dtsi
@@ -6,12 +6,23 @@
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/spmi/spmi.h>
+/* (Sadly) this PMIC can be configured to be at different SIDs */
+#ifndef PMIC_SID
+ #define PMIC_SID 1
+#endif
+
+#ifndef PMIC_LABEL
+ #define PMIC_LABEL pm8350
+#endif
+
+#include "pmic-dyn-header.dtsi"
+
/ {
thermal-zones {
- pm8350-thermal {
+ NODE(thermal) {
polling-delay-passive = <100>;
polling-delay = <0>;
- thermal-sensors = <&pm8350_temp_alarm>;
+ thermal-sensors = <&LABEL(temp_alarm)>;
trips {
trip0 {
@@ -31,27 +42,29 @@ crit {
};
&spmi_bus {
- pm8350: pmic@1 {
+ PMIC_LABEL: pmic@PMIC_SID {
compatible = "qcom,pm8350", "qcom,spmi-pmic";
- reg = <0x1 SPMI_USID>;
+ reg = <PMIC_SID SPMI_USID>;
#address-cells = <1>;
#size-cells = <0>;
- pm8350_temp_alarm: temp-alarm@a00 {
+ LABEL(temp_alarm): temp-alarm@a00 {
compatible = "qcom,spmi-temp-alarm";
reg = <0xa00>;
- interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+ interrupts = <PMIC_SID 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
#thermal-sensor-cells = <0>;
};
- pm8350_gpios: gpio@8800 {
+ LABEL(gpios): gpio@8800 {
compatible = "qcom,pm8350-gpio", "qcom,spmi-gpio";
reg = <0x8800>;
gpio-controller;
- gpio-ranges = <&pm8350_gpios 0 0 10>;
+ gpio-ranges = <&LABEL(gpios) 0 0 10>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
};
};
};
+
+#include "pmic-dyn-footer.dtsi"
--git a/arch/arm64/boot/dts/qcom/pmic-dyn-footer.dtsi b/arch/arm64/boot/dts/qcom/pmic-dyn-footer.dtsi
index 1c81269f0783..29b10e7fb8c3 100644
--- a/arch/arm64/boot/dts/qcom/pmic-dyn-footer.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmic-dyn-footer.dtsi
@@ -9,5 +9,8 @@
#undef _LABEL
#undef __LABEL
+#undef NODE
+
#undef PMIC_SID
#undef PMIC_LABEL
+#undef PMIC_NODE
--git a/arch/arm64/boot/dts/qcom/pmic-dyn-header.dtsi b/arch/arm64/boot/dts/qcom/pmic-dyn-header.dtsi
index 75f0448568bd..bb41c9387aba 100644
--- a/arch/arm64/boot/dts/qcom/pmic-dyn-header.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmic-dyn-header.dtsi
@@ -9,6 +9,12 @@
* pmic-dyn-footer.dtsi.
*/
+#ifndef PMIC_NODE
+ #define PMIC_NODE PMIC_LABEL
+#endif
+
#define LABEL(name) _LABEL(PMIC_LABEL, name)
#define _LABEL(pmic, name) __LABEL(pmic, name)
#define __LABEL(pmic, name) pmic ## _ ## name
+
+#define NODE(name) PMIC_NODE ##-## name
--
2.30.2
next prev parent reply other threads:[~2023-04-01 22:08 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 22:07 [PATCH v2 00/22] arm64: dts: qcom: remove duplication in PMIC declarations Dmitry Baryshkov
2023-04-01 22:07 ` [PATCH v2 01/22] arm64: dts: qcom: pm8350: fix thermal zone node name Dmitry Baryshkov
2023-04-03 9:55 ` Konrad Dybcio
2023-04-01 22:07 ` [PATCH v2 02/22] arm64: dts: qcom: pm8350b: " Dmitry Baryshkov
2023-04-02 10:34 ` Krzysztof Kozlowski
2023-04-02 11:02 ` Dmitry Baryshkov
2023-04-03 9:09 ` Krzysztof Kozlowski
2023-04-03 9:50 ` Dmitry Baryshkov
2023-04-03 10:00 ` Konrad Dybcio
2023-04-03 10:06 ` Krzysztof Kozlowski
2023-04-01 22:07 ` [PATCH v2 03/22] arm64: dts: qcom: sc8280xp-pmics: use pmk8350 specifics for pon device Dmitry Baryshkov
2023-04-02 9:42 ` Krzysztof Kozlowski
2023-04-02 10:25 ` Dmitry Baryshkov
2023-04-02 10:32 ` Krzysztof Kozlowski
2023-04-02 11:03 ` Dmitry Baryshkov
2023-04-02 11:12 ` Krzysztof Kozlowski
2023-04-03 10:06 ` Konrad Dybcio
2023-04-03 6:32 ` Johan Hovold
2023-04-01 22:07 ` [PATCH v2 04/22] arm64: dts: qcom: sc8280xp-pmics: correct interrupt routing for pm8280_2_temp_alarm Dmitry Baryshkov
2023-04-03 10:07 ` Konrad Dybcio
2023-04-01 22:07 ` [PATCH v2 05/22] dt-bindings: iio: qcom,spmi-adc7-pmk8350.h: include sid into defines Dmitry Baryshkov
2023-04-01 22:07 ` [PATCH v2 06/22] arm64: dts: qcom: pmk8350: rename pon label Dmitry Baryshkov
2023-04-01 22:07 ` [PATCH v2 07/22] arm64: dts: qcom: pmk8350: port sdam_6 device from sc8280xp-pmics Dmitry Baryshkov
2023-04-03 10:09 ` Konrad Dybcio
2023-04-01 22:07 ` [PATCH v2 08/22] arm64: dts: qcom: pmk8350: rename PMK8350_SID to PMIC_SID Dmitry Baryshkov
2023-04-03 10:11 ` Konrad Dybcio
2023-04-01 22:07 ` [PATCH v2 09/22] arm64: dts: qcom: pmk8350: allow overriding the label Dmitry Baryshkov
2023-04-02 9:44 ` Krzysztof Kozlowski
2023-04-02 11:54 ` Dmitry Baryshkov
2023-04-03 10:14 ` Konrad Dybcio
2023-04-03 11:06 ` Dmitry Baryshkov
2023-04-01 22:07 ` [PATCH v2 10/22] arm64: dts: qcom: pmk8350: use interrupts-extended for IRQ specification Dmitry Baryshkov
2023-04-03 10:16 ` Konrad Dybcio
2023-04-01 22:07 ` [PATCH v2 11/22] arm64: dts: qcom: sc8280xp*: use pmk8350.dtsi Dmitry Baryshkov
2023-04-01 22:08 ` Dmitry Baryshkov [this message]
2023-04-01 22:08 ` [PATCH v2 13/22] arm64: dts: qcom: pm8350: use interrupts-extended for IRQ specification Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 14/22] arm64: dts: qcom: sc8280xp*: use pm8350.dtsi Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 15/22] arm64: dts: qcom: pm8350c: move thermal zone declaration to the top Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 16/22] arm64: dts: qcom: pm8350c: allow overriding SID and label Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 17/22] arm64: dts: qcom: pm8350c: use interrupts-extended for IRQ specification Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 18/22] arm64: dts: qcom: sc8280xp*: use pm8350c.dtsi Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 19/22] arm64: dts: qcom: sc8280xp*: use pmr735a.dtsi Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 20/22] arm64: dts: qcom: pm8150: convert to use dynamic SID/LABEL Dmitry Baryshkov
2023-04-02 9:47 ` Krzysztof Kozlowski
2023-04-01 22:08 ` [PATCH v2 21/22] arch: arm64: dts: qcom: pm8150: support SID greater that 9 Dmitry Baryshkov
2023-04-02 9:51 ` Krzysztof Kozlowski
2023-04-03 10:35 ` Konrad Dybcio
2023-04-03 11:45 ` Dmitry Baryshkov
2023-04-03 12:56 ` Krzysztof Kozlowski
2023-04-03 13:56 ` Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 22/22] arm64: dts: qcom sa8540p-pmics: switch to pm8150.dtsi Dmitry Baryshkov
2023-04-02 9:55 ` [PATCH v2 00/22] arm64: dts: qcom: remove duplication in PMIC declarations Krzysztof Kozlowski
2023-04-03 10:44 ` Konrad Dybcio
2023-04-03 11:37 ` Dmitry Baryshkov
2023-04-03 13:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230401220810.3563708-13-dmitry.baryshkov@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).