From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org
Subject: [PATCH v2 08/22] arm64: dts: qcom: pmk8350: rename PMK8350_SID to PMIC_SID
Date: Sun, 2 Apr 2023 01:07:56 +0300 [thread overview]
Message-ID: <20230401220810.3563708-9-dmitry.baryshkov@linaro.org> (raw)
In-Reply-To: <20230401220810.3563708-1-dmitry.baryshkov@linaro.org>
Several next patches are going to introduce flexibility into several
other PMICs in order to support variable SID and node labels. This will
result in close duplication of several similar preprocessor
constructions. Having a per-PMIC defines would be error prone and can
result in hard-to-notices mistakes. Thus rename PMK8350_SID to a generic
PMIC_SID.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
arch/arm64/boot/dts/qcom/pmk8350.dtsi | 20 ++++++++++---------
.../qcom/sm6375-sony-xperia-murray-pdx225.dts | 7 ++++---
.../boot/dts/qcom/sm7225-fairphone-fp4.dts | 6 +++---
3 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/pmk8350.dtsi b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
index 26e40dbfc173..02e7518ab57b 100644
--- a/arch/arm64/boot/dts/qcom/pmk8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
@@ -9,14 +9,14 @@
#include <dt-bindings/spmi/spmi.h>
/* (Sadly) this PMIC can be configured to be at different SIDs */
-#ifndef PMK8350_SID
- #define PMK8350_SID 0
+#ifndef PMIC_SID
+ #define PMIC_SID 0
#endif
&spmi_bus {
- pmk8350: pmic@PMK8350_SID {
+ pmk8350: pmic@PMIC_SID {
compatible = "qcom,pmk8350", "qcom,spmi-pmic";
- reg = <PMK8350_SID SPMI_USID>;
+ reg = <PMIC_SID SPMI_USID>;
#address-cells = <1>;
#size-cells = <0>;
@@ -27,14 +27,14 @@ pmk8350_pon: pon@1300 {
pmk8350_pon_pwrkey: pwrkey {
compatible = "qcom,pmk8350-pwrkey";
- interrupts = <PMK8350_SID 0x13 0x7 IRQ_TYPE_EDGE_BOTH>;
+ interrupts = <PMIC_SID 0x13 0x7 IRQ_TYPE_EDGE_BOTH>;
linux,code = <KEY_POWER>;
status = "disabled";
};
pmk8350_pon_resin: resin {
compatible = "qcom,pmk8350-resin";
- interrupts = <PMK8350_SID 0x13 0x6 IRQ_TYPE_EDGE_BOTH>;
+ interrupts = <PMIC_SID 0x13 0x6 IRQ_TYPE_EDGE_BOTH>;
status = "disabled";
};
};
@@ -44,14 +44,14 @@ pmk8350_vadc: adc@3100 {
reg = <0x3100>;
#address-cells = <1>;
#size-cells = <0>;
- interrupts = <PMK8350_SID 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
+ interrupts = <PMIC_SID 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
#io-channel-cells = <1>;
};
pmk8350_adc_tm: adc-tm@3400 {
compatible = "qcom,adc-tm7";
reg = <0x3400>;
- interrupts = <PMK8350_SID 0x34 0x0 IRQ_TYPE_EDGE_RISING>;
+ interrupts = <PMIC_SID 0x34 0x0 IRQ_TYPE_EDGE_RISING>;
#address-cells = <1>;
#size-cells = <0>;
#thermal-sensor-cells = <1>;
@@ -62,7 +62,7 @@ pmk8350_rtc: rtc@6100 {
compatible = "qcom,pmk8350-rtc";
reg = <0x6100>, <0x6200>;
reg-names = "rtc", "alarm";
- interrupts = <PMK8350_SID 0x62 0x1 IRQ_TYPE_EDGE_RISING>;
+ interrupts = <PMIC_SID 0x62 0x1 IRQ_TYPE_EDGE_RISING>;
status = "disabled";
};
@@ -86,3 +86,5 @@ pmk8350_gpios: gpio@b000 {
};
};
};
+
+#undef PMIC_SID
diff --git a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts
index b691c3834b6b..863fc1f4b0b6 100644
--- a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts
+++ b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts
@@ -5,13 +5,14 @@
/dts-v1/;
-/* PMK8350 is configured to use SID6 instead of 0 */
-#define PMK8350_SID 6
-
#include <dt-bindings/gpio/gpio.h>
#include "sm6375.dtsi"
#include "pm6125.dtsi"
+
+/* PMK8350 is configured to use SID6 instead of 0 */
+#define PMIC_SID 6
#include "pmk8350.dtsi"
+
#include "pmr735a.dtsi"
/* PM6125 PON is used and we can't have duplicate labels */
diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
index af6cf4fbddc7..965b37245007 100644
--- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
+++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
@@ -5,9 +5,6 @@
/dts-v1/;
-/* PMK8350 (in reality a PMK8003) is configured to use SID6 instead of 0 */
-#define PMK8350_SID 6
-
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
#include <dt-bindings/input/input.h>
@@ -18,6 +15,9 @@
#include "pm6150l.dtsi"
#include "pm6350.dtsi"
#include "pm7250b.dtsi"
+
+/* PMK8350 (in reality a PMK8003) is configured to use SID6 instead of 0 */
+#define PMIC_SID 6
#include "pmk8350.dtsi"
/ {
--
2.30.2
next prev parent reply other threads:[~2023-04-01 22:08 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 22:07 [PATCH v2 00/22] arm64: dts: qcom: remove duplication in PMIC declarations Dmitry Baryshkov
2023-04-01 22:07 ` [PATCH v2 01/22] arm64: dts: qcom: pm8350: fix thermal zone node name Dmitry Baryshkov
2023-04-03 9:55 ` Konrad Dybcio
2023-04-01 22:07 ` [PATCH v2 02/22] arm64: dts: qcom: pm8350b: " Dmitry Baryshkov
2023-04-02 10:34 ` Krzysztof Kozlowski
2023-04-02 11:02 ` Dmitry Baryshkov
2023-04-03 9:09 ` Krzysztof Kozlowski
2023-04-03 9:50 ` Dmitry Baryshkov
2023-04-03 10:00 ` Konrad Dybcio
2023-04-03 10:06 ` Krzysztof Kozlowski
2023-04-01 22:07 ` [PATCH v2 03/22] arm64: dts: qcom: sc8280xp-pmics: use pmk8350 specifics for pon device Dmitry Baryshkov
2023-04-02 9:42 ` Krzysztof Kozlowski
2023-04-02 10:25 ` Dmitry Baryshkov
2023-04-02 10:32 ` Krzysztof Kozlowski
2023-04-02 11:03 ` Dmitry Baryshkov
2023-04-02 11:12 ` Krzysztof Kozlowski
2023-04-03 10:06 ` Konrad Dybcio
2023-04-03 6:32 ` Johan Hovold
2023-04-01 22:07 ` [PATCH v2 04/22] arm64: dts: qcom: sc8280xp-pmics: correct interrupt routing for pm8280_2_temp_alarm Dmitry Baryshkov
2023-04-03 10:07 ` Konrad Dybcio
2023-04-01 22:07 ` [PATCH v2 05/22] dt-bindings: iio: qcom,spmi-adc7-pmk8350.h: include sid into defines Dmitry Baryshkov
2023-04-01 22:07 ` [PATCH v2 06/22] arm64: dts: qcom: pmk8350: rename pon label Dmitry Baryshkov
2023-04-01 22:07 ` [PATCH v2 07/22] arm64: dts: qcom: pmk8350: port sdam_6 device from sc8280xp-pmics Dmitry Baryshkov
2023-04-03 10:09 ` Konrad Dybcio
2023-04-01 22:07 ` Dmitry Baryshkov [this message]
2023-04-03 10:11 ` [PATCH v2 08/22] arm64: dts: qcom: pmk8350: rename PMK8350_SID to PMIC_SID Konrad Dybcio
2023-04-01 22:07 ` [PATCH v2 09/22] arm64: dts: qcom: pmk8350: allow overriding the label Dmitry Baryshkov
2023-04-02 9:44 ` Krzysztof Kozlowski
2023-04-02 11:54 ` Dmitry Baryshkov
2023-04-03 10:14 ` Konrad Dybcio
2023-04-03 11:06 ` Dmitry Baryshkov
2023-04-01 22:07 ` [PATCH v2 10/22] arm64: dts: qcom: pmk8350: use interrupts-extended for IRQ specification Dmitry Baryshkov
2023-04-03 10:16 ` Konrad Dybcio
2023-04-01 22:07 ` [PATCH v2 11/22] arm64: dts: qcom: sc8280xp*: use pmk8350.dtsi Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 12/22] arm64: dts: qcom: pm8350: allow overriding SID and label Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 13/22] arm64: dts: qcom: pm8350: use interrupts-extended for IRQ specification Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 14/22] arm64: dts: qcom: sc8280xp*: use pm8350.dtsi Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 15/22] arm64: dts: qcom: pm8350c: move thermal zone declaration to the top Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 16/22] arm64: dts: qcom: pm8350c: allow overriding SID and label Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 17/22] arm64: dts: qcom: pm8350c: use interrupts-extended for IRQ specification Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 18/22] arm64: dts: qcom: sc8280xp*: use pm8350c.dtsi Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 19/22] arm64: dts: qcom: sc8280xp*: use pmr735a.dtsi Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 20/22] arm64: dts: qcom: pm8150: convert to use dynamic SID/LABEL Dmitry Baryshkov
2023-04-02 9:47 ` Krzysztof Kozlowski
2023-04-01 22:08 ` [PATCH v2 21/22] arch: arm64: dts: qcom: pm8150: support SID greater that 9 Dmitry Baryshkov
2023-04-02 9:51 ` Krzysztof Kozlowski
2023-04-03 10:35 ` Konrad Dybcio
2023-04-03 11:45 ` Dmitry Baryshkov
2023-04-03 12:56 ` Krzysztof Kozlowski
2023-04-03 13:56 ` Dmitry Baryshkov
2023-04-01 22:08 ` [PATCH v2 22/22] arm64: dts: qcom sa8540p-pmics: switch to pm8150.dtsi Dmitry Baryshkov
2023-04-02 9:55 ` [PATCH v2 00/22] arm64: dts: qcom: remove duplication in PMIC declarations Krzysztof Kozlowski
2023-04-03 10:44 ` Konrad Dybcio
2023-04-03 11:37 ` Dmitry Baryshkov
2023-04-03 13:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230401220810.3563708-9-dmitry.baryshkov@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).