From: Yong Wu <yong.wu@mediatek.com>
To: Joerg Roedel <joro@8bytes.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Hans Verkuil <hverkuil@xs4all.nl>, <nfraprado@collabora.com>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <iommu@lists.linux.dev>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
<mingyuan.ma@mediatek.com>, <yf.wang@mediatek.com>,
<jianjiao.zeng@mediatek.com>,
Yunfei Dong <yunfei.dong@mediatek.com>,
kyrie wu <kyrie.wu@mediatek.corp-partner.google.com>,
<chengci.xu@mediatek.com>, <youlin.pei@mediatek.com>,
<anan.sun@mediatek.com>, Yong Wu <yong.wu@mediatek.com>
Subject: [PATCH v6 09/14] iommu/mediatek: Set dma_mask for the master devices
Date: Mon, 3 Apr 2023 17:13:32 +0800 [thread overview]
Message-ID: <20230403091337.26745-10-yong.wu@mediatek.com> (raw)
In-Reply-To: <20230403091337.26745-1-yong.wu@mediatek.com>
MediaTek iommu arranges dma ranges for all the masters, this patch is to
help them set dma mask. This is to avoid each master setting their own
mask, but also to avoid a real issue, such as JPEG uses
"mediatek,mtk-jpgenc" for 2701/8183/8186/8188, then JPEG could ignore its
different dma_mask in different SoC to achieve common code.
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
---
drivers/iommu/mtk_iommu.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index 0e104bb27010..f58b970dccf2 100644
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -738,6 +738,14 @@ static int mtk_iommu_attach_device(struct iommu_domain *domain,
}
mutex_unlock(&data->mutex);
+ if (region_id > 0) {
+ ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(34));
+ if (ret) {
+ dev_err(m4udev, "Failed to set dma_mask for %s(%d).\n", dev_name(dev), ret);
+ return ret;
+ }
+ }
+
return mtk_iommu_config(data, dev, true, region_id);
err_unlock:
--
2.25.1
next prev parent reply other threads:[~2023-04-03 9:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 9:13 [PATCH v6 00/14] Adjust the dma-ranges for MTK IOMMU Yong Wu
2023-04-03 9:13 ` [PATCH v6 01/14] dt-bindings: media: mediatek,vcodec: Remove dma-ranges property Yong Wu
2023-04-03 13:58 ` Nícolas F. R. A. Prado
2023-04-04 0:49 ` Yong Wu (吴勇)
2023-04-03 9:13 ` [PATCH v6 02/14] dt-bindings: media: mediatek,jpeg: " Yong Wu
2023-04-03 9:13 ` [PATCH v6 03/14] iommu/mediatek: Improve comment for the current region/bank Yong Wu
2023-04-03 9:13 ` [PATCH v6 04/14] iommu/mediatek: Get regionid from larb/port id Yong Wu
2023-04-03 9:13 ` [PATCH v6 05/14] iommu/mediatek: mt8192: Add iova_region_larb_msk Yong Wu
2023-04-03 9:13 ` [PATCH v6 06/14] iommu/mediatek: mt8195: " Yong Wu
2023-04-03 9:13 ` [PATCH v6 07/14] iommu/mediatek: mt8186: " Yong Wu
2023-04-03 9:13 ` [PATCH v6 08/14] iommu/mediatek: Add a gap for the iova regions Yong Wu
2023-04-03 9:13 ` Yong Wu [this message]
2023-04-03 9:13 ` [PATCH v6 10/14] media: mtk-jpegdec: Remove the setting for dma_mask Yong Wu
2023-04-03 9:13 ` [PATCH v6 11/14] media: mediatek: vcodec: " Yong Wu
2023-04-03 9:13 ` [PATCH v6 12/14] arm64: dts: mt8195: Remove the unnecessary dma-ranges Yong Wu
2023-04-03 9:13 ` [PATCH v6 13/14] arm64: dts: mt8195: Add dma-ranges for the parent "soc" node Yong Wu
2023-04-03 9:13 ` [PATCH v6 14/14] arm64: dts: mt8186: " Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230403091337.26745-10-yong.wu@mediatek.com \
--to=yong.wu@mediatek.com \
--cc=anan.sun@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chengci.xu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=iommu@lists.linux.dev \
--cc=jianjiao.zeng@mediatek.com \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kyrie.wu@mediatek.corp-partner.google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=mingyuan.ma@mediatek.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yf.wang@mediatek.com \
--cc=youlin.pei@mediatek.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).