From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Will Deacon <will@kernel.org>
Cc: Sibi Sankar <quic_sibis@quicinc.com>,
andersson@kernel.org, agross@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, konrad.dybcio@somainline.org,
amit.pundir@linaro.org, regressions@leemhuis.info,
sumit.semwal@linaro.org, catalin.marinas@arm.com,
robin.murphy@arm.com
Subject: Re: [PATCH V4 00/11] Fix XPU violation during modem metadata authentication
Date: Mon, 3 Apr 2023 21:38:52 +0530 [thread overview]
Message-ID: <20230403160852.GD11346@thinkpad> (raw)
In-Reply-To: <20230327161857.GA32697@willie-the-truck>
On Mon, Mar 27, 2023 at 05:18:57PM +0100, Will Deacon wrote:
> Hi Sibi,
>
> On Tue, Jan 17, 2023 at 02:28:29PM +0530, Sibi Sankar wrote:
> > The memory region allocated using dma_alloc_attr with no kernel mapping
> > attribute set would still be a part of the linear kernel map. Any access
> > to this region by the application processor after assigning it to the
> > remote Q6 will result in a XPU violation. Fix this by replacing the
> > dynamically allocated memory region with a no-map carveout and unmap the
> > modem metadata memory region before passing control to the remote Q6.
> > The addition of the carveout and memunmap is required only on SoCs that
> > mandate memory protection before transferring control to Q6, hence the
> > driver falls back to dynamic memory allocation in the absence of the
> > modem metadata carveout.
>
> [...]
>
> > remoteproc: qcom_q6v5_mss: Use a carveout to authenticate modem
> > headers
>
> With this change now merged, am I ok to downgrade the arm64
> arch_dma_prep_coherent() back to a clean?
>
I think you can. If something breaks, we will fix it (without reverting) ;)
- Mani
> Thanks,
>
> Will
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2023-04-03 16:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 8:58 [PATCH V4 00/11] Fix XPU violation during modem metadata authentication Sibi Sankar
2023-01-17 8:58 ` [PATCH V4 01/11] dt-bindings: remoteproc: qcom,q6v5: Move MSM8996 to schema Sibi Sankar
2023-01-17 8:58 ` [PATCH V4 02/11] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Update memory region Sibi Sankar
2023-01-17 8:58 ` [PATCH V4 03/11] dt-bindings: remoteproc: qcom,sc7180-mss-pil: Update memory-region Sibi Sankar
2023-01-17 8:58 ` [PATCH V4 04/11] dt-bindings: remoteproc: qcom,sc7280-mss-pil: " Sibi Sankar
2023-01-17 8:58 ` [PATCH V4 05/11] Revert "remoteproc: qcom_q6v5_mss: map/unmap metadata region before/after use" Sibi Sankar
2023-01-17 8:58 ` [PATCH V4 06/11] remoteproc: qcom_q6v5_mss: Use a carveout to authenticate modem headers Sibi Sankar
2023-01-18 15:28 ` Manivannan Sadhasivam
2023-01-17 8:58 ` [PATCH V4 07/11] arm64: dts: qcom: msm8996: Add a carveout for modem metadata Sibi Sankar
2023-01-17 8:58 ` [PATCH V4 08/11] arm64: dts: qcom: msm8998: " Sibi Sankar
2023-01-17 8:58 ` [PATCH V4 09/11] arm64: dts: qcom: sdm845: " Sibi Sankar
2023-01-17 8:58 ` [PATCH V4 10/11] arm64: dts: qcom: sc7180: " Sibi Sankar
2023-01-17 8:58 ` [PATCH V4 11/11] arm64: dts: qcom: sc7280: " Sibi Sankar
2023-01-19 3:44 ` (subset) [PATCH V4 00/11] Fix XPU violation during modem metadata authentication Bjorn Andersson
2023-03-27 16:18 ` Will Deacon
2023-04-03 16:08 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230403160852.GD11346@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=agross@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_sibis@quicinc.com \
--cc=regressions@leemhuis.info \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sumit.semwal@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).