devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Peter Robinson <pbrobinson@gmail.com>,
	Javier Martinez Canillas <javierm@redhat.com>,
	Caleb Connolly <kc@postmarketos.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Jarrah Gosbell <kernel@undef.tools>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Martijn Braam <martijn@brixit.nl>, Ondrej Jirman <megi@xff.cz>,
	Rob Herring <robh+dt@kernel.org>,
	Tom Fitzhenry <tom@tom-fitzhenry.me.uk>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: [PATCH] arm64: dts: rockchip: Change serial baud rate for Pinephone Pro to 1.5 MB
Date: Mon,  3 Apr 2023 19:59:37 +0200	[thread overview]
Message-ID: <20230403175937.2842085-1-javierm@redhat.com> (raw)

This baud rate is set for the device by mainline u-boot and is also what
is set in the Pinebook Pro Device Tree, which is a device similar to the
PinePhone Pro but with a different form factor.

Otherwise, the baud rate of the firmware and Linux don't match by default
and a 'console=ttyS2,1500000n8' kernel command line parameter is required
to have proper output for both.

Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---

I tried to instead get rid of the baud rate altogether, as suggested by
Peter Robinson. AFAIU that should just pick whatever bad rate has been
using by the early console.

But neither using 'stdout-path = "serial2" nor 'stdout-path = &uart2'
worked for me.

In both cases I didn't have any output unless setting a baud rate using
the 'console='param.

 arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index a0795a2b1cb1..6bbe65bd5bd4 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -26,7 +26,7 @@ aliases {
 	};
 
 	chosen {
-		stdout-path = "serial2:115200n8";
+		stdout-path = "serial2:1500000n8";
 	};
 
 	gpio-keys {

base-commit: 3adf89324a2b2a9dbc2c12d8895021e7e34e3346
-- 
2.40.0


             reply	other threads:[~2023-04-03 18:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03 17:59 Javier Martinez Canillas [this message]
2023-04-04  7:51 ` [PATCH] arm64: dts: rockchip: Change serial baud rate for Pinephone Pro to 1.5 MB Heiko Stübner
2023-04-04  8:08   ` Javier Martinez Canillas
2023-04-04  8:13   ` Jarrah
2023-04-04  8:18     ` Peter Robinson
2023-04-04  8:25       ` Javier Martinez Canillas
2023-04-04  8:24     ` Javier Martinez Canillas
2023-04-04  8:38       ` Peter Robinson
2023-04-04  8:46         ` Javier Martinez Canillas
2023-04-04 11:31   ` Martijn Braam
2023-04-04 11:42     ` Javier Martinez Canillas
2023-04-04 12:02       ` Ondřej Jirman
2023-04-04 12:36   ` Ondřej Jirman
2023-04-04 14:04     ` Javier Martinez Canillas
2023-04-04 15:40       ` Ondřej Jirman
2023-04-04 12:52   ` Peter Geis
2023-04-04 16:55     ` Heiko Stübner
2023-04-18 12:11       ` Javier Martinez Canillas
2023-04-18 14:26         ` Heiko Stübner
2023-07-21 23:06           ` Javier Martinez Canillas
2023-07-28 18:59             ` Heiko Stuebner
2023-07-28 19:55               ` Maya Matuszczyk
2023-07-28 23:05                 ` Javier Martinez Canillas
2023-07-28 20:10               ` Ondřej Jirman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230403175937.2842085-1-javierm@redhat.com \
    --to=javierm@redhat.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=kc@postmarketos.org \
    --cc=kernel@undef.tools \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=martijn@brixit.nl \
    --cc=megi@xff.cz \
    --cc=pbrobinson@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=tom@tom-fitzhenry.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).