From: Rob Herring <robh@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv1 1/2] dt-bindings: usb: generic-ohci: increase allowed clocks
Date: Mon, 3 Apr 2023 16:55:34 -0500 [thread overview]
Message-ID: <20230403215534.GA1935153-robh@kernel.org> (raw)
In-Reply-To: <20230331163148.5863-2-sebastian.reichel@collabora.com>
On Fri, Mar 31, 2023 at 06:31:47PM +0200, Sebastian Reichel wrote:
> Increase number of allowed clocks to 4, which is the number
> required on Rockchip RK3588.
It was 3 because that's what crept in until we made a schema. Additions
should really have a specific compatible and a conditional schema
limiting that 4 clocks to that compatible.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> Documentation/devicetree/bindings/usb/generic-ohci.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> index a9ba7257b884..c0880d0664f1 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> @@ -69,7 +69,7 @@ properties:
>
> clocks:
> minItems: 1
> - maxItems: 3
> + maxItems: 4
> description: |
> In case the Renesas R-Car Gen3 SoCs:
> - if a host only channel: first clock should be host.
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-04-03 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 16:31 [PATCHv1 0/2] generic-ohci: increase allowed clocks Sebastian Reichel
2023-03-31 16:31 ` [PATCHv1 1/2] dt-bindings: usb: " Sebastian Reichel
2023-04-03 21:55 ` Rob Herring [this message]
2023-03-31 16:31 ` [PATCHv1 2/2] usb: host: ohci-platform: increase max clock number to 4 Sebastian Reichel
2023-03-31 16:41 ` [PATCHv1 0/2] generic-ohci: increase allowed clocks Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230403215534.GA1935153-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).