From: Devi Priya <quic_devipriy@quicinc.com>
To: <agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <lpieralisi@kernel.org>,
<kw@linux.com>, <robh@kernel.org>, <bhelgaas@google.com>,
<krzysztof.kozlowski+dt@linaro.org>, <vkoul@kernel.org>,
<kishon@kernel.org>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <mani@kernel.org>, <p.zabel@pengutronix.de>,
<linus.walleij@linaro.org>, <linux-arm-msm@vger.kernel.org>,
<linux-pci@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<linux-clk@vger.kernel.org>, <linux-gpio@vger.kernel.org>
Cc: <quic_srichara@quicinc.com>, <quic_gokulsri@quicinc.com>,
<quic_sjaganat@quicinc.com>, <quic_kathirav@quicinc.com>,
<quic_arajkuma@quicinc.com>, <quic_anusha@quicinc.com>,
<quic_ipkumar@quicinc.com>
Subject: [PATCH V2 3/9] dt-bindings: phy: qcom,qmp-pcie: Add ipq9574 bindings
Date: Tue, 4 Apr 2023 22:18:22 +0530 [thread overview]
Message-ID: <20230404164828.8031-4-quic_devipriy@quicinc.com> (raw)
In-Reply-To: <20230404164828.8031-1-quic_devipriy@quicinc.com>
Add bindings for the PCIe QMP PHYs found on IPQ9574
Signed-off-by: Devi Priya <quic_devipriy@quicinc.com>
---
Changes in V2:
- Added the ipq9574 bindings here as the phy nodes in the DT
are modified to follow the latest style (without child node)
.../phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 103 ++++++++++++++----
1 file changed, 84 insertions(+), 19 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
index a0407fc79563..6ea442c1378b 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
@@ -16,6 +16,8 @@ description:
properties:
compatible:
enum:
+ - qcom,ipq9574-qmp-gen3x1-pcie-phy
+ - qcom,ipq9574-qmp-gen3x2-pcie-phy
- qcom,sc8280xp-qmp-gen3x1-pcie-phy
- qcom,sc8280xp-qmp-gen3x2-pcie-phy
- qcom,sc8280xp-qmp-gen3x4-pcie-phy
@@ -34,13 +36,7 @@ properties:
clock-names:
minItems: 5
- items:
- - const: aux
- - const: cfg_ahb
- - const: ref
- - const: rchng
- - const: pipe
- - const: pipediv2
+ maxItems: 6
power-domains:
maxItems: 1
@@ -51,9 +47,7 @@ properties:
reset-names:
minItems: 1
- items:
- - const: phy
- - const: phy_nocsr
+ maxItems: 2
vdda-phy-supply: true
@@ -84,11 +78,8 @@ required:
- reg
- clocks
- clock-names
- - power-domains
- resets
- reset-names
- - vdda-phy-supply
- - vdda-pll-supply
- "#clock-cells"
- clock-output-names
- "#phy-cells"
@@ -128,13 +119,58 @@ allOf:
clocks:
maxItems: 5
clock-names:
- maxItems: 5
- else:
+ items:
+ - const: aux
+ - const: cfg_ahb
+ - const: ref
+ - const: rchng
+ - const: pipe
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sc8280xp-qmp-gen3x1-pcie-phy
+ - qcom,sc8280xp-qmp-gen3x2-pcie-phy
+ - qcom,sc8280xp-qmp-gen3x4-pcie-phy
+ then:
properties:
clocks:
minItems: 6
clock-names:
- minItems: 6
+ items:
+ - const: aux
+ - const: cfg_ahb
+ - const: ref
+ - const: rchng
+ - const: pipe
+ - const: pipediv2
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,ipq9574-qmp-gen3x1-pcie-phy
+ - qcom,ipq9574-qmp-gen3x2-pcie-phy
+ then:
+ properties:
+ clocks:
+ maxItems: 5
+ clock-names:
+ items:
+ - const: aux
+ - const: cfg_ahb
+ - const: anoc_lane
+ - const: snoc_lane
+ - const: pipe
+ resets:
+ maxItems: 2
+ reset-names:
+ items:
+ - const: phy
+ - const: common
- if:
properties:
@@ -147,13 +183,42 @@ allOf:
resets:
minItems: 2
reset-names:
- minItems: 2
- else:
+ items:
+ - const: phy
+ - const: phy_nocsr
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sc8280xp-qmp-gen3x1-pcie-phy
+ - qcom,sc8280xp-qmp-gen3x2-pcie-phy
+ - qcom,sc8280xp-qmp-gen3x4-pcie-phy
+ - qcom,sm8350-qmp-gen3x1-pcie-phy
+ - qcom,sm8550-qmp-gen3x2-pcie-phy
+
+ then:
properties:
resets:
maxItems: 1
reset-names:
- maxItems: 1
+ items:
+ - const: phy
+
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,ipq9574-qmp-gen3x1-pcie-phy
+ - qcom,ipq9574-qmp-gen3x2-pcie-phy
+ then:
+ required:
+ - power-domains
+ - vdda-phy-supply
+ - vdda-pll-supply
examples:
- |
--
2.17.1
next prev parent reply other threads:[~2023-04-04 16:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 16:48 [PATCH V2 0/9] Add PCIe support for IPQ9574 Devi Priya
2023-04-04 16:48 ` [PATCH V2 1/9] dt-bindings: clock: Add PCIe pipe clock definitions Devi Priya
2023-04-04 20:11 ` Stephen Boyd
2023-04-05 6:44 ` Krzysztof Kozlowski
2023-04-04 16:48 ` [PATCH V2 2/9] clk: qcom: gcc-ipq9574: Add PCIe pipe clocks Devi Priya
2023-04-04 20:12 ` Stephen Boyd
2023-04-04 16:48 ` Devi Priya [this message]
2023-04-05 6:46 ` [PATCH V2 3/9] dt-bindings: phy: qcom,qmp-pcie: Add ipq9574 bindings Krzysztof Kozlowski
2023-04-05 6:49 ` Devi Priya
2023-04-04 16:48 ` [PATCH V2 4/9] phy: qcom-qmp-pcie: Add support for IPQ9574 g3x1 and g3x2 PCIEs Devi Priya
2023-04-10 15:21 ` Vinod Koul
2023-04-10 15:23 ` Devi Priya
2023-04-04 16:48 ` [PATCH V2 5/9] dt-bindings: PCI: qcom: Add IPQ9574 Devi Priya
2023-04-05 6:58 ` Krzysztof Kozlowski
2023-04-11 10:57 ` Devi Priya
2023-04-11 11:52 ` Manivannan Sadhasivam
2023-04-11 14:00 ` Devi Priya
2023-04-04 16:48 ` [PATCH V2 6/9] dt-bindings: pinctrl: qcom: Add few missing functions Devi Priya
2023-04-05 6:58 ` Krzysztof Kozlowski
2023-04-10 6:34 ` Devi Priya
2023-04-04 16:48 ` [PATCH V2 7/9] arm64: dts: qcom: ipq9574: Add PCIe PHYs and controller nodes Devi Priya
2023-04-04 16:48 ` [PATCH V2 8/9] arm64: dts: qcom: ipq9574: Enable PCIe PHYs and controllers Devi Priya
2023-04-04 16:48 ` [PATCH V2 9/9] PCI: qcom: Add support for IPQ9574 Devi Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404164828.8031-4-quic_devipriy@quicinc.com \
--to=quic_devipriy@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_anusha@quicinc.com \
--cc=quic_arajkuma@quicinc.com \
--cc=quic_gokulsri@quicinc.com \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_sjaganat@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).