From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B995C7619A for ; Wed, 5 Apr 2023 16:38:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233273AbjDEQiR (ORCPT ); Wed, 5 Apr 2023 12:38:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233235AbjDEQiO (ORCPT ); Wed, 5 Apr 2023 12:38:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 743AA4C31; Wed, 5 Apr 2023 09:38:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C6FDA629BE; Wed, 5 Apr 2023 16:38:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FCB3C43443; Wed, 5 Apr 2023 16:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680712692; bh=syKhDH18sc1NcY1/ySSVPv2qM6XNI1spR3GACAOsNJ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eBNtu1Pr52mhp899qkiRAQ3jV6O5ZfF7agoRgDSfE2Kov/aUqK7ByJkK10TOdw+0X 3WCXsxvRS43Z9Lyz2xY9BnQKKVTRIKzEr0FgrLu2MU8LYBrhazoPa55y5z8bI5WkR+ YwSQAMOiAhxm282qCVUe1Y1cNJvZQhpBqkqcEYC/swER81ncPq3WNN1br3XCS9klTf T4F1g/Cab+mZbp1h5rPIys/HbGY0wqQ8feM7ryyu5WBcX0QZsD1r3NV6ay0UWmai08 psHGP5jshPyXILDcFR39tHCWgW05oHtBCZvCvRF4cKAun42UDKb6omKeU7L/Mo6QwE IH0DbsmV6DXog== Date: Wed, 5 Apr 2023 17:38:07 +0100 From: Conor Dooley To: William Qiu Cc: Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing Subject: Re: [RESEND v6 1/2] dt-bindings: soc: starfive: Add StarFive syscon doc Message-ID: <20230405-bullseye-handsaw-5c2e4dab772f@spud> References: <20230315055813.94740-1-william.qiu@starfivetech.com> <20230315055813.94740-2-william.qiu@starfivetech.com> <850bc37e-c6d1-2381-a851-965a4cbee8a0@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="l1+mDrVx6go5Y/WQ" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --l1+mDrVx6go5Y/WQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 20, 2023 at 03:32:14PM +0800, William Qiu wrote: > >>> Does not look like you tested the bindings. Please run `make > >>> dt_binding_check` (see > >>> Documentation/devicetree/bindings/writing-schema.rst for instructions= ). > >>> > >>> ... or your PLL clock controller was not tested. > >>> > >>> Best regards, > >>> Krzysztof > >>> > >> Hi Krzysztof, > >>=20 > >> I've already done`make dt_binding_check`, and get no error. So maybe P= LL clock controller > >> was not tested which I didn't add in this patch series. And PLL clock = controller belongs > >> to Xingyu Wu, I would tell him. > >=20 > > What's confusing you do not allow here clock controller. > I'll add it then. What's the plan here William? Can you sort something out with Xingyu Wu so that the dt-binding is added in a complete manner? In the meantime, gonna drop this series as "Changes Requested" from patchwork. Cheers, Conor. --l1+mDrVx6go5Y/WQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZC2j7wAKCRB4tDGHoIJi 0k+4AQCdBamxHmK76N715U1XwXpOgMU26jEqAcw7pKiI/4fH4gD9GXFxFJgrDOfu irkLH3kj2KloYVZ/9eNvQHp19BK9NQ4= =bLQ4 -----END PGP SIGNATURE----- --l1+mDrVx6go5Y/WQ--