From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A74CC76188 for ; Wed, 5 Apr 2023 09:07:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237636AbjDEJHc (ORCPT ); Wed, 5 Apr 2023 05:07:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237619AbjDEJH3 (ORCPT ); Wed, 5 Apr 2023 05:07:29 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A94324C31; Wed, 5 Apr 2023 02:07:28 -0700 (PDT) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3350fO77006850; Wed, 5 Apr 2023 08:58:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=tfeCTwscVhChaxXdNWUUPdUPQorf+0lrNukgnolz91Y=; b=P80Xj+zDsJNQPFukVg3BIvbZz7vDRimJRvMH5lOS1Ui6qffh8ejureGj9Ne3+mwi8oDD hf6D91CtbX6uiAOrNT3R/+hkvrCqBms/2509LVniYdupgm/d8bDNZ17ZOjdu3k9zFUph McXILQmfa+eEDrpT2GeJrQh3znM059kbmTvyTLvkAFBS1PWVXCnobuxVco7e7NqDIFLa buwqaNrWW+Zzw83xr+y9GKGEJRcL6Aw6zRWcu+XQb9oZ3Xb3d/yS1XR4n2f9FJguQEN4 hK01I8OYx0itgxas/w89DguVtuUxWEuhqiE3TDgdFB+nK+H2UxJtC+v72rTKiNOXv2Qj 6A== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3prppuj2yd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Apr 2023 08:58:43 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3358whes006874 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 5 Apr 2023 08:58:43 GMT Received: from varda-linux.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Wed, 5 Apr 2023 01:58:36 -0700 Date: Wed, 5 Apr 2023 14:28:32 +0530 From: Varadarajan Narayanan To: Johan Hovold CC: Dmitry Baryshkov , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v5 7/8] arm64: dts: qcom: ipq9574: Add USB related nodes Message-ID: <20230405085831.GA26156@varda-linux.qualcomm.com> References: <20230331092710.GB19162@varda-linux.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: M1LODQcyTa-eleXSBAkeNfjSdwR-KcDR X-Proofpoint-ORIG-GUID: M1LODQcyTa-eleXSBAkeNfjSdwR-KcDR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-05_05,2023-04-04_05,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 clxscore=1011 malwarescore=0 suspectscore=0 adultscore=0 mlxlogscore=941 phishscore=0 bulkscore=0 priorityscore=1501 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304050082 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Mar 31, 2023 at 12:19:10PM +0200, Johan Hovold wrote: > On Fri, Mar 31, 2023 at 02:57:11PM +0530, Varadarajan Narayanan wrote: > > On Thu, Mar 30, 2023 at 12:44:40PM +0300, Dmitry Baryshkov wrote: > > > On Thu, 30 Mar 2023 at 11:42, Varadarajan Narayanan > > > wrote: > > > > > > > > Add USB phy and controller related nodes > > > > > > > > Signed-off-by: Varadarajan Narayanan > > > > --- > > > > Changes in v5: > > > > - Fix additional comments > > > > - Edit nodes to match with qcom,sc8280xp-qmp-usb3-uni-phy.yaml > > > > - 'make dtbs_check' giving the following messages since > > > > ipq9574 doesn't have power domains. Hope this is ok > > > > > > > > /local/mnt/workspace/varada/varda-linux/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dtb: phy@7d000: 'power-domains' is a required property > > > > From schema: /local/mnt/workspace/varada/varda-linux/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml > > > > /local/mnt/workspace/varada/varda-linux/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dtb: usb@8a00000: 'power-domains' is a required property > > > > From schema: /local/mnt/workspace/varada/varda-linux/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > > > > > > No, I think it is not. > > > > There are no GDSCs in IPQ9574. Can you suggest how to proceed. > > You need to update the binding and either make the power domains > property optional in the binding or dependent on the SoC. > > > > > + ssphy_0: phy@7d000 { > > > > > > Nit: usually the label usb_0_qmpphy > > > > > > > + compatible = "qcom,ipq9574-qmp-usb3-phy"; > > > > + reg = <0x0007d000 0xa00>; > > > > + #phy-cells = <0>; > > > > + > > > > + clocks = <&gcc GCC_USB0_AUX_CLK>, > > > > + <&xo_board_clk>, > > > > + <&gcc GCC_USB0_PHY_CFG_AHB_CLK>, > > > > + <&gcc GCC_USB0_PIPE_CLK>; > > > > + clock-names = "aux", > > > > + "ref", > > > > + "com_aux", > > This is not the right name for this clock so you need to update the > binding first. > > Please be more careful. Thanks for your feedback. Have posted v6 with the above corrections. -Varada > > > > > + "pipe"; > > > > + > > > > + resets = <&gcc GCC_USB0_PHY_BCR>, > > > > + <&gcc GCC_USB3PHY_0_PHY_BCR>; > > > > + reset-names = "phy", > > > > + "phy_phy"; > > > > + > > > > + vdda-pll-supply = <®_usb_1p8>; > > > > + vdda-phy-supply = <®_usb_0p925>; > > > > + > > > > + status = "disabled"; > > > > + > > > > + #clock-cells = <0>; > > > > + clock-output-names = "usb0_pipe_clk"; > > > > + }; > > Johan