From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0A86C77B6C for ; Fri, 7 Apr 2023 15:41:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231358AbjDGPls (ORCPT ); Fri, 7 Apr 2023 11:41:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbjDGPlr (ORCPT ); Fri, 7 Apr 2023 11:41:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB25E8A72; Fri, 7 Apr 2023 08:41:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 466BD6121D; Fri, 7 Apr 2023 15:41:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEB0AC433D2; Fri, 7 Apr 2023 15:41:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680882105; bh=0TH7wao0u0XHYRas2C6c5JKYGQoZXugn+nq3+N4xTJk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mPzV60c1UwAVMfNfbVy+e73ZkApGMgI0fINmSiICLkTrG0kedj+gAsbihCIGgLkGp DY+Zwd0haHBBiTu/VLN0HuGGMvYsuHwk+1eosEdCfDOg/L9nXsa9ZqYyf/afsVZ39K HfenXNdWQhJ5L6w0qeqrB+YY/LCKKciwE1QLAuXvbbCIGoIZ4m4UZhNK5Nh04eV4l8 DTiPPszubCoToxejLfmHSkVrnt0+AScVDDg4YOapAmoX7NRV84rpNBrQRBVKVHjsSw 8jvtW0niDXS6uqs7DDs6xmrJ+Cybs+M9GXFyFdBQMnsTOQkspBqV4UAftUjCkqeQ84 MhVDemxnuQHTA== Date: Fri, 7 Apr 2023 08:44:35 -0700 From: Bjorn Andersson To: Souradeep Chowdhury Cc: Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sibi Sankar , Rajendra Nayak Subject: Re: [PATCH V2 0/3] soc: qcom: boot_stats: Add driver support for boot_stats Message-ID: <20230407154435.2wzrld365p3dcabd@ripper> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Apr 07, 2023 at 07:34:34PM +0530, Souradeep Chowdhury wrote: > Qualcomm's proprietary Android boot-loaders capture boot time > stats, like the time when the bootloader started execution and at what > point the bootloader handed over control to the kernel etc. in the IMEM > region. This information is captured in a specific format by this driver > by mapping a structure to the IMEM memory region and then accessing the > members of the structure to print the information. This information is > useful in verifying if existing boot KPIs have regressed or not. > A sample log in SM8450(waipio) device is as follows:- > > KPI: Pre ABL Time = 3s > KPI: ABL Time = 14s > KPI: Kernel MPM timestamp = 890206 > > The Module Power Manager(MPM) sleep counter starts ticking at the PBL > stage and the timestamp generated by the sleep counter is logged by > the Qualcomm proprietary bootloader(ABL) at two points-> First when it > starts execution which is logged here as "Pre ABL Time" and the second > when it is about to load the kernel logged as "ABL Time". Both these > values are read up by the driver from IMEM region and printed as above. > The current sleep counter timestamp is also logged by the driver. > > Changes in V2 > > *Implemented comments on version 1 of the patch This doesn't give a particular good indication of what you actually changed. So please spell it out going forward. Thanks, Bjorn > > *Changed the boot_stats driver to module_platform_driver > > *Dropped the DT binding for mpm sleep counter > > Souradeep Chowdhury (3): > dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM > soc: qcom: boot_stat: Add Driver Support for Boot Stats > MAINTAINERS: Add the entry for boot_stats driver support > > .../devicetree/bindings/sram/qcom,imem.yaml | 21 +++++ > MAINTAINERS | 6 ++ > drivers/soc/qcom/Kconfig | 7 ++ > drivers/soc/qcom/Makefile | 1 + > drivers/soc/qcom/boot_stats.c | 95 ++++++++++++++++++++++ > 5 files changed, 130 insertions(+) > create mode 100644 drivers/soc/qcom/boot_stats.c > > -- > 2.7.4 >