From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEEE9C77B61 for ; Mon, 10 Apr 2023 20:12:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229705AbjDJUMf (ORCPT ); Mon, 10 Apr 2023 16:12:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbjDJUMe (ORCPT ); Mon, 10 Apr 2023 16:12:34 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDB9CE6B for ; Mon, 10 Apr 2023 13:11:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681157505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aF+LN6zHkq+MYwedY1yELa2Syfx18KiVV4p0VX9cRU8=; b=Ysb9GVMJ5N35UG/qBShrcIi0WL1tSABcUp4WIXO7QTnl8SY06sjL/z9xQZk2q4uCqNGZ6E StOHNIG89pgxII8SehwifC6kUjbU7VDeI/NvJMP+c6Jpce1bEgetOta3PFhNGb0SgkF/gz 91IxTWXEf1gu0dbcOd/oWhM6Mz8FzTo= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-6-9_zA9kC5PUmu2LS1G_ZRkQ-1; Mon, 10 Apr 2023 16:11:44 -0400 X-MC-Unique: 9_zA9kC5PUmu2LS1G_ZRkQ-1 Received: by mail-qt1-f200.google.com with SMTP id s23-20020a05622a1a9700b003e6578904c3so16232959qtc.17 for ; Mon, 10 Apr 2023 13:11:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681157504; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aF+LN6zHkq+MYwedY1yELa2Syfx18KiVV4p0VX9cRU8=; b=DBJnLFK81yBrU7CbMnVGwmnQnuIk82XagKta8urmS+YPWur3v9HE8XBPrrkvFpCTtE CYy0REYz20yK9CYnGEklI8hNnWBiB7xl1d3uD1ThG3UdlZg3p9yMJ5q/gOSZER4kBjM1 Ld35Dd8wyKg+itywW3l+tkfplDWNll5BEGfRIvqWCkCkkdEc6g3dyj39XMJygsCuKsge +z5Mi5jOgpQ2/QxfNJWNhjgm5hZaP5MsVPZDmP1l/cg4yhODyOcCG8lqhLz6won34EHD k7v3BJg38JYJZJNutTHFMEzG+34eETfjKt6Gdcc0szS5aquGa8B4d2Dib7XBjx3A/6P3 iGLQ== X-Gm-Message-State: AAQBX9dFZiTCNCvNxfWuxOSXAPP46lL2N8JdR5l1Dcw7vgIGBD+uj0lz yYsthJexUKMI+B+5E8WA7mOacEia/Eh52XRdjBcqyxL7C7ARtowEW7OcxL5EnOWxMfmHZeIatoR zgI0/wFSh4RsBpP2h55uiXw== X-Received: by 2002:a05:622a:19a8:b0:3e3:913c:1ca8 with SMTP id u40-20020a05622a19a800b003e3913c1ca8mr530690qtc.22.1681157503813; Mon, 10 Apr 2023 13:11:43 -0700 (PDT) X-Google-Smtp-Source: AKy350ZpTbP2PVw2o8uUHr2dWI9RknpdGBALbZPgkbhmGvuYy32zsn/DFIhdrrDx1ewOr2ydR64RMA== X-Received: by 2002:a05:622a:19a8:b0:3e3:913c:1ca8 with SMTP id u40-20020a05622a19a800b003e3913c1ca8mr530654qtc.22.1681157503536; Mon, 10 Apr 2023 13:11:43 -0700 (PDT) Received: from localhost (pool-71-184-142-128.bstnma.fios.verizon.net. [71.184.142.128]) by smtp.gmail.com with ESMTPSA id n124-20020a374082000000b0074860fcfc00sm3447372qka.136.2023.04.10.13.11.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Apr 2023 13:11:43 -0700 (PDT) Date: Mon, 10 Apr 2023 16:11:45 -0400 From: Eric Chanudet To: Bartosz Golaszewski Cc: Bjorn Andersson , Andy Gross , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Will Deacon , Robin Murphy , Joerg Roedel , Catalin Marinas , Arnd Bergmann , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Bartosz Golaszewski Subject: Re: [PATCH v2 5/7] arm64: dts: qcom: sa8775p: add the pcie smmu node Message-ID: <20230410201145.6e2qsl5gtwh7n3k7@echanude> References: <20230406200723.552644-1-brgl@bgdev.pl> <20230406200723.552644-6-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230406200723.552644-6-brgl@bgdev.pl> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Apr 06, 2023 at 10:07:21PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add the PCIe SMMU node for sa8775p platforms. > > Signed-off-by: Bartosz Golaszewski > Reviewed-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 74 +++++++++++++++++++++++++++ > 1 file changed, 74 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 2343df7e0ea4..9ab630c7d81b 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -809,6 +809,80 @@ apps_smmu: iommu@15000000 { > ; > }; > > + pcie_smmu: iommu@15200000 { > + compatible = "qcom,sa8775p-smmu-500", "qcom,smmu-500", "arm,mmu-500"; > + reg = <0x0 0x15200000 0x0 0x800000>; Testing on the board, applying on next-20230406: [ 1.041869] arm-smmu 15200000.iommu: SMMU address space size (0x80000) differs from mapped region size (0x800000)! In the downstream sources, the size is 0x80000[1]. On reboot, I also get a synchronous abort, but the second line, from the following output on the serial, could indicate the hypervisor is behind it: [ 26.906206] arm-smmu 15200000.iommu: disabling translation 3 33.244434 Injecting instruction/data abort to VM 3, original ESR_EL2 = 0x93800047, fault VA = 0xffff80000a380000, fault IPA = 0x15200000, ELR_EL2 = 0xffffd064f70c9de8 [ 26.942083] Internal error: synchronous external abort: 0000000096000010 [#1] PREEMPT SMP [ 26.948506] Modules linked in: nvmem_qcom_spmi_sdam qcom_pon spi_geni_qcom nvmem_reboot_mode crct10dif_ce i2c_qcom_geni phy_qcom_qmp_ufs gpucc_sa8775p ufs_qcom socinfo fuse ipv6 [ 26.966702] CPU: 3 PID: 1 Comm: systemd-shutdow Not tainted 6.3.0-rc5-next-20230406-00019-g9d08a3c17f54-dirty #134 [ 26.977315] Hardware name: Qualcomm SA8775P Ride (DT) [ 26.982505] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 26.989651] pc : arm_smmu_device_shutdown+0x88/0x1d8 [ 26.994773] lr : arm_smmu_device_shutdown+0x70/0x1d8 [ 26.999875] sp : ffff80000805bbf0 [ 27.003283] x29: ffff80000805bbf0 x28: ffff0e69400a0000 x27: 0000000000000000 [ 27.010608] x26: ffffd064f8130f38 x25: 0000000000000001 x24: ffffd064f8eac028 [ 27.017932] x23: ffff0e6940eeb490 x22: ffffd064f8f24f80 x21: ffff0e6940eeb410 [ 27.025254] x20: ffff0e6940808c80 x19: ffff0e6940eeb410 x18: 0000000000000006 [ 27.032579] x17: 0000000000000001 x16: 0000000000000014 x15: ffff80000805b5c0 [ 27.039903] x14: 0000000000000000 x13: ffffd064f8ac19a8 x12: 0000000000000606 [ 27.047226] x11: 0000000000000202 x10: ffffd064f8b199a8 x9 : ffffd064f8ac19a8 [ 27.054549] x8 : 00000000ffffefff x7 : ffffd064f8b199a8 x6 : 80000000fffff000 [ 27.061872] x5 : 000000000000bff4 x4 : 0000000000000000 x3 : 0000000000000000 [ 27.069195] x2 : 0000000000000000 x1 : ffff80000a380000 x0 : 0000000000000001 [ 27.076520] Call trace: [ 27.079041] arm_smmu_device_shutdown+0x88/0x1d8 [ 27.083787] platform_shutdown+0x24/0x34 [ 27.087825] device_shutdown+0x150/0x258 [ 27.091859] kernel_restart+0x40/0xc0 [ 27.095632] __do_sys_reboot+0x1f0/0x274 [ 27.099664] __arm64_sys_reboot+0x24/0x30 [ 27.103786] invoke_syscall+0x48/0x114 [ 27.107644] el0_svc_common+0x40/0xf4 [ 27.111410] do_el0_svc+0x3c/0x9c [ 27.114822] el0_svc+0x2c/0x84 [ 27.117969] el0t_64_sync_handler+0xf4/0x120 [ 27.122357] el0t_64_sync+0x190/0x194 [ 27.126126] Code: f9400404 b50008e4 f9400681 52800020 (b9000020) [ 27.132385] ---[ end trace 0000000000000000 ]--- [1] https://git.codelinaro.org/clo/la/kernel/ark-5.14/-/blob/ES2/arch/arm64/boot/dts/qcom/lemans.dtsi#L3498 > + #iommu-cells = <2>; > + #global-interrupts = <2>; > + > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + }; > + > intc: interrupt-controller@17a00000 { > compatible = "arm,gic-v3"; > reg = <0x0 0x17a00000 0x0 0x10000>, /* GICD */ > -- > 2.37.2 > -- Eric Chanudet