From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4AE4C7619A for ; Tue, 11 Apr 2023 20:52:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229541AbjDKUwl (ORCPT ); Tue, 11 Apr 2023 16:52:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229765AbjDKUwk (ORCPT ); Tue, 11 Apr 2023 16:52:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51267469E; Tue, 11 Apr 2023 13:52:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 304AC60FA0; Tue, 11 Apr 2023 20:52:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C453C433D2; Tue, 11 Apr 2023 20:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681246358; bh=Uw2/Byf4kuU8+07mE//heEnMrZgOuJnGJy2pZr8fhEM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Kr7O+0tZrPjEw0m/XXSwGiAmEd0MbZYqCzhbwtcx7NCA01FSSC9pitekLgnICQxbi syANdkMkdw1wXFuiLU96iyGAW7TceQUdlVMG+sd7JcKbBTNlzFL6qMHoFB7n57Htw4 wo6n0LaAmGEh5FlbS8RBYEvlsa2iSUFr7THTM1mlNZdKnJKHStKO5tfowCNPf7Y4ug vl7TQstNxxUicCr9x2A7brZKNb+yKoIsxG4G/j+pVNvDnEQAJXLF7S2eKthRjnDNxV BicfhtBoLVOViQnorBBk7E5ByCJGD3PqOLQId1Ti6sSAHfvPEo1gg8xhllRLM0SpuH Py55B92WHjoNg== Date: Tue, 11 Apr 2023 21:52:33 +0100 From: Conor Dooley To: Changhuang Liang Cc: Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v1 4/7] soc: starfive: Add pmu type operation Message-ID: <20230411-flavoring-sternness-a3b6cdee9fcb@spud> References: <20230411064743.273388-1-changhuang.liang@starfivetech.com> <20230411064743.273388-5-changhuang.liang@starfivetech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9jTLzkgimlFJEOUu" Content-Disposition: inline In-Reply-To: <20230411064743.273388-5-changhuang.liang@starfivetech.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --9jTLzkgimlFJEOUu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey Changhuang Liang, On Mon, Apr 10, 2023 at 11:47:40PM -0700, Changhuang Liang wrote: > Add pmu type, make a distinction between different PMU. Please write more detailed commit messages, thanks. >=20 > Signed-off-by: Changhuang Liang > --- > drivers/soc/starfive/jh71xx_pmu.c | 55 ++++++++++++++++++++++--------- > 1 file changed, 39 insertions(+), 16 deletions(-) >=20 > diff --git a/drivers/soc/starfive/jh71xx_pmu.c b/drivers/soc/starfive/jh7= 1xx_pmu.c > index 306218c83691..98f6849d61de 100644 > --- a/drivers/soc/starfive/jh71xx_pmu.c > +++ b/drivers/soc/starfive/jh71xx_pmu.c > @@ -45,6 +45,12 @@ > */ > #define JH71XX_PMU_TIMEOUT_US 100 > =20 > +/* pmu type */ Delete this comment, it's obvious. > +enum pmu_type { > + JH71XX_PMU_GENERAL, I'm really not sold on GENERAL as a name. Why not name these after the compatibles? > + JH71XX_PMU_DPHY, > +}; > + > struct jh71xx_domain_info { > const char * const name; > unsigned int flags; > @@ -54,6 +60,7 @@ struct jh71xx_domain_info { > struct jh71xx_pmu_match_data { > const struct jh71xx_domain_info *domain_info; > int num_domains; > + u8 pmu_type; This is an enum, not a u8? Thanks, Conor. --9jTLzkgimlFJEOUu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZDXIkQAKCRB4tDGHoIJi 0kByAP97IOiAFgI8nObj/x4ZMdTZk7xSaKs/qUUM2jPffnTMYQD+KVvBSO9lhyL7 NFR2FZ7jNsQX8DC9ZEqOFcs91Gip5A4= =lb9a -----END PGP SIGNATURE----- --9jTLzkgimlFJEOUu--