From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F647C77B70 for ; Tue, 11 Apr 2023 16:36:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229679AbjDKQg2 (ORCPT ); Tue, 11 Apr 2023 12:36:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbjDKQgV (ORCPT ); Tue, 11 Apr 2023 12:36:21 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B86D540FC for ; Tue, 11 Apr 2023 09:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681230933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IbtBPHSuNg+l9dd12JhHU9qMR/3P53aSjvaTRVqWAQ8=; b=LZZSfwEJa1G1db0gsj3BPH/yU+nYO6SIeiTTr0vl5JRXEY+YWY3ylnqrEfA8n3rGLduCa3 MAdAy/6dbCU6qyeSHBUhDYR0kASxEb6gm1XdDokBiMlcBZHn+ksvpCLwwnLhgzt2NByNW/ vHtEUHKpm9qCmm4X41SVEngBcHK+nPI= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-_UEpqjo3MYSyqHM02RT3dA-1; Tue, 11 Apr 2023 12:35:32 -0400 X-MC-Unique: _UEpqjo3MYSyqHM02RT3dA-1 Received: by mail-qk1-f199.google.com with SMTP id t9-20020a37aa09000000b007468d9a30faso4480545qke.23 for ; Tue, 11 Apr 2023 09:35:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681230931; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IbtBPHSuNg+l9dd12JhHU9qMR/3P53aSjvaTRVqWAQ8=; b=HTsMVhWCgg9Bvm2ZrKdxn87jvwbxnclIDtK9c1Ii6tsWdjvvKq1nPOkCcZ8S0gM3iK 8rbslqfT0iIKH5dRrXZxV0xftrG1BpP8FfHkSGi0eg31//M3Ug+UD16dDeWtYTEfzfEC 87D/4+AXqKByY6W/yab1k6gU499UH57csLkUGjnaPCRdYffAqN2myvViX0kIAnHwz1MH FiKdIHX2em1OqNOhxE79pYTzkPEeHjLMKtAY5QlpklufyCljQPZvAHxffB5yY7u8N8Zv kwFqaZ9XkkxeG5uglPrtnyjSuIqbwVisrhCU0K/evdBy8v5vCUuW5voj9eaqqgPCZMBz Q41g== X-Gm-Message-State: AAQBX9eNQvKEVGjUxWNBBW9Bu8JiVttoH4Embx2Ul9ANJVFqwrcJyxNj /fR5j7xiwSO0gfEcw6Wx0Jq9kIfpZLxmOn9YsDks7fzY/i6arG3s6od1j1cZh6pjoJbJ2gmaAbM pQZSVdjhbD6iVaExlr4neHQ== X-Received: by 2002:a05:6214:2a89:b0:5c7:640:8997 with SMTP id jr9-20020a0562142a8900b005c706408997mr3573771qvb.51.1681230931530; Tue, 11 Apr 2023 09:35:31 -0700 (PDT) X-Google-Smtp-Source: AKy350bz1KQkDBTysgmiRm14e0+NS6PAvNiFxR+tz4hZ7NOPxEDAPL3RlewV0I8v19gSu2uwEYzMtg== X-Received: by 2002:a05:6214:2a89:b0:5c7:640:8997 with SMTP id jr9-20020a0562142a8900b005c706408997mr3573740qvb.51.1681230931179; Tue, 11 Apr 2023 09:35:31 -0700 (PDT) Received: from localhost (pool-71-184-142-128.bstnma.fios.verizon.net. [71.184.142.128]) by smtp.gmail.com with ESMTPSA id cz10-20020a056214088a00b005e8d802ce32sm2964371qvb.143.2023.04.11.09.35.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Apr 2023 09:35:30 -0700 (PDT) Date: Tue, 11 Apr 2023 12:35:33 -0400 From: Eric Chanudet To: Shazad Hussain Cc: Bartosz Golaszewski , Bjorn Andersson , Andy Gross , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Will Deacon , Robin Murphy , Joerg Roedel , Catalin Marinas , Arnd Bergmann , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Bartosz Golaszewski , Parikshit Pareek Subject: Re: [PATCH v2 5/7] arm64: dts: qcom: sa8775p: add the pcie smmu node Message-ID: <20230411163533.wyhzu4cfqecxjsmv@echanude> References: <20230406200723.552644-1-brgl@bgdev.pl> <20230406200723.552644-6-brgl@bgdev.pl> <20230410201145.6e2qsl5gtwh7n3k7@echanude> <24804682-6ead-03b1-8b21-3ac413187c4a@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <24804682-6ead-03b1-8b21-3ac413187c4a@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Apr 11, 2023 at 09:53:53PM +0530, Shazad Hussain wrote: > On 4/11/2023 5:20 PM, Bartosz Golaszewski wrote: > > On Mon, Apr 10, 2023 at 10:11 PM Eric Chanudet wrote: > > > > > > On Thu, Apr 06, 2023 at 10:07:21PM +0200, Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski > > > > > > > > Add the PCIe SMMU node for sa8775p platforms. > > > > > > > > Signed-off-by: Bartosz Golaszewski > > > > Reviewed-by: Konrad Dybcio > > > > --- > > > > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 74 +++++++++++++++++++++++++++ > > > > 1 file changed, 74 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > > > > index 2343df7e0ea4..9ab630c7d81b 100644 > > > > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > > > > @@ -809,6 +809,80 @@ apps_smmu: iommu@15000000 { > > > > ; > > > > }; > > > > > > > > + pcie_smmu: iommu@15200000 { > > > > + compatible = "qcom,sa8775p-smmu-500", "qcom,smmu-500", "arm,mmu-500"; > > > > + reg = <0x0 0x15200000 0x0 0x800000>; > > > > > > Testing on the board, applying on next-20230406: > > > [ 1.041869] arm-smmu 15200000.iommu: SMMU address space size (0x80000) differs from mapped region size (0x800000)! > > > > > > In the downstream sources, the size is 0x80000[1]. > > > > > > On reboot, I also get a synchronous abort, but the second line, from the > > > following output on the serial, could indicate the hypervisor is behind > > > it: > > > > > > [ 26.906206] arm-smmu 15200000.iommu: disabling translation > > > 3 33.244434 Injecting instruction/data abort to VM 3, original ESR_EL2 = 0x93800047, fault VA = 0xffff80000a380000, fault IPA = 0x15200000, ELR_EL2 = 0xffffd064f70c9de8 > > > [ 26.942083] Internal error: synchronous external abort: 0000000096000010 [#1] PREEMPT SMP > > > [ 26.948506] Modules linked in: nvmem_qcom_spmi_sdam qcom_pon spi_geni_qcom nvmem_reboot_mode crct10dif_ce i2c_qcom_geni phy_qcom_qmp_ufs gpucc_sa8775p ufs_qcom socinfo fuse ipv6 > > > [ 26.966702] CPU: 3 PID: 1 Comm: systemd-shutdow Not tainted 6.3.0-rc5-next-20230406-00019-g9d08a3c17f54-dirty #134 > > > [ 26.977315] Hardware name: Qualcomm SA8775P Ride (DT) > > > [ 26.982505] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > > > [ 26.989651] pc : arm_smmu_device_shutdown+0x88/0x1d8 > > > [ 26.994773] lr : arm_smmu_device_shutdown+0x70/0x1d8 > > > [ 26.999875] sp : ffff80000805bbf0 > > > [ 27.003283] x29: ffff80000805bbf0 x28: ffff0e69400a0000 x27: 0000000000000000 > > > [ 27.010608] x26: ffffd064f8130f38 x25: 0000000000000001 x24: ffffd064f8eac028 > > > [ 27.017932] x23: ffff0e6940eeb490 x22: ffffd064f8f24f80 x21: ffff0e6940eeb410 > > > [ 27.025254] x20: ffff0e6940808c80 x19: ffff0e6940eeb410 x18: 0000000000000006 > > > [ 27.032579] x17: 0000000000000001 x16: 0000000000000014 x15: ffff80000805b5c0 > > > [ 27.039903] x14: 0000000000000000 x13: ffffd064f8ac19a8 x12: 0000000000000606 > > > [ 27.047226] x11: 0000000000000202 x10: ffffd064f8b199a8 x9 : ffffd064f8ac19a8 > > > [ 27.054549] x8 : 00000000ffffefff x7 : ffffd064f8b199a8 x6 : 80000000fffff000 > > > [ 27.061872] x5 : 000000000000bff4 x4 : 0000000000000000 x3 : 0000000000000000 > > > [ 27.069195] x2 : 0000000000000000 x1 : ffff80000a380000 x0 : 0000000000000001 > > > [ 27.076520] Call trace: > > > [ 27.079041] arm_smmu_device_shutdown+0x88/0x1d8 > > > [ 27.083787] platform_shutdown+0x24/0x34 > > > [ 27.087825] device_shutdown+0x150/0x258 > > > [ 27.091859] kernel_restart+0x40/0xc0 > > > [ 27.095632] __do_sys_reboot+0x1f0/0x274 > > > [ 27.099664] __arm64_sys_reboot+0x24/0x30 > > > [ 27.103786] invoke_syscall+0x48/0x114 > > > [ 27.107644] el0_svc_common+0x40/0xf4 > > > [ 27.111410] do_el0_svc+0x3c/0x9c > > > [ 27.114822] el0_svc+0x2c/0x84 > > > [ 27.117969] el0t_64_sync_handler+0xf4/0x120 > > > [ 27.122357] el0t_64_sync+0x190/0x194 > > > [ 27.126126] Code: f9400404 b50008e4 f9400681 52800020 (b9000020) > > > [ 27.132385] ---[ end trace 0000000000000000 ]--- > > > > > > > Adding Shazad > > > > Eric: This is supposedly gone in the latest meta but I thought you're > > already on the most recent release? > > > > Shazad, what version exactly should Eric test this on? > > > > Bart > > > > Hi Bart, We should use r00004.1 to verify this. Adding Parikshit to > confirm on the same. I do not have a system with that version flashed on yet. The one I had must have been on r00003.4. I'll redo the test on an upgraded system. > > -Shazad > > > > [1] https://git.codelinaro.org/clo/la/kernel/ark-5.14/-/blob/ES2/arch/arm64/boot/dts/qcom/lemans.dtsi#L3498 > > > > > > > + #iommu-cells = <2>; > > > > + #global-interrupts = <2>; > > > > + > > > > + interrupts = , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + , > > > > + ; > > > > + }; > > > > + > > > > intc: interrupt-controller@17a00000 { > > > > compatible = "arm,gic-v3"; > > > > reg = <0x0 0x17a00000 0x0 0x10000>, /* GICD */ > > > > -- > > > > 2.37.2 > > > > > > > > > > -- > > > Eric Chanudet > > > > -- Eric Chanudet