devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: mfd: stm32: Fix STM32F4 DT include file
@ 2023-04-07 18:12 Patrick Delaunay
  2023-04-12 15:03 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Patrick Delaunay @ 2023-04-07 18:12 UTC (permalink / raw)
  To: Alexandre TORGUE, Lee Jones, Rob Herring, Krzysztof Kozlowski,
	Maxime Coquelin
  Cc: Patrick Delaunay, devicetree, linux-arm-kernel, linux-kernel,
	linux-stm32

Minor cosmetic change, aligned with file in U-Boot:
- remove extra space

Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
---

 include/dt-bindings/mfd/stm32f4-rcc.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/dt-bindings/mfd/stm32f4-rcc.h b/include/dt-bindings/mfd/stm32f4-rcc.h
index 309e8c79f27b..36448a5619a1 100644
--- a/include/dt-bindings/mfd/stm32f4-rcc.h
+++ b/include/dt-bindings/mfd/stm32f4-rcc.h
@@ -34,7 +34,6 @@
 #define STM32F4_AHB1_RESET(bit) (STM32F4_RCC_AHB1_##bit + (0x10 * 8))
 #define STM32F4_AHB1_CLOCK(bit) (STM32F4_RCC_AHB1_##bit)
 
-
 /* AHB2 */
 #define STM32F4_RCC_AHB2_DCMI	0
 #define STM32F4_RCC_AHB2_CRYP	4
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: mfd: stm32: Fix STM32F4 DT include file
  2023-04-07 18:12 [PATCH] dt-bindings: mfd: stm32: Fix STM32F4 DT include file Patrick Delaunay
@ 2023-04-12 15:03 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2023-04-12 15:03 UTC (permalink / raw)
  To: Patrick Delaunay
  Cc: Alexandre TORGUE, Lee Jones, Krzysztof Kozlowski, Maxime Coquelin,
	devicetree, linux-arm-kernel, linux-kernel, linux-stm32

On Fri, Apr 07, 2023 at 08:12:43PM +0200, Patrick Delaunay wrote:
> Minor cosmetic change, aligned with file in U-Boot:
> - remove extra space

extra blank line really.

Please make the subject reflect what the change is. This doesn't really 
'Fix' anything and it's so generic it could be any change. Just 'Remove 
double blank line' would be much better and defines the exact change.

> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
> 
>  include/dt-bindings/mfd/stm32f4-rcc.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/dt-bindings/mfd/stm32f4-rcc.h b/include/dt-bindings/mfd/stm32f4-rcc.h
> index 309e8c79f27b..36448a5619a1 100644
> --- a/include/dt-bindings/mfd/stm32f4-rcc.h
> +++ b/include/dt-bindings/mfd/stm32f4-rcc.h
> @@ -34,7 +34,6 @@
>  #define STM32F4_AHB1_RESET(bit) (STM32F4_RCC_AHB1_##bit + (0x10 * 8))
>  #define STM32F4_AHB1_CLOCK(bit) (STM32F4_RCC_AHB1_##bit)
>  
> -
>  /* AHB2 */
>  #define STM32F4_RCC_AHB2_DCMI	0
>  #define STM32F4_RCC_AHB2_CRYP	4
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-04-12 15:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-07 18:12 [PATCH] dt-bindings: mfd: stm32: Fix STM32F4 DT include file Patrick Delaunay
2023-04-12 15:03 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).