* [PATCH] arm64: dts: rockchip: Add pinctrl gpio-ranges for rk356x
@ 2023-04-13 14:43 John Clark
2023-04-13 16:11 ` Krzysztof Kozlowski
2023-04-13 17:03 ` [v2] " John Clark
0 siblings, 2 replies; 4+ messages in thread
From: John Clark @ 2023-04-13 14:43 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Peter Geis
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
John Clark
Add gpio-range properties to the pinctrl gpio nodes in rk356x.dtsi
Signed-off-by: John Clark <inindev@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk356x.dtsi | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
index 802fcc96384e..793dbcb981dc 100644
--- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
@@ -1796,11 +1796,11 @@ usb2phy1_otg: otg-port {
pinctrl: pinctrl {
compatible = "rockchip,rk3568-pinctrl";
+ ranges;
rockchip,grf = <&grf>;
rockchip,pmu = <&pmugrf>;
#address-cells = <2>;
#size-cells = <2>;
- ranges;
gpio0: gpio@fdd60000 {
compatible = "rockchip,gpio-bank";
@@ -1808,6 +1808,7 @@ gpio0: gpio@fdd60000 {
interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&pmucru PCLK_GPIO0>, <&pmucru DBCLK_GPIO0>;
gpio-controller;
+ gpio-ranges = <&pinctrl 0 0 32>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -1819,6 +1820,7 @@ gpio1: gpio@fe740000 {
interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru PCLK_GPIO1>, <&cru DBCLK_GPIO1>;
gpio-controller;
+ gpio-ranges = <&pinctrl 0 32 32>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -1830,6 +1832,7 @@ gpio2: gpio@fe750000 {
interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru PCLK_GPIO2>, <&cru DBCLK_GPIO2>;
gpio-controller;
+ gpio-ranges = <&pinctrl 0 64 32>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -1841,6 +1844,7 @@ gpio3: gpio@fe760000 {
interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru PCLK_GPIO3>, <&cru DBCLK_GPIO3>;
gpio-controller;
+ gpio-ranges = <&pinctrl 0 96 32>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -1852,6 +1856,7 @@ gpio4: gpio@fe770000 {
interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru PCLK_GPIO4>, <&cru DBCLK_GPIO4>;
gpio-controller;
+ gpio-ranges = <&pinctrl 0 128 32>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Add pinctrl gpio-ranges for rk356x
2023-04-13 14:43 [PATCH] arm64: dts: rockchip: Add pinctrl gpio-ranges for rk356x John Clark
@ 2023-04-13 16:11 ` Krzysztof Kozlowski
2023-04-13 17:03 ` [v2] " John Clark
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-13 16:11 UTC (permalink / raw)
To: John Clark, Heiko Stuebner, Rob Herring, Krzysztof Kozlowski,
Peter Geis
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
On 13/04/2023 16:43, John Clark wrote:
> Add gpio-range properties to the pinctrl gpio nodes in rk356x.dtsi
>
> Signed-off-by: John Clark <inindev@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk356x.dtsi | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> index 802fcc96384e..793dbcb981dc 100644
> --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> @@ -1796,11 +1796,11 @@ usb2phy1_otg: otg-port {
>
> pinctrl: pinctrl {
> compatible = "rockchip,rk3568-pinctrl";
> + ranges;
> rockchip,grf = <&grf>;
> rockchip,pmu = <&pmugrf>;
> #address-cells = <2>;
> #size-cells = <2>;
> - ranges;
Not related to your patch.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* [v2] arm64: dts: rockchip: Add pinctrl gpio-ranges for rk356x
2023-04-13 14:43 [PATCH] arm64: dts: rockchip: Add pinctrl gpio-ranges for rk356x John Clark
2023-04-13 16:11 ` Krzysztof Kozlowski
@ 2023-04-13 17:03 ` John Clark
2023-04-17 9:35 ` Heiko Stuebner
1 sibling, 1 reply; 4+ messages in thread
From: John Clark @ 2023-04-13 17:03 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Peter Geis
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
John Clark
Add gpio-range properties to the pinctrl gpio nodes in rk356x.dtsi
Signed-off-by: John Clark <inindev@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk356x.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
index 802fcc96384e..f62e0fd881a9 100644
--- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
@@ -1808,6 +1808,7 @@ gpio0: gpio@fdd60000 {
interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&pmucru PCLK_GPIO0>, <&pmucru DBCLK_GPIO0>;
gpio-controller;
+ gpio-ranges = <&pinctrl 0 0 32>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -1819,6 +1820,7 @@ gpio1: gpio@fe740000 {
interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru PCLK_GPIO1>, <&cru DBCLK_GPIO1>;
gpio-controller;
+ gpio-ranges = <&pinctrl 0 32 32>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -1830,6 +1832,7 @@ gpio2: gpio@fe750000 {
interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru PCLK_GPIO2>, <&cru DBCLK_GPIO2>;
gpio-controller;
+ gpio-ranges = <&pinctrl 0 64 32>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -1841,6 +1844,7 @@ gpio3: gpio@fe760000 {
interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru PCLK_GPIO3>, <&cru DBCLK_GPIO3>;
gpio-controller;
+ gpio-ranges = <&pinctrl 0 96 32>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -1852,6 +1856,7 @@ gpio4: gpio@fe770000 {
interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru PCLK_GPIO4>, <&cru DBCLK_GPIO4>;
gpio-controller;
+ gpio-ranges = <&pinctrl 0 128 32>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [v2] arm64: dts: rockchip: Add pinctrl gpio-ranges for rk356x
2023-04-13 17:03 ` [v2] " John Clark
@ 2023-04-17 9:35 ` Heiko Stuebner
0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2023-04-17 9:35 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Peter Geis, John Clark
Cc: Heiko Stuebner, linux-rockchip, linux-arm-kernel, linux-kernel,
devicetree
On Thu, 13 Apr 2023 13:03:37 -0400, John Clark wrote:
> Add gpio-range properties to the pinctrl gpio nodes in rk356x.dtsi
>
>
Applied, thanks!
[1/1] arm64: dts: rockchip: Add pinctrl gpio-ranges for rk356x
commit: 6f5ab8fa33238fdf6cb28dac7bc2f650db2caf08
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-17 10:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-13 14:43 [PATCH] arm64: dts: rockchip: Add pinctrl gpio-ranges for rk356x John Clark
2023-04-13 16:11 ` Krzysztof Kozlowski
2023-04-13 17:03 ` [v2] " John Clark
2023-04-17 9:35 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).