From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A107C77B70 for ; Fri, 14 Apr 2023 06:28:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229476AbjDNG2n (ORCPT ); Fri, 14 Apr 2023 02:28:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbjDNG2m (ORCPT ); Fri, 14 Apr 2023 02:28:42 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD71972BE; Thu, 13 Apr 2023 23:28:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1681453701; x=1712989701; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=yUbogp083vNz/Diay1DDnDrLQxV7cDnHSWDCATBAGPg=; b=dXXQP7kBze9KZ7Eplp1CRjU1WhK65BAi2MVDWTkIe/CPcvGDFqkuCxcb XFk2JiE6ohC7WA1sqfdEFDc+gTxKRdoZ3SJAwM0rOPQFamqdaV5wj+cuF NdSeAxXS4oBoExyYRrX7Bil+OuHhG7wY6ni/QXGLK5wEGuuEMDLMqLfWY gxMQe3nsEhUYIe2/NAGVaMwLle25k6F4rC4MxNXGAJONIIm5RozWg7ZcO agW01WwuSoba/WNgZD+DsNoWn8ap++HMU4nMLYKngHIYjc+WP74Rh3d3L IKKg/CG1pXZoHq/eANRF31G0hBCWMw3AIX1ajwkHZlWRVrw2rrPH+qn0W w==; X-IronPort-AV: E=Sophos;i="5.99,195,1677567600"; d="asc'?scan'208";a="210414801" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Apr 2023 23:28:02 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 13 Apr 2023 23:28:02 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 13 Apr 2023 23:28:00 -0700 Date: Fri, 14 Apr 2023 07:27:44 +0100 From: Conor Dooley To: Krzysztof Kozlowski CC: Changhuang Liang , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , , , Subject: Re: [PATCH v1 1/7] dt-bindings: power: Constrain properties for JH7110 PMU Message-ID: <20230414-wildfowl-unbeaten-fbdf895d1b5c@wendy> References: <20230411064743.273388-1-changhuang.liang@starfivetech.com> <20230411064743.273388-2-changhuang.liang@starfivetech.com> <20230412-trifle-outplayed-8a1c795fab8b@wendy> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4uTpX9GTsiQTdpIq" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --4uTpX9GTsiQTdpIq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 12, 2023 at 01:29:57PM +0200, Krzysztof Kozlowski wrote: > On 12/04/2023 11:42, Conor Dooley wrote: > > On Wed, Apr 12, 2023 at 04:51:16PM +0800, Changhuang Liang wrote: > >> > >> > >> On 2023/4/12 16:35, Krzysztof Kozlowski wrote: > >>> On 11/04/2023 08:47, Changhuang Liang wrote: > >>>> When use "starfive,jh7110-pmu-dphy" compatible, do not need the reg = and > >>>> interrupts properties. > >> [...] > >>>> =20 > >>>> description: | > >>>> StarFive JH7110 SoC includes support for multiple power domains w= hich can be > >>>> @@ -17,6 +18,7 @@ properties: > >>>> compatible: > >>>> enum: > >>>> - starfive,jh7110-pmu > >>>> + - starfive,jh7110-pmu-dphy > >>> > >>> You do here much more than commit msg says. > >>> > >>> Isn'y DPHY a phy? Why is it in power? > >>> > >> > >> OK, I will add more description. This is a power framework used to tur= n on/off=20 > >> DPHY. So it in power, not a phy. > >=20 > > Perhaps tie it less to its role w/ the phy, and more to do with its > > location, say "jh7110-aon-pmu"? > > There's already "aon"/"sys"/"stg" stuff used in clock-controller and > > syscon compatibles etc. > >=20 > > Krzysztof, what do you think of that? (if you remember the whole > > discussion we previously had about using those identifiers a few weeks > > ago). >=20 > Depends whether this is the same case or not. > AFAIR, for AON/SYS/STG > these were blocks with few features, not only clock controller. Correct, yes. In the dts, this "pmu-dphy" node is a child node of the aon syscon, so this pmu stuff would be one of the several features. --4uTpX9GTsiQTdpIq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZDjyYAAKCRB4tDGHoIJi 0rayAQDQvEYTN5qEh/woJsy4Uu6mKHynU+GBtUcFZPreUm/W8wEAz0rvwm2qU8Q1 MVnWhTO6aCd4Z1GqB1375PAmNv2lIwQ= =Iewl -----END PGP SIGNATURE----- --4uTpX9GTsiQTdpIq--