From: Lee Jones <lee@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Pavel Machek <pavel@ucw.cz>,
sean.wang@mediatek.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH v2 7/7] leds: leds-mt6323: Add support for WLEDs and MT6332
Date: Fri, 14 Apr 2023 08:07:48 +0100 [thread overview]
Message-ID: <20230414070748.GB1036697@google.com> (raw)
In-Reply-To: <76c89ad1-a189-c907-590c-35ae6b7edd9e@collabora.com>
On Thu, 13 Apr 2023, AngeloGioacchino Del Regno wrote:
> Il 13/04/23 13:06, Pavel Machek ha scritto:
> > Hi!
> >
> > > Add basic code to turn on and off WLEDs and wire up MT6332 support
> > > to take advantage of it.
> > > This is a simple approach due to to the aforementioned PMIC supporting
> > > only on/off status so, at the time of writing, it is impossible for me
> > > to validate more advanced functionality due to lack of hardware.
> >
> >
> > > @@ -467,14 +590,24 @@ static int mt6323_led_probe(struct platform_device *pdev)
> > > goto put_child_node;
> > > }
> > > + is_wled = of_property_read_bool(child, "mediatek,is-wled");
> > > +
> >
> > This needs documenting in the binding, no?
>
> Yes, and I forgot to. Would it be okay if I send a supplementary patch out
> of this series to document that since the bindings are already acked?
You can add the support as part of a new patch.
Please resend this series with it attached.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-04-14 7:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 15:33 [PATCH v2 0/7] Add support for MT6331 and MT6332 LEDs AngeloGioacchino Del Regno
2023-04-12 15:33 ` [PATCH v2 1/7] dt-bindings: leds: leds-mt6323: Document mt6331 compatible AngeloGioacchino Del Regno
2023-04-13 8:35 ` Alexandre Mergnat
2023-04-12 15:33 ` [PATCH v2 2/7] dt-bindings: leds: leds-mt6323: Document mt6332 compatible AngeloGioacchino Del Regno
2023-04-13 8:35 ` Alexandre Mergnat
2023-04-13 10:47 ` Pavel Machek
2023-04-12 15:33 ` [PATCH v2 3/7] leds: leds-mt6323: Specify registers and specs in platform data AngeloGioacchino Del Regno
2023-04-13 10:11 ` Alexandre Mergnat
2023-04-13 10:57 ` Pavel Machek
2023-04-12 15:33 ` [PATCH v2 4/7] leds: leds-mt6323: Open code and drop MT6323_CAL_HW_DUTY macro AngeloGioacchino Del Regno
2023-04-13 13:06 ` Alexandre Mergnat
2023-04-12 15:33 ` [PATCH v2 5/7] leds: leds-mt6323: Drop MT6323_ prefix from macros and defines AngeloGioacchino Del Regno
2023-04-13 10:59 ` Pavel Machek
2023-04-13 13:41 ` Alexandre Mergnat
2023-04-12 15:33 ` [PATCH v2 6/7] leds: leds-mt6323: Add support for MT6331 leds AngeloGioacchino Del Regno
2023-04-13 11:01 ` Pavel Machek
2023-04-13 13:19 ` Alexandre Mergnat
2023-04-12 15:33 ` [PATCH v2 7/7] leds: leds-mt6323: Add support for WLEDs and MT6332 AngeloGioacchino Del Regno
2023-04-13 11:06 ` Pavel Machek
2023-04-13 11:29 ` AngeloGioacchino Del Regno
2023-04-13 11:32 ` AngeloGioacchino Del Regno
2023-04-14 7:07 ` Lee Jones [this message]
2023-04-14 7:09 ` AngeloGioacchino Del Regno
2023-04-13 14:15 ` Alexandre Mergnat
2023-04-14 10:19 ` AngeloGioacchino Del Regno
2023-04-13 10:49 ` [PATCH v2 0/7] Add support for MT6331 and MT6332 LEDs Pavel Machek
2023-04-13 11:31 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414070748.GB1036697@google.com \
--to=lee@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).