From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7D03C77B71 for ; Fri, 14 Apr 2023 15:46:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230020AbjDNPqQ (ORCPT ); Fri, 14 Apr 2023 11:46:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbjDNPqP (ORCPT ); Fri, 14 Apr 2023 11:46:15 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F5323C0B for ; Fri, 14 Apr 2023 08:45:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681487133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ntFhRK7YK6RZBFuf1XKMu9P/ROVc9nlQCbHsKHmy5Eo=; b=FvVgt89Fr1Z0JnMQzJgwEjc7T0XGwTiQWJENDd8nTTPYHqynn2e71JVVsyInTCip+JLS/L cTvfedaWR7F1NpNff+Flg9w327aT9IXi1BicjmxYneQY5iIjUz5jB8j7Yp000MXU9v1Snj sK37BQwj2HnhrKb7a3iwGiP1cOQyAS4= Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-302-CCkosTsVMnqwdzk6vXbM9A-1; Fri, 14 Apr 2023 11:45:32 -0400 X-MC-Unique: CCkosTsVMnqwdzk6vXbM9A-1 Received: by mail-oo1-f69.google.com with SMTP id o203-20020a4a2cd4000000b00542081e9c6fso2451280ooo.1 for ; Fri, 14 Apr 2023 08:45:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681487131; x=1684079131; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ntFhRK7YK6RZBFuf1XKMu9P/ROVc9nlQCbHsKHmy5Eo=; b=F/DGnrpz/y1Hn17RC19dqt9eP9P/OQB/2Js3gcaGDaB3AUoXCoycO2jmo7nuaEiMzF aXMPGg2hv35U3T0MbV+Ic+cSwnEbSNHkQbJVDPC8NXYEshpJSkXeOieOYHCgbm0l0lL/ OMaT5WRgYUgbZ+kTitXviY+oG7SRmyFIYn1aBUYWJimGyp7lx+jqtnTRtyEVgb1tuDiA v52mKCKnl0OkL2FIjt6bjggoWxE7PN95Evosr3RiiQYQtC64eGIB4UFdm4joOT1sHWqZ 8lVD2I6plbTlCaq2wd4rFP2YJfQyXIKrMIodMgT9j4gxufzLrDj0SilngYPlHTOfxrnf CiEQ== X-Gm-Message-State: AAQBX9doc4j6snJysLiLZCAK3KO6MVi65sy+Q8jlKm7skGZVVEIclvyT Stv/cAAfhbrW5TNtIeY1q1DFXtsJ9aY6hLGlnMM6j6VKFS1hcjpzevcJthDhNSPEdOiUskk2HqR iCT+Bq+wIxu9l8nqO425j3g== X-Received: by 2002:a05:6808:1416:b0:38c:4f8b:9b53 with SMTP id w22-20020a056808141600b0038c4f8b9b53mr723651oiv.44.1681487131314; Fri, 14 Apr 2023 08:45:31 -0700 (PDT) X-Google-Smtp-Source: AKy350aM1E0hQumIIqX/xpL8i7+Bxzwh+LCf5RpzG+zNMOHmuiyqHTvwGGH6vqXTSIWdmY4/KiCQLA== X-Received: by 2002:a05:6808:1416:b0:38c:4f8b:9b53 with SMTP id w22-20020a056808141600b0038c4f8b9b53mr723627oiv.44.1681487130936; Fri, 14 Apr 2023 08:45:30 -0700 (PDT) Received: from halaney-x13s (104-53-165-62.lightspeed.stlsmo.sbcglobal.net. [104.53.165.62]) by smtp.gmail.com with ESMTPSA id c15-20020a544e8f000000b0038bf8c6151fsm1796337oiy.6.2023.04.14.08.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Apr 2023 08:45:30 -0700 (PDT) Date: Fri, 14 Apr 2023 10:45:27 -0500 From: Andrew Halaney To: Krishna Kurapati Cc: Thinh Nguyen , Greg Kroah-Hartman , Philipp Zabel , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com, quic_wcheng@quicinc.com, quic_jackp@quicinc.com, quic_harshq@quicinc.com, quic_shazhuss@quicinc.com Subject: Re: [PATCH v6 6/8] arm64: dts: qcom: sc8280xp: Add multiport controller node for SC8280 Message-ID: <20230414154527.vsjtgtfsd5kc7vww@halaney-x13s> References: <20230405125759.4201-1-quic_kriskura@quicinc.com> <20230405125759.4201-7-quic_kriskura@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230405125759.4201-7-quic_kriskura@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Apr 05, 2023 at 06:27:57PM +0530, Krishna Kurapati wrote: > Add USB and DWC3 node for tertiary port of SC8280 along with multiport > IRQ's and phy's. This will be used as a base for SA8295P and SA8295-Ride > platforms. > > Signed-off-by: Krishna Kurapati > --- > Link to v5: https://lore.kernel.org/all/20230310163420.7582-7-quic_kriskura@quicinc.com/ > > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 58 ++++++++++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 42bfa9fa5b96..7b81f2b0449d 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -3108,6 +3108,64 @@ usb_1_role_switch: endpoint { > }; > }; > > + usb_2: usb@a4f8800 { > + compatible = "qcom,sc8280xp-dwc3", "qcom,dwc3"; > + reg = <0 0x0a4f8800 0 0x400>; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + clocks = <&gcc GCC_CFG_NOC_USB3_MP_AXI_CLK>, > + <&gcc GCC_USB30_MP_MASTER_CLK>, > + <&gcc GCC_AGGRE_USB3_MP_AXI_CLK>, > + <&gcc GCC_USB30_MP_SLEEP_CLK>, > + <&gcc GCC_USB30_MP_MOCK_UTMI_CLK>, > + <&gcc GCC_AGGRE_USB_NOC_AXI_CLK>, > + <&gcc GCC_AGGRE_USB_NOC_NORTH_AXI_CLK>, > + <&gcc GCC_AGGRE_USB_NOC_SOUTH_AXI_CLK>, > + <&gcc GCC_SYS_NOC_USB_AXI_CLK>; > + clock-names = "cfg_noc", "core", "iface", "sleep", "mock_utmi", > + "noc_aggr", "noc_aggr_north", "noc_aggr_south", "noc_sys"; > + > + assigned-clocks = <&gcc GCC_USB30_MP_MOCK_UTMI_CLK>, > + <&gcc GCC_USB30_MP_MASTER_CLK>; > + assigned-clock-rates = <19200000>, <200000000>; > + > + interrupts-extended = <&pdc 127 IRQ_TYPE_EDGE_RISING>, > + <&pdc 126 IRQ_TYPE_EDGE_RISING>, > + <&pdc 16 IRQ_TYPE_LEVEL_HIGH>; > + > + interrupt-names = "dp_hs_phy_irq", "dm_hs_phy_irq", > + "ss_phy_irq"; > + This is breaking the current schema (with the full series applied), I am not sure if a pwr_event IRQ exists or but it maybe necessary to modify qcom,dwc3.yaml in order to explain hardware if it doesn't exist: (dtschema) ahalaney@halaney-x13s ~/git/linux-next (git)-[718f2024524f] % make CHECK_DTBS=y DT_SCHEMA_FILES=/usb/qcom,dwc3.yaml qcom/sa8540p-ride.dtb :( LINT Documentation/devicetree/bindings CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTC_CHK arch/arm64/boot/dts/qcom/sa8540p-ride.dtb /home/ahalaney/git/linux-next/arch/arm64/boot/dts/qcom/sa8540p-ride.dtb: usb@a4f8800: interrupt-names:0: 'pwr_event' was expected From schema: /home/ahalaney/git/linux-next/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml /home/ahalaney/git/linux-next/arch/arm64/boot/dts/qcom/sa8540p-ride.dtb: usb@a4f8800: interrupt-names:1: 'dp_hs_phy_irq' was expected From schema: /home/ahalaney/git/linux-next/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml /home/ahalaney/git/linux-next/arch/arm64/boot/dts/qcom/sa8540p-ride.dtb: usb@a4f8800: interrupt-names:2: 'dm_hs_phy_irq' was expected From schema: /home/ahalaney/git/linux-next/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml /home/ahalaney/git/linux-next/arch/arm64/boot/dts/qcom/sa8540p-ride.dtb: usb@a4f8800: interrupt-names: ['dp_hs_phy_irq', 'dm_hs_phy_irq', 'ss_phy_irq'] is too short From schema: /home/ahalaney/git/linux-next/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml /home/ahalaney/git/linux-next/arch/arm64/boot/dts/qcom/sa8540p-ride.dtb: usb@a4f8800: interrupts-extended: [[99, 127, 1], [99, 126, 1], [99, 16, 4]] is too short From schema: /home/ahalaney/git/linux-next/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml make CHECK_DTBS=y DT_SCHEMA_FILES=/usb/qcom,dwc3.yaml qcom/sa8540p-ride.dtb 22.61s user 0.54s system 99% cpu 23.172 total (dtschema) ahalaney@halaney-x13s ~/git/linux-next (git)-[718f2024524f] % Thanks, Andrew