* [PATCH 0/2] arm64: dts: ti: k3-j7200-common-proc-board fixes @ 2023-04-14 18:14 Udit Kumar 2023-04-14 18:14 ` [PATCH 1/2] arm64: dts: ti: k3-j7200: Fix physical address of pin Udit Kumar 2023-04-14 18:14 ` [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Enable I2C Udit Kumar 0 siblings, 2 replies; 9+ messages in thread From: Udit Kumar @ 2023-04-14 18:14 UTC (permalink / raw) To: linux-arm-kernel, afd, bb, vaishnav.a, j-choudhary, devicetree, linux-kernel, nm, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, a-govindraju, kishon Cc: Udit Kumar This patch series fixes the pin mux configuration and enable wkup_i2c0 at board level. Udit Kumar (2): arm64: dts: ti: k3-j7200: Fix physical address of pin arm64: dts: ti: k3-j7200-common-proc-board: Enable I2C .../dts/ti/k3-j7200-common-proc-board.dts | 32 +++++++++++-------- 1 file changed, 18 insertions(+), 14 deletions(-) -- 2.34.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] arm64: dts: ti: k3-j7200: Fix physical address of pin 2023-04-14 18:14 [PATCH 0/2] arm64: dts: ti: k3-j7200-common-proc-board fixes Udit Kumar @ 2023-04-14 18:14 ` Udit Kumar 2023-04-14 18:26 ` Nishanth Menon 2023-04-14 18:14 ` [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Enable I2C Udit Kumar 1 sibling, 1 reply; 9+ messages in thread From: Udit Kumar @ 2023-04-14 18:14 UTC (permalink / raw) To: linux-arm-kernel, afd, bb, vaishnav.a, j-choudhary, devicetree, linux-kernel, nm, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, a-govindraju, kishon Cc: Udit Kumar, J Keerthi Fixes: 9ae21ac445e9 ("arm64: dts: ti: k3-j7200: Fix wakeup pinmux range") wkup_pmx splits into multiple regions. Like wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12) wkup_pmx1 -> 2 pins (WKUP_PADCONFIG 14 - 15) wkup_pmx2 -> 59 pins (WKUP_PADCONFIG 26 - 84) wkup_pmx3 -> 8 pins (WKUP_PADCONFIG 93 - 100) With this split, pin offset needs to be adjusted to match with new pmx for all pins above wkup_pmx0. Example a pin under wkup_pmx1 should start from 0 instead of old offset(0x38 WKUP_PADCONFIG 14 offset) J7200 Datasheet (Table 6-106, Section 6.4 Pin Multiplexing) : https://www.ti.com/lit/ds/symlink/dra821u.pdf Signed-off-by: J Keerthi <j-keerthy@ti.com> Signed-off-by: Udit Kumar <u-kumar1@ti.com> --- .../dts/ti/k3-j7200-common-proc-board.dts | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts index 0d39d6b8cc0c..63633e4f6c59 100644 --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts @@ -83,25 +83,25 @@ vdd_sd_dv: gpio-regulator-TLV71033 { &wkup_pmx2 { mcu_cpsw_pins_default: mcu-cpsw-pins-default { pinctrl-single,pins = < - J721E_WKUP_IOPAD(0x0068, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */ - J721E_WKUP_IOPAD(0x006c, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */ - J721E_WKUP_IOPAD(0x0070, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */ - J721E_WKUP_IOPAD(0x0074, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */ - J721E_WKUP_IOPAD(0x0078, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */ - J721E_WKUP_IOPAD(0x007c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */ - J721E_WKUP_IOPAD(0x0088, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */ - J721E_WKUP_IOPAD(0x008c, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */ - J721E_WKUP_IOPAD(0x0090, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */ - J721E_WKUP_IOPAD(0x0094, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */ - J721E_WKUP_IOPAD(0x0080, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */ - J721E_WKUP_IOPAD(0x0084, PIN_INPUT, 0) /* MCU_RGMII1_RXC */ + J721E_WKUP_IOPAD(0x0000, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */ + J721E_WKUP_IOPAD(0x0004, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */ + J721E_WKUP_IOPAD(0x0008, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */ + J721E_WKUP_IOPAD(0x000c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */ + J721E_WKUP_IOPAD(0x0010, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */ + J721E_WKUP_IOPAD(0x0014, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */ + J721E_WKUP_IOPAD(0x0020, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */ + J721E_WKUP_IOPAD(0x0024, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */ + J721E_WKUP_IOPAD(0x0028, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */ + J721E_WKUP_IOPAD(0x002c, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */ + J721E_WKUP_IOPAD(0x0018, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */ + J721E_WKUP_IOPAD(0x001c, PIN_INPUT, 0) /* MCU_RGMII1_RXC */ >; }; mcu_mdio_pins_default: mcu-mdio1-pins-default { pinctrl-single,pins = < - J721E_WKUP_IOPAD(0x009c, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */ - J721E_WKUP_IOPAD(0x0098, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */ + J721E_WKUP_IOPAD(0x0034, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */ + J721E_WKUP_IOPAD(0x0030, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */ >; }; }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ti: k3-j7200: Fix physical address of pin 2023-04-14 18:14 ` [PATCH 1/2] arm64: dts: ti: k3-j7200: Fix physical address of pin Udit Kumar @ 2023-04-14 18:26 ` Nishanth Menon 2023-04-15 4:10 ` Kumar, Udit 0 siblings, 1 reply; 9+ messages in thread From: Nishanth Menon @ 2023-04-14 18:26 UTC (permalink / raw) To: Udit Kumar Cc: linux-arm-kernel, afd, bb, vaishnav.a, j-choudhary, devicetree, linux-kernel, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, a-govindraju, kishon, J Keerthi On 23:44-20230414, Udit Kumar wrote: > Fixes: 9ae21ac445e9 ("arm64: dts: ti: k3-j7200: Fix wakeup pinmux range") In the wrong place. > > wkup_pmx splits into multiple regions. Like > > wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12) > wkup_pmx1 -> 2 pins (WKUP_PADCONFIG 14 - 15) > wkup_pmx2 -> 59 pins (WKUP_PADCONFIG 26 - 84) > wkup_pmx3 -> 8 pins (WKUP_PADCONFIG 93 - 100) > > With this split, pin offset needs to be adjusted to > match with new pmx for all pins above wkup_pmx0. > > Example a pin under wkup_pmx1 should start from 0 instead of > old offset(0x38 WKUP_PADCONFIG 14 offset) > > J7200 Datasheet (Table 6-106, Section 6.4 Pin Multiplexing) : > https://www.ti.com/lit/ds/symlink/dra821u.pdf Drop the preceding whitespace. > > Signed-off-by: J Keerthi <j-keerthy@ti.com> Spell check name please, I think he usually goes with: Signed-off-by: Keerthy <j-keerthy@ti.com> If this patch is from Keerthy, the patch should have a "From:" > Signed-off-by: Udit Kumar <u-kumar1@ti.com> > --- > .../dts/ti/k3-j7200-common-proc-board.dts | 28 +++++++++---------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > index 0d39d6b8cc0c..63633e4f6c59 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > @@ -83,25 +83,25 @@ vdd_sd_dv: gpio-regulator-TLV71033 { > &wkup_pmx2 { > mcu_cpsw_pins_default: mcu-cpsw-pins-default { > pinctrl-single,pins = < > - J721E_WKUP_IOPAD(0x0068, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */ > - J721E_WKUP_IOPAD(0x006c, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */ > - J721E_WKUP_IOPAD(0x0070, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */ > - J721E_WKUP_IOPAD(0x0074, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */ > - J721E_WKUP_IOPAD(0x0078, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */ > - J721E_WKUP_IOPAD(0x007c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */ > - J721E_WKUP_IOPAD(0x0088, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */ > - J721E_WKUP_IOPAD(0x008c, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */ > - J721E_WKUP_IOPAD(0x0090, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */ > - J721E_WKUP_IOPAD(0x0094, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */ > - J721E_WKUP_IOPAD(0x0080, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */ > - J721E_WKUP_IOPAD(0x0084, PIN_INPUT, 0) /* MCU_RGMII1_RXC */ > + J721E_WKUP_IOPAD(0x0000, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */ > + J721E_WKUP_IOPAD(0x0004, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */ > + J721E_WKUP_IOPAD(0x0008, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */ > + J721E_WKUP_IOPAD(0x000c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */ > + J721E_WKUP_IOPAD(0x0010, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */ > + J721E_WKUP_IOPAD(0x0014, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */ > + J721E_WKUP_IOPAD(0x0020, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */ > + J721E_WKUP_IOPAD(0x0024, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */ > + J721E_WKUP_IOPAD(0x0028, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */ > + J721E_WKUP_IOPAD(0x002c, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */ > + J721E_WKUP_IOPAD(0x0018, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */ > + J721E_WKUP_IOPAD(0x001c, PIN_INPUT, 0) /* MCU_RGMII1_RXC */ nice catch. > >; > }; > > mcu_mdio_pins_default: mcu-mdio1-pins-default { > pinctrl-single,pins = < > - J721E_WKUP_IOPAD(0x009c, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */ > - J721E_WKUP_IOPAD(0x0098, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */ > + J721E_WKUP_IOPAD(0x0034, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */ > + J721E_WKUP_IOPAD(0x0030, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */ > >; > }; > }; > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ti: k3-j7200: Fix physical address of pin 2023-04-14 18:26 ` Nishanth Menon @ 2023-04-15 4:10 ` Kumar, Udit 2023-04-15 12:47 ` Nishanth Menon 0 siblings, 1 reply; 9+ messages in thread From: Kumar, Udit @ 2023-04-15 4:10 UTC (permalink / raw) To: Nishanth Menon Cc: linux-arm-kernel, afd, bb, vaishnav.a, j-choudhary, devicetree, linux-kernel, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, J Keerthi Hi Nishanth On 4/14/2023 11:56 PM, Nishanth Menon wrote: > On 23:44-20230414, Udit Kumar wrote: >> Fixes: 9ae21ac445e9 ("arm64: dts: ti: k3-j7200: Fix wakeup pinmux range") > In the wrong place. will address in v2 >> wkup_pmx splits into multiple regions. Like >> >> wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12) >> wkup_pmx1 -> 2 pins (WKUP_PADCONFIG 14 - 15) >> wkup_pmx2 -> 59 pins (WKUP_PADCONFIG 26 - 84) >> wkup_pmx3 -> 8 pins (WKUP_PADCONFIG 93 - 100) >> >> With this split, pin offset needs to be adjusted to >> match with new pmx for all pins above wkup_pmx0. >> >> Example a pin under wkup_pmx1 should start from 0 instead of >> old offset(0x38 WKUP_PADCONFIG 14 offset) >> >> J7200 Datasheet (Table 6-106, Section 6.4 Pin Multiplexing) : >> https://www.ti.com/lit/ds/symlink/dra821u.pdf > Drop the preceding whitespace. ok >> Signed-off-by: J Keerthi <j-keerthy@ti.com> > Spell check name please, I think he usually goes with: > > Signed-off-by: Keerthy <j-keerthy@ti.com> > > If this patch is from Keerthy, the patch should have a "From:" ok. git apply on original patch didn't worked , so i applied and committed. will fix in patch itself before posting, Keerthi as author >> Signed-off-by: Udit Kumar <u-kumar1@ti.com> >> --- >> .../dts/ti/k3-j7200-common-proc-board.dts | 28 +++++++++---------- >> 1 file changed, 14 insertions(+), 14 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> index 0d39d6b8cc0c..63633e4f6c59 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> @@ -83,25 +83,25 @@ vdd_sd_dv: gpio-regulator-TLV71033 { >> &wkup_pmx2 { >> mcu_cpsw_pins_default: mcu-cpsw-pins-default { >> pinctrl-single,pins = < >> - J721E_WKUP_IOPAD(0x0068, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */ >> - J721E_WKUP_IOPAD(0x006c, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */ >> - J721E_WKUP_IOPAD(0x0070, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */ >> - J721E_WKUP_IOPAD(0x0074, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */ >> - J721E_WKUP_IOPAD(0x0078, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */ >> - J721E_WKUP_IOPAD(0x007c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */ >> - J721E_WKUP_IOPAD(0x0088, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */ >> - J721E_WKUP_IOPAD(0x008c, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */ >> - J721E_WKUP_IOPAD(0x0090, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */ >> - J721E_WKUP_IOPAD(0x0094, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */ >> - J721E_WKUP_IOPAD(0x0080, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */ >> - J721E_WKUP_IOPAD(0x0084, PIN_INPUT, 0) /* MCU_RGMII1_RXC */ >> + J721E_WKUP_IOPAD(0x0000, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */ >> + J721E_WKUP_IOPAD(0x0004, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */ >> + J721E_WKUP_IOPAD(0x0008, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */ >> + J721E_WKUP_IOPAD(0x000c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */ >> + J721E_WKUP_IOPAD(0x0010, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */ >> + J721E_WKUP_IOPAD(0x0014, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */ >> + J721E_WKUP_IOPAD(0x0020, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */ >> + J721E_WKUP_IOPAD(0x0024, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */ >> + J721E_WKUP_IOPAD(0x0028, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */ >> + J721E_WKUP_IOPAD(0x002c, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */ >> + J721E_WKUP_IOPAD(0x0018, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */ >> + J721E_WKUP_IOPAD(0x001c, PIN_INPUT, 0) /* MCU_RGMII1_RXC */ > nice catch. > >> >; >> }; >> >> mcu_mdio_pins_default: mcu-mdio1-pins-default { >> pinctrl-single,pins = < >> - J721E_WKUP_IOPAD(0x009c, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */ >> - J721E_WKUP_IOPAD(0x0098, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */ >> + J721E_WKUP_IOPAD(0x0034, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */ >> + J721E_WKUP_IOPAD(0x0030, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */ >> >; >> }; >> }; >> -- >> 2.34.1 >> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ti: k3-j7200: Fix physical address of pin 2023-04-15 4:10 ` Kumar, Udit @ 2023-04-15 12:47 ` Nishanth Menon 0 siblings, 0 replies; 9+ messages in thread From: Nishanth Menon @ 2023-04-15 12:47 UTC (permalink / raw) To: Kumar, Udit Cc: linux-arm-kernel, afd, bb, vaishnav.a, j-choudhary, devicetree, linux-kernel, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, J Keerthi On 09:40-20230415, Kumar, Udit wrote: [...] > git apply on original patch didn't worked , so i applied and committed. > > will fix in patch itself before posting, Keerthi as author Yes, with s/Keerthi/Keerthy please. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Enable I2C 2023-04-14 18:14 [PATCH 0/2] arm64: dts: ti: k3-j7200-common-proc-board fixes Udit Kumar 2023-04-14 18:14 ` [PATCH 1/2] arm64: dts: ti: k3-j7200: Fix physical address of pin Udit Kumar @ 2023-04-14 18:14 ` Udit Kumar 2023-04-14 18:24 ` Nishanth Menon 1 sibling, 1 reply; 9+ messages in thread From: Udit Kumar @ 2023-04-14 18:14 UTC (permalink / raw) To: linux-arm-kernel, afd, bb, vaishnav.a, j-choudhary, devicetree, linux-kernel, nm, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, a-govindraju, kishon Cc: Udit Kumar All I2C nodes were disabled in SOC dts file and in board dts needed nodes were enabled. This patch enables wkup_i2c0 node in board dts file. Fixes: a9ed915cd55c ("arm64: dts: ti: k3-j7200: Enable I2C nodes at the board level") Signed-off-by: Udit Kumar <u-kumar1@ti.com> --- arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts index 63633e4f6c59..e66bbfe65ff2 100644 --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts @@ -254,6 +254,10 @@ exp3: gpio@20 { }; }; +&wkup_i2c0 { + status = "okay"; +}; + &main_sdhci0 { /* eMMC */ non-removable; -- 2.34.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Enable I2C 2023-04-14 18:14 ` [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Enable I2C Udit Kumar @ 2023-04-14 18:24 ` Nishanth Menon 2023-04-15 4:06 ` Kumar, Udit 0 siblings, 1 reply; 9+ messages in thread From: Nishanth Menon @ 2023-04-14 18:24 UTC (permalink / raw) To: Udit Kumar Cc: linux-arm-kernel, afd, bb, vaishnav.a, j-choudhary, devicetree, linux-kernel, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, a-govindraju, kishon On 23:44-20230414, Udit Kumar wrote: > All I2C nodes were disabled in SOC dts file and in board > dts needed nodes were enabled. redundant. > This patch enables wkup_i2c0 node in board dts file. > > Fixes: a9ed915cd55c ("arm64: dts: ti: k3-j7200: Enable I2C nodes at the board level") This should'nt be fixing the commit - the commit is correct in the sense that if the board does'nt describe a node with pinmux, the i2c is'nt functional in the first place. > > Signed-off-by: Udit Kumar <u-kumar1@ti.com> > --- > arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > index 63633e4f6c59..e66bbfe65ff2 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > @@ -254,6 +254,10 @@ exp3: gpio@20 { > }; > }; > > +&wkup_i2c0 { > + status = "okay"; How about the pinmux? speed? what peripheral is on the wakeup i2c? Do we have an eeprom or something here? > +}; > + > &main_sdhci0 { > /* eMMC */ > non-removable; > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Enable I2C 2023-04-14 18:24 ` Nishanth Menon @ 2023-04-15 4:06 ` Kumar, Udit 2023-04-15 12:47 ` Nishanth Menon 0 siblings, 1 reply; 9+ messages in thread From: Kumar, Udit @ 2023-04-15 4:06 UTC (permalink / raw) To: Nishanth Menon Cc: linux-arm-kernel, afd, bb, vaishnav.a, j-choudhary, devicetree, linux-kernel, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt Hi Nishanth On 4/14/2023 11:54 PM, Nishanth Menon wrote: > On 23:44-20230414, Udit Kumar wrote: >> All I2C nodes were disabled in SOC dts file and in board >> dts needed nodes were enabled. > redundant. ok > >> This patch enables wkup_i2c0 node in board dts file. >> >> Fixes: a9ed915cd55c ("arm64: dts: ti: k3-j7200: Enable I2C nodes at the board level") > > This should'nt be fixing the commit - the commit is correct in the sense > that if the board does'nt describe a node with pinmux, the i2c is'nt > functional in the first place. well, how i look at before this patch each i2c was functional. this fix is making needed i2c as disabled, however this fix is correct I am ok to remove Fixes >> Signed-off-by: Udit Kumar <u-kumar1@ti.com> >> --- >> arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> index 63633e4f6c59..e66bbfe65ff2 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> @@ -254,6 +254,10 @@ exp3: gpio@20 { >> }; >> }; >> >> +&wkup_i2c0 { >> + status = "okay"; > How about the pinmux? speed? what peripheral is on the wakeup i2c? > > Do we have an eeprom or something here? This got eeprom and PMIC, eeprom read is ok with pin mux and speed. if you want to specify, let me know >> +}; >> + >> &main_sdhci0 { >> /* eMMC */ >> non-removable; >> -- >> 2.34.1 >> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Enable I2C 2023-04-15 4:06 ` Kumar, Udit @ 2023-04-15 12:47 ` Nishanth Menon 0 siblings, 0 replies; 9+ messages in thread From: Nishanth Menon @ 2023-04-15 12:47 UTC (permalink / raw) To: Kumar, Udit Cc: linux-arm-kernel, afd, bb, vaishnav.a, j-choudhary, devicetree, linux-kernel, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt On 09:36-20230415, Kumar, Udit wrote: [...] > > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > > > index 63633e4f6c59..e66bbfe65ff2 100644 > > > --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > > > +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > > > @@ -254,6 +254,10 @@ exp3: gpio@20 { > > > }; > > > }; > > > +&wkup_i2c0 { > > > + status = "okay"; > > How about the pinmux? speed? what peripheral is on the wakeup i2c? > > > > Do we have an eeprom or something here? > > > This got eeprom and PMIC, > > eeprom read is ok with pin mux and speed. > > if you want to specify, let me know yes, you must specify eeprom at least. I understand pmic is in discussion atm [1], So, that can be resolved seperately. Also if the eeprom is on the SoM, you should add this in the SoM dtsi, not the baseboard dtsi. [1] https://lore.kernel.org/all/714a56b1-438c-7aad-920b-f3f1d72afc5f@linaro.org/ -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-04-15 12:48 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-04-14 18:14 [PATCH 0/2] arm64: dts: ti: k3-j7200-common-proc-board fixes Udit Kumar 2023-04-14 18:14 ` [PATCH 1/2] arm64: dts: ti: k3-j7200: Fix physical address of pin Udit Kumar 2023-04-14 18:26 ` Nishanth Menon 2023-04-15 4:10 ` Kumar, Udit 2023-04-15 12:47 ` Nishanth Menon 2023-04-14 18:14 ` [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Enable I2C Udit Kumar 2023-04-14 18:24 ` Nishanth Menon 2023-04-15 4:06 ` Kumar, Udit 2023-04-15 12:47 ` Nishanth Menon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox