Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Enable I2C

Kumar, Udit
2023-04-15T04:06:36Z

Hi Nishanth

On 4/14/2023 11:54 PM, Nishanth Menon wrote:
> On 23:44-20230414, Udit Kumar wrote:
>> All I2C nodes were disabled in SOC dts file and in board
>> dts needed nodes were enabled.
> redundant.

ok

>
>> This patch enables wkup_i2c0 node in board dts file.
>>
>> Fixes: a9ed915cd55c ("arm64: dts: ti: k3-j7200: Enable I2C nodes at the board level")
>
> This should'nt be fixing the commit - the commit is correct in the sense
> that if the board does'nt describe a node with pinmux, the i2c is'nt
> functional in the first place.

well, how i look at before this patch each i2c was functional.

this fix is making needed i2c as disabled, however this fix is correct

I am ok to remove Fixes

>> Signed-off-by: Udit Kumar <u-kumar1@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> index 63633e4f6c59..e66bbfe65ff2 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> @@ -254,6 +254,10 @@ exp3: gpio@20 {
>> };
>> };
>>
>> +&wkup_i2c0 {
>> + status = "okay";
> How about the pinmux? speed? what peripheral is on the wakeup i2c?
>
> Do we have an eeprom or something here?

This got eeprom and PMIC,

eeprom read is ok with pin mux and speed.

if you want to specify, let me know

>> +};
>> +
>> &main_sdhci0 {
>> /* eMMC */
>> non-removable;
>> --
>> 2.34.1
>>