public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: "Kumar, Udit" <u-kumar1@ti.com>
Cc: <linux-arm-kernel@lists.infradead.org>, <afd@ti.com>, <bb@ti.com>,
	<vaishnav.a@ti.com>, <j-choudhary@ti.com>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Enable I2C
Date: Sat, 15 Apr 2023 07:47:09 -0500	[thread overview]
Message-ID: <20230415124709.fazcyqe5zfnbcrbc@jogging> (raw)
In-Reply-To: <b360dfd0-3dd3-996c-a9b6-1af770c4015b@ti.com>

On 09:36-20230415, Kumar, Udit wrote:
[...]

> > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> > > index 63633e4f6c59..e66bbfe65ff2 100644
> > > --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> > > +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> > > @@ -254,6 +254,10 @@ exp3: gpio@20 {
> > >   	};
> > >   };
> > > +&wkup_i2c0 {
> > > +	status = "okay";
> > How about the pinmux? speed? what peripheral is on the wakeup i2c?
> > 
> > 	Do we have an eeprom or something here?
> 
> 
> This got eeprom and PMIC,
> 
> eeprom read is ok with pin mux and speed.
> 
> if you want to specify, let me know

yes, you must specify eeprom at least. I understand pmic is in
discussion atm [1], So, that can be resolved seperately.

Also if the eeprom is on the SoM, you should add this in the SoM dtsi,
not the baseboard dtsi.

[1] https://lore.kernel.org/all/714a56b1-438c-7aad-920b-f3f1d72afc5f@linaro.org/
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

      reply	other threads:[~2023-04-15 12:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14 18:14 [PATCH 0/2] arm64: dts: ti: k3-j7200-common-proc-board fixes Udit Kumar
2023-04-14 18:14 ` [PATCH 1/2] arm64: dts: ti: k3-j7200: Fix physical address of pin Udit Kumar
2023-04-14 18:26   ` Nishanth Menon
2023-04-15  4:10     ` Kumar, Udit
2023-04-15 12:47       ` Nishanth Menon
2023-04-14 18:14 ` [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Enable I2C Udit Kumar
2023-04-14 18:24   ` Nishanth Menon
2023-04-15  4:06     ` Kumar, Udit
2023-04-15 12:47       ` Nishanth Menon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230415124709.fazcyqe5zfnbcrbc@jogging \
    --to=nm@ti.com \
    --cc=afd@ti.com \
    --cc=bb@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-choudhary@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=vaishnav.a@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox