From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E2EC77B75 for ; Tue, 18 Apr 2023 17:28:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232441AbjDRR2h (ORCPT ); Tue, 18 Apr 2023 13:28:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232605AbjDRR2V (ORCPT ); Tue, 18 Apr 2023 13:28:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27EF9E48; Tue, 18 Apr 2023 10:28:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A740F61202; Tue, 18 Apr 2023 17:28:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45827C433D2; Tue, 18 Apr 2023 17:28:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681838886; bh=QCLMTGp0pSAawzsOxfqUZWtyxa1SJnm6R5Qw5FlWiBk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uajfv6Bwv+DD9Vq+CBn1cSZzOAhNjxs/u0hDkHONopDzprf3D+R802y8LyxP7Axon qJHKI8fH26kJHfUplSOuPamB6lmAygGxhqpCxi2wBKQSmOnQB7v3uCAXossgh/KMPZ INkYU72upEymEGPZSfFJrjTiLGPdQdH18tsrCXbu6+JMLz7ePZYzj1ruFDnsquBDJy BzU8GbNffHY01LIbbPjRejT9+1bs2/yPPIK5lcv2xDNh/Asdq98ARGXs5mgcMHRzGZ PHyFfBxhZjyco+9k0ioy5ObdPJTrLC1xvHVGcHljsKBRVkhd1ZVdF8YB+JjXsm7JTp 5lyv7LgnxzNBw== Date: Tue, 18 Apr 2023 18:28:00 +0100 From: Conor Dooley To: Mason Huo Cc: "Rafael J. Wysocki" , Viresh Kumar , Emil Renner Berthing , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Shengyu Qu , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 3/3] riscv: dts: starfive: Add cpu scaling for JH7110 SoC Message-ID: <20230418-talcum-unthread-618a5bd2758a@spud> References: <20230417063942.3141-1-mason.huo@starfivetech.com> <20230417063942.3141-4-mason.huo@starfivetech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YJMzqe/hzL7IbIYs" Content-Disposition: inline In-Reply-To: <20230417063942.3141-4-mason.huo@starfivetech.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --YJMzqe/hzL7IbIYs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey Mason, Just one minor comment in passing.. On Mon, Apr 17, 2023 at 02:39:42PM +0800, Mason Huo wrote: > Add the operating-points-v2 to support cpu scaling on StarFive JH7110 SoC. > It supports up to 4 cpu frequency loads. >=20 > Signed-off-by: Mason Huo > --- > .../jh7110-starfive-visionfive-2.dtsi | 17 ++++++++++ > arch/riscv/boot/dts/starfive/jh7110.dtsi | 33 +++++++++++++++++++ > 2 files changed, 50 insertions(+) >=20 > diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dt= si b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > index cca1c8040801..b25e6d68ce53 100644 > --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > @@ -227,3 +227,20 @@ &uart0 { > pinctrl-0 =3D <&uart0_pins>; > status =3D "okay"; > }; > + > +&U74_1 { > + cpu-supply =3D <&vdd_cpu>; > +}; > + > +&U74_2 { > + cpu-supply =3D <&vdd_cpu>; > +}; > + > +&U74_3 { > + cpu-supply =3D <&vdd_cpu>; > +}; > + > +&U74_4 { > + cpu-supply =3D <&vdd_cpu>; > +}; > + Applying: riscv: dts: starfive: Add cpu scaling for JH7110 SoC /stuff/linux/.git/rebase-apply/patch:30: new blank line at EOF. + warning: 1 line adds whitespace errors. Cheers, Conor. --YJMzqe/hzL7IbIYs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZD7TDAAKCRB4tDGHoIJi 0nCIAQCGgCe1FJP8wpMrSgS8zFRx/3XZ/tG/QuMA8ezQyFQiwQD9E+NV9PcHcbsD Ws7d9iEVlnQj6SVvRbx4tpMKsAV1ew0= =1AIw -----END PGP SIGNATURE----- --YJMzqe/hzL7IbIYs--