From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D88DEC6FD18 for ; Tue, 18 Apr 2023 18:42:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231296AbjDRSmu (ORCPT ); Tue, 18 Apr 2023 14:42:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230502AbjDRSms (ORCPT ); Tue, 18 Apr 2023 14:42:48 -0400 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CBB693D7; Tue, 18 Apr 2023 11:42:48 -0700 (PDT) Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-6a5da18f7f5so501679a34.1; Tue, 18 Apr 2023 11:42:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681843367; x=1684435367; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eX9q8gX+UiR7CnmbV0JhOILFmnfK5QRyHCsxTtqP7h8=; b=VoVJcBwAdrh4JPJBimftOmym+mEnRCVosHaVtm8Q1utNpkb4nU5xK3ktgJNAwnDNqp 6/IueRXmbWyHc1KLWcZUeOUn+8ILnKGDt9l2YNsQUh/hKmZwPEb/pC2NfDM7OAjY7mqk fWF0OlEkID7Bq1VWAtMoBe14yvYLk7ccqtkee2EepBMom9glJDO9426mKqZ/nnJWXRXm skOWyW4fOYZQ06dPYxvWyr//0VVALY0bl8WXIiNoBA4HoBBGVtnafpkSw8KI0w3Nc2+v n/p79wGtP0bZNQUDS8N5mUspb5hrfkPeFE0wfa4JS4tCZNGhx11Q+zTwtSSW5J3k/CV4 9JEA== X-Gm-Message-State: AAQBX9fdb+IH40U8UR+ZlaGRxPvO7Z5B3+a38R0de2eS/utPQGm03zj4 cz78Uy+acNyJh0AsjjScxw== X-Google-Smtp-Source: AKy350YkFGdSrcH78VWgdiZeex/IhpEM1/tIWlB0tUde/R1j0VFPBv9n0B3D5YWlYqCkIfq6XkKf9A== X-Received: by 2002:a9d:7454:0:b0:6a3:2513:c452 with SMTP id p20-20020a9d7454000000b006a32513c452mr1455755otk.23.1681843367361; Tue, 18 Apr 2023 11:42:47 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c7-20020a9d6847000000b0069f0794861asm5786365oto.63.2023.04.18.11.42.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 11:42:46 -0700 (PDT) Received: (nullmailer pid 2105101 invoked by uid 1000); Tue, 18 Apr 2023 18:42:46 -0000 Date: Tue, 18 Apr 2023 13:42:46 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: Changhuang Liang , Vinod Koul , Kishon Vijay Abraham I , Krzysztof Kozlowski , Emil Renner Berthing , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Jack Zhu , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx Message-ID: <20230418184246.GA2103246-robh@kernel.org> References: <20230412084540.295411-1-changhuang.liang@starfivetech.com> <20230412084540.295411-2-changhuang.liang@starfivetech.com> <8dd0dc63-e0df-8764-f756-da032d9d671c@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Apr 13, 2023 at 10:41:23AM +0200, Krzysztof Kozlowski wrote: > On 13/04/2023 04:34, Changhuang Liang wrote: > >>>>> + lane_maps: > >>>> > >>>> Why did this appear? Underscores are not allowed. It looks like you > >>>> re-implement some standard property. > >>>> > >>> > >>> Will change to lane-maps. > >>> Yes, according to Vinod advice, lane mapping table use device tree > >>> to parse makes sense. > >> > >> Hm, I have a feeling that I saw such property, so you should dig into > >> existing and in-flight bindings. > >> > >> Best regards, > >> Krzysztof > >> > > > > A standard property? Like "clocks" or "resets"? > > Like lane-polarities now submitted to one MIPI. > data-lanes perhaps? Rob