Re: [PATCH V2 2/5] arm64: dts: ti: k3-am65*: Drop bootargs

Jan Kiszka
2023-04-19T14:47:23Z

On 19.04.23 16:12, Nishanth Menon wrote:
> Drop bootargs from the dts. earlycon is a debug property that should be
> enabled only when debug is desired and not as default - see referenced
> link on discussion on this topic.
>
> Cc: Jan Kiszka <jan.kiszka@siemens.com>
> Link: https://lore.kernel.org/linux-arm-kernel/81134eb9-2b7d-05bc-3035-a47f020861a8@linaro.org/
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Similar discussions can be seen in https://lore.kernel.org/linux-devicetree/?q=Krzysztof+bootargs
>
> Changes since v1:
> - improved commit message
> - picked up acks and reviews from Roger and Krzysztof
>
> V1: https://lore.kernel.org/r/20230418165212.1456415-3-nm@ti.com
>
> arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 1 -
> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index 96ac2b476b11..7d256a1638ff 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -21,7 +21,6 @@ aliases {
>
> chosen {
> stdout-path = "serial3:115200n8";
> - bootargs = "earlycon=ns16550a,mmio32,0x02810000";
> };
>
> reserved-memory {
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index 592ab2b54cb3..0d6fc89eba7a 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -15,7 +15,6 @@ / {
>
> chosen {
> stdout-path = "serial2:115200n8";
> - bootargs = "earlycon=ns16550a,mmio32,0x02800000";
> };
>
> memory@80000000 {

For the IOT2050:

Acked-by: Jan Kiszka <jan.kiszka@siemens.com>

Jan

--
Siemens AG, Technology
Competence Center Embedded Linux