From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 388D6C6FD18 for ; Wed, 19 Apr 2023 16:04:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232698AbjDSQEO (ORCPT ); Wed, 19 Apr 2023 12:04:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231779AbjDSQEN (ORCPT ); Wed, 19 Apr 2023 12:04:13 -0400 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1606273B; Wed, 19 Apr 2023 09:04:09 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id CAFDD5FD27; Wed, 19 Apr 2023 19:04:06 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1681920246; bh=gczPHOPFC5Oa1n8xm+YVvEBQVDVJ/qk+fMtEFwJEsz0=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=Rntcl+dI83kBRnQMotz3w+kPs6cXaxOeaHoNULYPvfFluGi/jgz/hol9F2mzMbhJ5 Ia7QNayXMPQOyp136/IAb9vB/tkh6IiNj04EtRg14/gGRSm2Duol+VJKmwqo6D9FoJ Yy+TEKkDv1596uDkkHPs0R+N9QkWyWj7al3qZ89Az3eWyA941MTXJnIBiexBbgjpbz fkNCbSuIWLohl46J6iSTGl8/y8NDD+iy3VbsYxy+IfA+nmiRAdhKewSJd0L548KQ5Q 6591RQ3MnJ14GH9UdtmFRKm2jOAubITdS+NrsblJzIK/S72qlvcMoLzLjK8S6WqJ2E qUf+Pwk5cJAxg== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Wed, 19 Apr 2023 19:04:05 +0300 (MSK) Date: Wed, 19 Apr 2023 19:04:05 +0300 From: Dmitry Rokosov To: Neil Armstrong CC: =Xianwei Zhao , , , , , Catalin Marinas , Will Deacon , Kevin Hilman , Rob Herring , Krzysztof Kozlowski Subject: Re: [RFC PATCH 1/2] arm64: amlogic: add new ARCH_AMLIPC for IPC SoC Message-ID: <20230419160405.d7qfir3nv6tlxx2a@CAB-WSD-L081021> References: <20230419073834.972273-1-xianwei.zhao@amlogic.com> <20230419073834.972273-2-xianwei.zhao@amlogic.com> <20230419131416.cns3xvkbzjeyrnux@CAB-WSD-L081021> <661cea17-a4dd-75d1-6a7e-16efa5aea52b@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <661cea17-a4dd-75d1-6a7e-16efa5aea52b@linaro.org> User-Agent: NeoMutt/20220415 X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH01.sberdevices.ru (172.16.1.4) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/04/19 10:42:00 #21127526 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Apr 19, 2023 at 03:43:12PM +0200, Neil Armstrong wrote: > On 19/04/2023 15:14, Dmitry Rokosov wrote: > > On Wed, Apr 19, 2023 at 03:38:33PM +0800, =Xianwei Zhao wrote: > > > From: Xianwei Zhao > > > > > > The C series SoCs are designed for smart IP camera > > > applications, which does not belong to Meson series. > > > So, Add ARCH_AMLIPC for the new series. > > > > > > There are now multiple amlogic SoC seies supported, so group them under > > > their own menu. we can easily add new platforms there in the future. > > > Introduce ARCH_AMLOGIC to cover all Amlogic SoC series. > > > > > > No functional changes introduced. > > > > > > Signed-off-by: Xianwei Zhao > > > --- > > > arch/arm64/Kconfig.platforms | 12 ++++++++++++ > > > arch/arm64/configs/defconfig | 2 ++ > > > 2 files changed, 14 insertions(+) > > > > > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > > > index 89a0b13b058d..bfbc817eef8f 100644 > > > --- a/arch/arm64/Kconfig.platforms > > > +++ b/arch/arm64/Kconfig.platforms > > > @@ -162,12 +162,24 @@ config ARCH_MEDIATEK > > > This enables support for MediaTek MT27xx, MT65xx, MT76xx > > > & MT81xx ARMv8 SoCs > > > +menuconfig ARCH_AMLOGIC > > > + bool "NXP SoC support" > > > > NXP? Did you mean "Amlogic"? > > > > > + > > > +if ARCH_AMLOGIC > > > + > > > config ARCH_MESON > > > bool "Amlogic Platforms" > > > help > > > This enables support for the arm64 based Amlogic SoCs > > > such as the s905, S905X/D, S912, A113X/D or S905X/D2 > > > +config ARCH_AMLIPC > > > > Do we really need a different ARCH for Amlogic IPC? > > I can imagine that it's not the Meson architecture at all. > > But maybe a better solution is just to rename ARCH_MESON to ARCH_AMLOGIC? > > It should be changed treewide, and is it worth it ? As far as I understand, the A1 and S4 families are not fully compatible with the Meson architecture, and we haven't provided additional ARCH_* for them. In my opinion, it's a good time to split the Meson architecture into proper subsets, or rename it treewide (maybe only config option ARCH_MESON => ARCH_AMLOGIC). > > > > > + bool "Amlogic IPC Platforms" > > > + help > > > + This enables support for the arm64 based Amlogic IPC SoCs > > > + such as the C302X, C308L > > > +endif > > > + > > > config ARCH_MVEBU > > > bool "Marvell EBU SoC Family" > > > select ARMADA_AP806_SYSCON > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > > index 7790ee42c68a..f231bd1723fd 100644 > > > --- a/arch/arm64/configs/defconfig > > > +++ b/arch/arm64/configs/defconfig > > > @@ -46,7 +46,9 @@ CONFIG_ARCH_LG1K=y > > > CONFIG_ARCH_HISI=y > > > CONFIG_ARCH_KEEMBAY=y > > > CONFIG_ARCH_MEDIATEK=y > > > +CONFIG_ARCH_AMLOGIC=y > > > CONFIG_ARCH_MESON=y > > > +CONFIG_ARCH_AMLIPC=y > > > CONFIG_ARCH_MVEBU=y > > > CONFIG_ARCH_NXP=y > > > CONFIG_ARCH_LAYERSCAPE=y > > > -- > > > 2.37.1 > > > > > > > > > _______________________________________________ > > > linux-amlogic mailing list > > > linux-amlogic@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-amlogic > > > -- Thank you, Dmitry