* [PATCH] ARM: dts: qcom: ipq4019: fix broken NAND controller properties override
@ 2023-04-20 7:28 Krzysztof Kozlowski
2023-04-20 8:33 ` Manivannan Sadhasivam
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-20 7:28 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Manivannan Sadhasivam, linux-arm-msm,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski, stable
After renaming NAND controller node name from "qpic-nand" to
"nand-controller", the board DTS/DTSI also have to be updated:
Warning (unit_address_vs_reg): /soc/qpic-nand@79b0000: node has a unit name, but no reg or ranges property
Cc: <stable@vger.kernel.org>
Fixes: 9e1e00f18afc ("ARM: dts: qcom: Fix node name for NAND controller node")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts | 8 ++++----
arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi | 10 +++++-----
arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi | 12 ++++++------
3 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts
index 79b0c6318e52..0993f840d1fc 100644
--- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts
+++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts
@@ -11,9 +11,9 @@ soc {
dma-controller@7984000 {
status = "okay";
};
-
- qpic-nand@79b0000 {
- status = "okay";
- };
};
};
+
+&nand {
+ status = "okay";
+};
diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi
index a63b3778636d..468ebc40d2ad 100644
--- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi
@@ -102,10 +102,10 @@ pci@40000000 {
status = "okay";
perst-gpios = <&tlmm 38 GPIO_ACTIVE_LOW>;
};
-
- qpic-nand@79b0000 {
- pinctrl-0 = <&nand_pins>;
- pinctrl-names = "default";
- };
};
};
+
+&nand {
+ pinctrl-0 = <&nand_pins>;
+ pinctrl-names = "default";
+};
diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi b/arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi
index 0107f552f520..7ef635997efa 100644
--- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi
@@ -65,11 +65,11 @@ i2c@78b7000 { /* BLSP1 QUP2 */
dma-controller@7984000 {
status = "okay";
};
-
- qpic-nand@79b0000 {
- pinctrl-0 = <&nand_pins>;
- pinctrl-names = "default";
- status = "okay";
- };
};
};
+
+&nand {
+ pinctrl-0 = <&nand_pins>;
+ pinctrl-names = "default";
+ status = "okay";
+};
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: qcom: ipq4019: fix broken NAND controller properties override
2023-04-20 7:28 [PATCH] ARM: dts: qcom: ipq4019: fix broken NAND controller properties override Krzysztof Kozlowski
@ 2023-04-20 8:33 ` Manivannan Sadhasivam
2023-04-20 10:42 ` Konrad Dybcio
2023-05-25 4:54 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2023-04-20 8:33 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel,
stable
On Thu, Apr 20, 2023 at 09:28:11AM +0200, Krzysztof Kozlowski wrote:
> After renaming NAND controller node name from "qpic-nand" to
> "nand-controller", the board DTS/DTSI also have to be updated:
>
> Warning (unit_address_vs_reg): /soc/qpic-nand@79b0000: node has a unit name, but no reg or ranges property
>
> Cc: <stable@vger.kernel.org>
> Fixes: 9e1e00f18afc ("ARM: dts: qcom: Fix node name for NAND controller node")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
- Mani
> ---
> arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts | 8 ++++----
> arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi | 10 +++++-----
> arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi | 12 ++++++------
> 3 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts
> index 79b0c6318e52..0993f840d1fc 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts
> +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts
> @@ -11,9 +11,9 @@ soc {
> dma-controller@7984000 {
> status = "okay";
> };
> -
> - qpic-nand@79b0000 {
> - status = "okay";
> - };
> };
> };
> +
> +&nand {
> + status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi
> index a63b3778636d..468ebc40d2ad 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi
> @@ -102,10 +102,10 @@ pci@40000000 {
> status = "okay";
> perst-gpios = <&tlmm 38 GPIO_ACTIVE_LOW>;
> };
> -
> - qpic-nand@79b0000 {
> - pinctrl-0 = <&nand_pins>;
> - pinctrl-names = "default";
> - };
> };
> };
> +
> +&nand {
> + pinctrl-0 = <&nand_pins>;
> + pinctrl-names = "default";
> +};
> diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi b/arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi
> index 0107f552f520..7ef635997efa 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi
> @@ -65,11 +65,11 @@ i2c@78b7000 { /* BLSP1 QUP2 */
> dma-controller@7984000 {
> status = "okay";
> };
> -
> - qpic-nand@79b0000 {
> - pinctrl-0 = <&nand_pins>;
> - pinctrl-names = "default";
> - status = "okay";
> - };
> };
> };
> +
> +&nand {
> + pinctrl-0 = <&nand_pins>;
> + pinctrl-names = "default";
> + status = "okay";
> +};
> --
> 2.34.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: qcom: ipq4019: fix broken NAND controller properties override
2023-04-20 7:28 [PATCH] ARM: dts: qcom: ipq4019: fix broken NAND controller properties override Krzysztof Kozlowski
2023-04-20 8:33 ` Manivannan Sadhasivam
@ 2023-04-20 10:42 ` Konrad Dybcio
2023-04-20 12:49 ` Krzysztof Kozlowski
2023-05-25 4:54 ` Bjorn Andersson
2 siblings, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2023-04-20 10:42 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Manivannan Sadhasivam, linux-arm-msm,
devicetree, linux-kernel
Cc: stable
On 20.04.2023 09:28, Krzysztof Kozlowski wrote:
> After renaming NAND controller node name from "qpic-nand" to
> "nand-controller", the board DTS/DTSI also have to be updated:
>
> Warning (unit_address_vs_reg): /soc/qpic-nand@79b0000: node has a unit name, but no reg or ranges property
>
> Cc: <stable@vger.kernel.org>
Cc: <stable@vger.kernel.org> # 5.12
(g show 9e1e00f18afc:Makefile | head, rounded up to first release)
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> Fixes: 9e1e00f18afc ("ARM: dts: qcom: Fix node name for NAND controller node")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts | 8 ++++----
> arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi | 10 +++++-----
> arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi | 12 ++++++------
> 3 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts
> index 79b0c6318e52..0993f840d1fc 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts
> +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts
> @@ -11,9 +11,9 @@ soc {
> dma-controller@7984000 {
> status = "okay";
> };
> -
> - qpic-nand@79b0000 {
> - status = "okay";
> - };
> };
> };
> +
> +&nand {
> + status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi
> index a63b3778636d..468ebc40d2ad 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi
> @@ -102,10 +102,10 @@ pci@40000000 {
> status = "okay";
> perst-gpios = <&tlmm 38 GPIO_ACTIVE_LOW>;
> };
> -
> - qpic-nand@79b0000 {
> - pinctrl-0 = <&nand_pins>;
> - pinctrl-names = "default";
> - };
> };
> };
> +
> +&nand {
> + pinctrl-0 = <&nand_pins>;
> + pinctrl-names = "default";
> +};
> diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi b/arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi
> index 0107f552f520..7ef635997efa 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi
> @@ -65,11 +65,11 @@ i2c@78b7000 { /* BLSP1 QUP2 */
> dma-controller@7984000 {
> status = "okay";
> };
> -
> - qpic-nand@79b0000 {
> - pinctrl-0 = <&nand_pins>;
> - pinctrl-names = "default";
> - status = "okay";
> - };
> };
> };
> +
> +&nand {
> + pinctrl-0 = <&nand_pins>;
> + pinctrl-names = "default";
> + status = "okay";
> +};
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: qcom: ipq4019: fix broken NAND controller properties override
2023-04-20 10:42 ` Konrad Dybcio
@ 2023-04-20 12:49 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-20 12:49 UTC (permalink / raw)
To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Manivannan Sadhasivam, linux-arm-msm,
devicetree, linux-kernel
Cc: stable
On 20/04/2023 12:42, Konrad Dybcio wrote:
>
>
> On 20.04.2023 09:28, Krzysztof Kozlowski wrote:
>> After renaming NAND controller node name from "qpic-nand" to
>> "nand-controller", the board DTS/DTSI also have to be updated:
>>
>> Warning (unit_address_vs_reg): /soc/qpic-nand@79b0000: node has a unit name, but no reg or ranges property
>>
>> Cc: <stable@vger.kernel.org>
> Cc: <stable@vger.kernel.org> # 5.12
>
> (g show 9e1e00f18afc:Makefile | head, rounded up to first release)
You do not have to do this. The Fixes tag defines backporting.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: qcom: ipq4019: fix broken NAND controller properties override
2023-04-20 7:28 [PATCH] ARM: dts: qcom: ipq4019: fix broken NAND controller properties override Krzysztof Kozlowski
2023-04-20 8:33 ` Manivannan Sadhasivam
2023-04-20 10:42 ` Konrad Dybcio
@ 2023-05-25 4:54 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2023-05-25 4:54 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-kernel, linux-arm-msm, Konrad Dybcio,
devicetree, Krzysztof Kozlowski, Andy Gross, Rob Herring,
Manivannan Sadhasivam
Cc: stable
On Thu, 20 Apr 2023 09:28:11 +0200, Krzysztof Kozlowski wrote:
> After renaming NAND controller node name from "qpic-nand" to
> "nand-controller", the board DTS/DTSI also have to be updated:
>
> Warning (unit_address_vs_reg): /soc/qpic-nand@79b0000: node has a unit name, but no reg or ranges property
>
>
Applied, thanks!
[1/1] ARM: dts: qcom: ipq4019: fix broken NAND controller properties override
commit: fd1db0249b0971642770aa4c987771b7c592557f
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-25 4:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-20 7:28 [PATCH] ARM: dts: qcom: ipq4019: fix broken NAND controller properties override Krzysztof Kozlowski
2023-04-20 8:33 ` Manivannan Sadhasivam
2023-04-20 10:42 ` Konrad Dybcio
2023-04-20 12:49 ` Krzysztof Kozlowski
2023-05-25 4:54 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).