From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 306D9C77B76 for ; Thu, 20 Apr 2023 10:38:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234929AbjDTKiN (ORCPT ); Thu, 20 Apr 2023 06:38:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234013AbjDTKhu (ORCPT ); Thu, 20 Apr 2023 06:37:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8895A270; Thu, 20 Apr 2023 03:34:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0988664731; Thu, 20 Apr 2023 10:34:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F440C433D2; Thu, 20 Apr 2023 10:34:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681986886; bh=qGAo9yWgX0XsLCgp4qDle4QFIJ3xXa3sA1HV+uXvSgM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oKDgTY7hDLzJH7hYrGx3aZ5ZL0FzhjBb6DErFXLnMtBaz9pVV5N/pTdPyeEY5DWp9 xjUuFBrbSYhu6q2jhQ5RRqAGAFuK4Tr6KrSpKCLU9QBhibpTlKvKqbSkY+UcVtqLnC N2KdzfN0UdCKBDCJd+qbX7GlbKWvxRIqmNUnvi6V/f0w0UmhfqydmxqQSvk72JQ7Ro as4zU4W3aWUYvG7cmCjDos00OleQznoxKE0BKNHstAXrdgNRHb8spAipekUielzTGP ki/sWHLlX62wh5wyKHiB2V+C2gNIAUB+yzAUFWq2xr8XeW7JJoC0MfRGwj58M9e+aC 4o6YIU6dgG+Ng== Date: Thu, 20 Apr 2023 11:34:38 +0100 From: Lee Jones To: Okan Sahin Cc: Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Cosmin Tanislav , Stephen Boyd , Ulf Hansson , Caleb Connolly , Marcus Folkesson , Ramona Bolboaca , ChiYuan Huang , Ibrahim Tilki , William Breathitt Gray , Arnd Bergmann , Hugo Villeneuve , ChiaEn Wu , Haibo Chen , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH v7 5/5] mfd: max77541: Add ADI MAX77541/MAX77540 PMIC Support Message-ID: <20230420103438.GI9904@google.com> References: <20230412111256.40013-1-okan.sahin@analog.com> <20230412111256.40013-6-okan.sahin@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230412111256.40013-6-okan.sahin@analog.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 12 Apr 2023, Okan Sahin wrote: > MFD driver for MAX77541/MAX77540 to enable its sub > devices. > > The MAX77541 is a multi-function devices. It includes > buck converter and ADC. > > The MAX77540 is a high-efficiency buck converter > with two 3A switching phases. > > They have same regmap except for ADC part of MAX77541. > > Signed-off-by: Okan Sahin > --- > drivers/mfd/Kconfig | 13 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/max77541.c | 224 +++++++++++++++++++++++++++++++++++ > include/linux/mfd/max77541.h | 91 ++++++++++++++ > 4 files changed, 329 insertions(+) > create mode 100644 drivers/mfd/max77541.c > create mode 100644 include/linux/mfd/max77541.h Looks good. Once the regulator driver has been reviewed, I can take the set. Please apply this if you have to resubmit: For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯]