From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17A9CC77B73 for ; Thu, 20 Apr 2023 13:16:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbjDTNQA (ORCPT ); Thu, 20 Apr 2023 09:16:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229709AbjDTNP5 (ORCPT ); Thu, 20 Apr 2023 09:15:57 -0400 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16B46187; Thu, 20 Apr 2023 06:15:54 -0700 (PDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 74178E0010; Thu, 20 Apr 2023 13:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681996553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mf7ZEqMnInD6phgYGwpuLntMIV868d1BcFV7kNAFuVc=; b=A8w0OSj2lidc4EuDhnUnEMUC/NHZfLwRyj7eA83lolXTf53qJbKyic8Yv3rhKMDygbl4WF p2NJfK5N8QMejhgYTeOaP9QkzIpKaE5e6wtIXh1IzSYpnzgc4BtYax6no3RFnFSwbE4vus cJ+fsUcBVh5iUVLa2LUm1700tpoQG/jVKLuoBOIJYCT/GCSE+KM3HDFpdrMq9OAVAb6CnQ wcvK+YSh0O2bNi3fdKIWQIEFg1svQ/TlXw8nas68tktzXO1FYFqyXPjKEab0QM3SZTpSYq N+COI7tYKW1xpDCbCMnQCFr8Q75SwTIfIT/vRGSaoSbenxXe87w98XQGwrQ0Ww== Date: Thu, 20 Apr 2023 15:15:51 +0200 From: Herve Codina To: Lee Jones Cc: Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Christophe Leroy , Thomas Petazzoni Subject: Re: [PATCH v6 3/7] mfd: Add support for the Lantiq PEF2256 framer Message-ID: <20230420151551.78c1288b@bootlin.com> In-Reply-To: <20230420123946.GB996918@google.com> References: <20230417171601.74656-1-herve.codina@bootlin.com> <20230417171601.74656-4-herve.codina@bootlin.com> <20230420123946.GB996918@google.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 20 Apr 2023 13:39:46 +0100 Lee Jones wrote: > On Mon, 17 Apr 2023, Herve Codina wrote: > > > The Lantiq PEF2256 is a framer and line interface component designed to > > fulfill all required interfacing between an analog E1/T1/J1 line and the > > digital PCM system highway/H.100 bus. > > > > Signed-off-by: Herve Codina > > --- > > drivers/mfd/Kconfig | 16 + > > drivers/mfd/Makefile | 1 + > > drivers/mfd/pef2256-regs.h | 250 ++++++++++ > > drivers/mfd/pef2256.c | 950 ++++++++++++++++++++++++++++++++++++ > > 95% of this driver needs to be moved somewhere else. > > What is a Framer? Perhaps sound/ is a good candidate? The pef2256 framer is a device that transfers data to/from a TDM (time-slots data) from/to quite old telecommunication lines (E1 in my case). Several subsystem can set/get data to/from the TDM. Each device using their own time-slots set. On my use-case, I have some audio consumer and a not yet upstreamed HDLC consumer. Both of them uses the framer to know the E1 link state. The framer needs to be initialized 'globally' and not by a specific consumer as several consumers can use the framer. > > > include/linux/mfd/pef2256.h | 52 ++ > > 5 files changed, 1269 insertions(+) > > create mode 100644 drivers/mfd/pef2256-regs.h > > create mode 100644 drivers/mfd/pef2256.c > > create mode 100644 include/linux/mfd/pef2256.h > > [...] > > > +static int pef2256_add_audio_devices(struct pef2256 *pef2256) > > +{ > > + const char *compatible = "lantiq,pef2256-codec"; > > + struct mfd_cell *audio_devs; > > + struct device_node *np; > > + unsigned int count = 0; > > + unsigned int i; > > + int ret; > > + > > + for_each_available_child_of_node(pef2256->dev->of_node, np) { > > + if (of_device_is_compatible(np, compatible)) > > + count++; > > + } > > Converting Device Tree nodes into MFD cells to register with the > Platform Device API is not a reasonable use-case of MFD. > > Have the CODEC driver match on "lantiq,pef2256-codec" and let it > instantiate itself. As the framer is going to used by several subsystem, I cannot instantiate it in the specific ASoC subsystem. > > Your first version using of_platform_populate() was closer to the mark. The issue was that I need MFD cells for the pinctrl part. > > > + if (!count) > > + return 0; > > + > > + audio_devs = kcalloc(count, sizeof(*audio_devs), GFP_KERNEL); > > + if (!audio_devs) > > + return -ENOMEM; > > + > > + for (i = 0; i < count; i++) { > > + (audio_devs + i)->name = "lantiq-pef2256-codec"; > > + (audio_devs + i)->of_compatible = compatible; > > + (audio_devs + i)->id = i; > > + } > > + > > + ret = mfd_add_devices(pef2256->dev, 0, audio_devs, count, NULL, 0, NULL); > > + kfree(audio_devs); > > + return ret; > > +} > Best regards, Hervé -- Hervé Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com