* [PATCH 1/2] dt-bindings: regulator: Add dt property
@ 2023-04-18 14:50 Naresh Solanki
2023-04-20 0:01 ` Zev Weiss
0 siblings, 1 reply; 7+ messages in thread
From: Naresh Solanki @ 2023-04-18 14:50 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Zev Weiss
Cc: Naresh Solanki, linux-kernel, devicetree
Add DT property regulator-supplies.
This enables us to couple one or more regulator output to gether. This
is use in case of Single connector having 2 or more supplies.
Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
---
.../bindings/regulator/regulator-output.yaml | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/regulator-output.yaml b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
index 078b37a1a71a..17f683d3c1f3 100644
--- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
+++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
@@ -21,13 +21,19 @@ properties:
compatible:
const: regulator-output
- vout-supply:
+ regulator-supplies:
description:
- Phandle of the regulator supplying the output.
+ Specifies the name of the output supply provided by the regulator.
+ Defaults to "vout".
+ default: "vout"
+
+patternProperties:
+ ".*-supply":
+ description:
+ Specified the phandle for various supplies
required:
- compatible
- - vout-supply
additionalProperties: false
base-commit: c55470f8b0616b0adb758077dbae9b19c5aac005
--
2.39.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: regulator: Add dt property
2023-04-18 14:50 [PATCH 1/2] dt-bindings: regulator: Add dt property Naresh Solanki
@ 2023-04-20 0:01 ` Zev Weiss
2023-04-20 8:22 ` Naresh Solanki
0 siblings, 1 reply; 7+ messages in thread
From: Zev Weiss @ 2023-04-20 0:01 UTC (permalink / raw)
To: Naresh Solanki
Cc: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
linux-kernel, devicetree
On Tue, Apr 18, 2023 at 07:50:50AM PDT, Naresh Solanki wrote:
>Add DT property regulator-supplies.
>This enables us to couple one or more regulator output to gether. This
>is use in case of Single connector having 2 or more supplies.
>
>Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>---
> .../bindings/regulator/regulator-output.yaml | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/regulator/regulator-output.yaml b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>index 078b37a1a71a..17f683d3c1f3 100644
>--- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>+++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>@@ -21,13 +21,19 @@ properties:
> compatible:
> const: regulator-output
>
>- vout-supply:
>+ regulator-supplies:
> description:
>- Phandle of the regulator supplying the output.
>+ Specifies the name of the output supply provided by the regulator.
>+ Defaults to "vout".
>+ default: "vout"
>+
Was this meant to be specified as a string-array to allow providing
multiple names?
>+patternProperties:
>+ ".*-supply":
>+ description:
>+ Specified the phandle for various supplies
>
> required:
> - compatible
>- - vout-supply
>
> additionalProperties: false
>
>
I think it would be nice to also update the examples to show what a
multi-supply instance would look like.
A slightly more descriptive subject line would also be good -- "Add dt
property" is a bit vague.
>base-commit: c55470f8b0616b0adb758077dbae9b19c5aac005
>--
>2.39.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: regulator: Add dt property
2023-04-20 0:01 ` Zev Weiss
@ 2023-04-20 8:22 ` Naresh Solanki
2023-04-20 10:41 ` Zev Weiss
2023-04-21 18:10 ` Rob Herring
0 siblings, 2 replies; 7+ messages in thread
From: Naresh Solanki @ 2023-04-20 8:22 UTC (permalink / raw)
To: Zev Weiss
Cc: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
linux-kernel, devicetree
Hi Zev,
On 20-04-2023 05:31 am, Zev Weiss wrote:
> On Tue, Apr 18, 2023 at 07:50:50AM PDT, Naresh Solanki wrote:
>> Add DT property regulator-supplies.
>> This enables us to couple one or more regulator output to gether. This
>> is use in case of Single connector having 2 or more supplies.
>>
>> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>> ---
>> .../bindings/regulator/regulator-output.yaml | 12 +++++++++---
>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>> b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>> index 078b37a1a71a..17f683d3c1f3 100644
>> --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>> +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>> @@ -21,13 +21,19 @@ properties:
>> compatible:
>> const: regulator-output
>>
>> - vout-supply:
>> + regulator-supplies:
>> description:
>> - Phandle of the regulator supplying the output.
>> + Specifies the name of the output supply provided by the regulator.
>> + Defaults to "vout".
>> + default: "vout"
>> +
>
> Was this meant to be specified as a string-array to allow providing
> multiple names?
Yes. This is string-array.
>
>> +patternProperties:
>> + ".*-supply":
>> + description:
>> + Specified the phandle for various supplies
>>
>> required:
>> - compatible
>> - - vout-supply
>>
>> additionalProperties: false
>>
>>
>
> I think it would be nice to also update the examples to show what a
> multi-supply instance would look like.
Ack. Will do that.
>
> A slightly more descriptive subject line would also be good -- "Add dt
> property" is a bit vague.
Suggestion ?
How about like 'Allow multiple supplies' or 'Add support for multiple
supplies'
>
>> base-commit: c55470f8b0616b0adb758077dbae9b19c5aac005
>> --
>> 2.39.1
>>
Regards,
Naresh
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: regulator: Add dt property
2023-04-20 8:22 ` Naresh Solanki
@ 2023-04-20 10:41 ` Zev Weiss
2023-04-20 11:32 ` Naresh Solanki
2023-04-21 18:10 ` Rob Herring
1 sibling, 1 reply; 7+ messages in thread
From: Zev Weiss @ 2023-04-20 10:41 UTC (permalink / raw)
To: Naresh Solanki
Cc: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
linux-kernel, devicetree
On Thu, Apr 20, 2023 at 01:22:30AM PDT, Naresh Solanki wrote:
>Hi Zev,
>
>On 20-04-2023 05:31 am, Zev Weiss wrote:
>>On Tue, Apr 18, 2023 at 07:50:50AM PDT, Naresh Solanki wrote:
>>>Add DT property regulator-supplies.
>>>This enables us to couple one or more regulator output to gether. This
>>>is use in case of Single connector having 2 or more supplies.
>>>
>>>Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>>>---
>>>.../bindings/regulator/regulator-output.yaml | 12 +++++++++---
>>>1 file changed, 9 insertions(+), 3 deletions(-)
>>>
>>>diff --git
>>>a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>index 078b37a1a71a..17f683d3c1f3 100644
>>>--- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>+++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>@@ -21,13 +21,19 @@ properties:
>>> compatible:
>>> const: regulator-output
>>>
>>>- vout-supply:
>>>+ regulator-supplies:
>>> description:
>>>- Phandle of the regulator supplying the output.
>>>+ Specifies the name of the output supply provided by the regulator.
>>>+ Defaults to "vout".
>>>+ default: "vout"
>>>+
>>
>>Was this meant to be specified as a string-array to allow providing
>>multiple names?
>Yes. This is string-array.
Okay -- in that case I think it should include
$ref: /schemas/types.yaml#/definitions/string-array
>>
>>>+patternProperties:
>>>+ ".*-supply":
>>>+ description:
>>>+ Specified the phandle for various supplies
>>>
>>>required:
>>> - compatible
>>>- - vout-supply
>>>
>>>additionalProperties: false
>>>
>>>
>>
>>I think it would be nice to also update the examples to show what a
>>multi-supply instance would look like.
>Ack. Will do that.
>>
>>A slightly more descriptive subject line would also be good -- "Add
>>dt property" is a bit vague.
>Suggestion ?
>How about like 'Allow multiple supplies' or 'Add support for multiple
>supplies'
Sure, both of those sound fine to me.
>>
>>>base-commit: c55470f8b0616b0adb758077dbae9b19c5aac005
>>>--
>>>2.39.1
>>>
>Regards,
>Naresh
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: regulator: Add dt property
2023-04-20 10:41 ` Zev Weiss
@ 2023-04-20 11:32 ` Naresh Solanki
0 siblings, 0 replies; 7+ messages in thread
From: Naresh Solanki @ 2023-04-20 11:32 UTC (permalink / raw)
To: Zev Weiss
Cc: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
linux-kernel, devicetree
Hi Zev,
On 20-04-2023 04:11 pm, Zev Weiss wrote:
> On Thu, Apr 20, 2023 at 01:22:30AM PDT, Naresh Solanki wrote:
>> Hi Zev,
>>
>> On 20-04-2023 05:31 am, Zev Weiss wrote:
>>> On Tue, Apr 18, 2023 at 07:50:50AM PDT, Naresh Solanki wrote:
>>>> Add DT property regulator-supplies.
>>>> This enables us to couple one or more regulator output to gether. This
>>>> is use in case of Single connector having 2 or more supplies.
>>>>
>>>> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>>>> ---
>>>> .../bindings/regulator/regulator-output.yaml | 12 +++++++++---
>>>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git
>>>> a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> index 078b37a1a71a..17f683d3c1f3 100644
>>>> --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> @@ -21,13 +21,19 @@ properties:
>>>> compatible:
>>>> const: regulator-output
>>>>
>>>> - vout-supply:
>>>> + regulator-supplies:
>>>> description:
>>>> - Phandle of the regulator supplying the output.
>>>> + Specifies the name of the output supply provided by the
>>>> regulator.
>>>> + Defaults to "vout".
>>>> + default: "vout"
>>>> +
>>>
>>> Was this meant to be specified as a string-array to allow providing
>>> multiple names?
>> Yes. This is string-array.
>
> Okay -- in that case I think it should include
>
> $ref: /schemas/types.yaml#/definitions/string-array
Ack
>
>>>
>>>> +patternProperties:
>>>> + ".*-supply":
>>>> + description:
>>>> + Specified the phandle for various supplies
>>>>
>>>> required:
>>>> - compatible
>>>> - - vout-supply
>>>>
>>>> additionalProperties: false
>>>>
>>>>
>>>
>>> I think it would be nice to also update the examples to show what a
>>> multi-supply instance would look like.
>> Ack. Will do that.
>>>
>>> A slightly more descriptive subject line would also be good -- "Add
>>> dt property" is a bit vague.
>> Suggestion ?
>> How about like 'Allow multiple supplies' or 'Add support for multiple
>> supplies'
>
> Sure, both of those sound fine to me.
Thanks :)
>
>>>
>>>> base-commit: c55470f8b0616b0adb758077dbae9b19c5aac005
>>>> --
>>>> 2.39.1
>>>>
>> Regards,
>> Naresh
Regards,
Naresh
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: regulator: Add dt property
2023-04-20 8:22 ` Naresh Solanki
2023-04-20 10:41 ` Zev Weiss
@ 2023-04-21 18:10 ` Rob Herring
2023-04-24 7:49 ` Naresh Solanki
1 sibling, 1 reply; 7+ messages in thread
From: Rob Herring @ 2023-04-21 18:10 UTC (permalink / raw)
To: Naresh Solanki
Cc: Zev Weiss, Liam Girdwood, Mark Brown, Krzysztof Kozlowski,
linux-kernel, devicetree
On Thu, Apr 20, 2023 at 01:52:30PM +0530, Naresh Solanki wrote:
> Hi Zev,
>
> On 20-04-2023 05:31 am, Zev Weiss wrote:
> > On Tue, Apr 18, 2023 at 07:50:50AM PDT, Naresh Solanki wrote:
> > > Add DT property regulator-supplies.
> > > This enables us to couple one or more regulator output to gether. This
> > > is use in case of Single connector having 2 or more supplies.
> > >
> > > Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
> > > ---
> > > .../bindings/regulator/regulator-output.yaml | 12 +++++++++---
> > > 1 file changed, 9 insertions(+), 3 deletions(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> > > b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> > > index 078b37a1a71a..17f683d3c1f3 100644
> > > --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> > > +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> > > @@ -21,13 +21,19 @@ properties:
> > > compatible:
> > > const: regulator-output
> > >
> > > - vout-supply:
> > > + regulator-supplies:
> > > description:
> > > - Phandle of the regulator supplying the output.
> > > + Specifies the name of the output supply provided by the regulator.
> > > + Defaults to "vout".
> > > + default: "vout"
> > > +
> >
> > Was this meant to be specified as a string-array to allow providing
> > multiple names?
> Yes. This is string-array.
> >
> > > +patternProperties:
> > > + ".*-supply":
> > > + description:
> > > + Specified the phandle for various supplies
> > >
> > > required:
> > > - compatible
> > > - - vout-supply
> > >
> > > additionalProperties: false
> > >
> > >
> >
> > I think it would be nice to also update the examples to show what a
> > multi-supply instance would look like.
> Ack. Will do that.
> >
> > A slightly more descriptive subject line would also be good -- "Add dt
> > property" is a bit vague.
> Suggestion ?
> How about like 'Allow multiple supplies' or 'Add support for multiple
> supplies'
And indicate this is for regulator-output, As-is looks like it's
something for all regulators.
Rob
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: regulator: Add dt property
2023-04-21 18:10 ` Rob Herring
@ 2023-04-24 7:49 ` Naresh Solanki
0 siblings, 0 replies; 7+ messages in thread
From: Naresh Solanki @ 2023-04-24 7:49 UTC (permalink / raw)
To: Rob Herring
Cc: Zev Weiss, Liam Girdwood, Mark Brown, Krzysztof Kozlowski,
linux-kernel, devicetree
Hi Rob,
On 21-04-2023 11:40 pm, Rob Herring wrote:
> On Thu, Apr 20, 2023 at 01:52:30PM +0530, Naresh Solanki wrote:
>> Hi Zev,
>>
>> On 20-04-2023 05:31 am, Zev Weiss wrote:
>>> On Tue, Apr 18, 2023 at 07:50:50AM PDT, Naresh Solanki wrote:
>>>> Add DT property regulator-supplies.
>>>> This enables us to couple one or more regulator output to gether. This
>>>> is use in case of Single connector having 2 or more supplies.
>>>>
>>>> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>>>> ---
>>>> .../bindings/regulator/regulator-output.yaml | 12 +++++++++---
>>>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git
>>>> a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> index 078b37a1a71a..17f683d3c1f3 100644
>>>> --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> @@ -21,13 +21,19 @@ properties:
>>>> compatible:
>>>> const: regulator-output
>>>>
>>>> - vout-supply:
>>>> + regulator-supplies:
>>>> description:
>>>> - Phandle of the regulator supplying the output.
>>>> + Specifies the name of the output supply provided by the regulator.
>>>> + Defaults to "vout".
>>>> + default: "vout"
>>>> +
>>>
>>> Was this meant to be specified as a string-array to allow providing
>>> multiple names?
>> Yes. This is string-array.
>>>
>>>> +patternProperties:
>>>> + ".*-supply":
>>>> + description:
>>>> + Specified the phandle for various supplies
>>>>
>>>> required:
>>>> - compatible
>>>> - - vout-supply
>>>>
>>>> additionalProperties: false
>>>>
>>>>
>>>
>>> I think it would be nice to also update the examples to show what a
>>> multi-supply instance would look like.
>> Ack. Will do that.
>>>
>>> A slightly more descriptive subject line would also be good -- "Add dt
>>> property" is a bit vague.
>> Suggestion ?
>> How about like 'Allow multiple supplies' or 'Add support for multiple
>> supplies'
>
> And indicate this is for regulator-output, As-is looks like it's
> something for all regulators.
Thanks for bringing that to my notice. Will make:
dt-bindings: regulator-output: Add dt property
>
> Rob
Regards,
Naresh
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-04-24 7:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-18 14:50 [PATCH 1/2] dt-bindings: regulator: Add dt property Naresh Solanki
2023-04-20 0:01 ` Zev Weiss
2023-04-20 8:22 ` Naresh Solanki
2023-04-20 10:41 ` Zev Weiss
2023-04-20 11:32 ` Naresh Solanki
2023-04-21 18:10 ` Rob Herring
2023-04-24 7:49 ` Naresh Solanki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).