From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9709DC6FD18 for ; Sat, 22 Apr 2023 11:01:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229549AbjDVLBV (ORCPT ); Sat, 22 Apr 2023 07:01:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbjDVLBU (ORCPT ); Sat, 22 Apr 2023 07:01:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50B371732; Sat, 22 Apr 2023 04:01:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DFC00616CF; Sat, 22 Apr 2023 11:01:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 321A2C433EF; Sat, 22 Apr 2023 11:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682161278; bh=eVkA5qRbG7ZudcgJeG5Kdt/+eFltaTkDK+prt8aMiyw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pEiPwNJKpIJmxS/odeoV3sb6cqZu/ch2hk6pzx40FlFlGKMHDXBwRfwrJ0UmFsakK bhutKUxak376MqmtXIyMJcaz9zsx/lDPDxgJ1L32EvF/tNEA5/tWV6ItuyXklTYBsF /mQwMgDrUHCE9rBEcZ+roN1KeMpfOXDt4ytTHESSpumYe8jm45SJ/cxtJzjG5HGvOV TUJ+xGib4ay4M+s3ZeuCqNsODiC9VthTehoWautmzsIkxJbNyE1kpv7uX+D2osyp9T kiOKGFh23ZSYP148XQKnfqyxX5/mtOa2HVoXoQamyK3ImhwotpSZsOlS5F0xmj3OO9 W+G7Li85vc06w== Date: Sat, 22 Apr 2023 16:31:08 +0530 From: Manivannan Sadhasivam To: Yoshihiro Shimoda Cc: jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, fancer.lancer@gmail.com, lpieralisi@kernel.org, robh+dt@kernel.org, kw@linux.com, bhelgaas@google.com, kishon@kernel.org, marek.vasut+renesas@gmail.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH v13 05/22] PCI: dwc: Rename with dw_pcie_ep_raise_intx_irq() Message-ID: <20230422110108.GB4769@thinkpad> References: <20230418122403.3178462-1-yoshihiro.shimoda.uh@renesas.com> <20230418122403.3178462-6-yoshihiro.shimoda.uh@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230418122403.3178462-6-yoshihiro.shimoda.uh@renesas.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Apr 18, 2023 at 09:23:46PM +0900, Yoshihiro Shimoda wrote: Subject should be: PCI: dwc: Rename "legacy_irq" to "INTx_irq" in DWC core > Using "INTx" instead of "legacy" is more specific. So, rename > dw_pcie_ep_raise_legacy_irq() with dw_pcie_ep_raise_intx_irq(). > s/with/to There are still many instances of "legacy" used inside the DWC drivers. But I suppose those could be fixed by the respective driver maintainers. > Suggested-by: Bjorn Helgaas > Signed-off-by: Yoshihiro Shimoda With above changes, Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/dwc/pci-imx6.c | 2 +- > drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 +- > drivers/pci/controller/dwc/pcie-designware-ep.c | 6 +++--- > drivers/pci/controller/dwc/pcie-designware-plat.c | 2 +- > drivers/pci/controller/dwc/pcie-designware.h | 4 ++-- > drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 +- > 6 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 1f39e733ce19..0831f3947220 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -1063,7 +1063,7 @@ static int imx6_pcie_ep_raise_irq(struct dw_pcie_ep *ep, u8 func_no, > > switch (type) { > case PCI_EPC_IRQ_INTX: > - return dw_pcie_ep_raise_legacy_irq(ep, func_no); > + return dw_pcie_ep_raise_intx_irq(ep, func_no); > case PCI_EPC_IRQ_MSI: > return dw_pcie_ep_raise_msi_irq(ep, func_no, interrupt_num); > case PCI_EPC_IRQ_MSIX: > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > index ab3306e206d8..3d58fc1670b4 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > @@ -66,7 +66,7 @@ static int ls_pcie_ep_raise_irq(struct dw_pcie_ep *ep, u8 func_no, > > switch (type) { > case PCI_EPC_IRQ_INTX: > - return dw_pcie_ep_raise_legacy_irq(ep, func_no); > + return dw_pcie_ep_raise_intx_irq(ep, func_no); > case PCI_EPC_IRQ_MSI: > return dw_pcie_ep_raise_msi_irq(ep, func_no, interrupt_num); > case PCI_EPC_IRQ_MSIX: > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c > index 205bbcc6af27..a80b9fd03638 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c > @@ -480,16 +480,16 @@ static const struct pci_epc_ops epc_ops = { > .get_features = dw_pcie_ep_get_features, > }; > > -int dw_pcie_ep_raise_legacy_irq(struct dw_pcie_ep *ep, u8 func_no) > +int dw_pcie_ep_raise_intx_irq(struct dw_pcie_ep *ep, u8 func_no) > { > struct dw_pcie *pci = to_dw_pcie_from_ep(ep); > struct device *dev = pci->dev; > > - dev_err(dev, "EP cannot trigger legacy IRQs\n"); > + dev_err(dev, "EP cannot trigger INTx IRQs\n"); > > return -EINVAL; > } > -EXPORT_SYMBOL_GPL(dw_pcie_ep_raise_legacy_irq); > +EXPORT_SYMBOL_GPL(dw_pcie_ep_raise_intx_irq); > > int dw_pcie_ep_raise_msi_irq(struct dw_pcie_ep *ep, u8 func_no, > u8 interrupt_num) > diff --git a/drivers/pci/controller/dwc/pcie-designware-plat.c b/drivers/pci/controller/dwc/pcie-designware-plat.c > index fc3b02949218..2689ff7939e4 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-plat.c > +++ b/drivers/pci/controller/dwc/pcie-designware-plat.c > @@ -49,7 +49,7 @@ static int dw_plat_pcie_ep_raise_irq(struct dw_pcie_ep *ep, u8 func_no, > > switch (type) { > case PCI_EPC_IRQ_INTX: > - return dw_pcie_ep_raise_legacy_irq(ep, func_no); > + return dw_pcie_ep_raise_intx_irq(ep, func_no); > case PCI_EPC_IRQ_MSI: > return dw_pcie_ep_raise_msi_irq(ep, func_no, interrupt_num); > case PCI_EPC_IRQ_MSIX: > diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h > index adad0ea61799..9acf6c40d252 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.h > +++ b/drivers/pci/controller/dwc/pcie-designware.h > @@ -550,7 +550,7 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep); > int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep); > void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep); > void dw_pcie_ep_exit(struct dw_pcie_ep *ep); > -int dw_pcie_ep_raise_legacy_irq(struct dw_pcie_ep *ep, u8 func_no); > +int dw_pcie_ep_raise_intx_irq(struct dw_pcie_ep *ep, u8 func_no); > int dw_pcie_ep_raise_msi_irq(struct dw_pcie_ep *ep, u8 func_no, > u8 interrupt_num); > int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8 func_no, > @@ -583,7 +583,7 @@ static inline void dw_pcie_ep_exit(struct dw_pcie_ep *ep) > { > } > > -static inline int dw_pcie_ep_raise_legacy_irq(struct dw_pcie_ep *ep, u8 func_no) > +static inline int dw_pcie_ep_raise_intx_irq(struct dw_pcie_ep *ep, u8 func_no) > { > return 0; > } > diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c > index 077afce48d0b..3061e5e13476 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c > +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c > @@ -659,7 +659,7 @@ static int qcom_pcie_ep_raise_irq(struct dw_pcie_ep *ep, u8 func_no, > > switch (type) { > case PCI_EPC_IRQ_INTX: > - return dw_pcie_ep_raise_legacy_irq(ep, func_no); > + return dw_pcie_ep_raise_intx_irq(ep, func_no); > case PCI_EPC_IRQ_MSI: > return dw_pcie_ep_raise_msi_irq(ep, func_no, interrupt_num); > default: > -- > 2.25.1 > -- மணிவண்ணன் சதாசிவம்