From: Sebastian Reichel <sre@kernel.org>
To: Sebastian Reichel <sre@kernel.org>
Cc: Gerald Loacker <gerald.loacker@wolfvision.net>,
Michael Riesch <michael.riesch@wolfvision.net>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org
Subject: [PATCH v2 10/13] drm/panel: sitronix-st7789v: add media bus format
Date: Sat, 22 Apr 2023 22:50:09 +0200 [thread overview]
Message-ID: <20230422205012.2464933-11-sre@kernel.org> (raw)
In-Reply-To: <20230422205012.2464933-1-sre@kernel.org>
Add support for describing the media bus format in the
panel configuration and expose that to userspace. Since
both supported formats (RGB565 and RGB666) are using 6
bits per color also hardcode that information.
Signed-off-by: Sebastian Reichel <sre@kernel.org>
---
.../gpu/drm/panel/panel-sitronix-st7789v.c | 26 ++++++++++++++++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
index 0e1839e6da73..6d155c6262f3 100644
--- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
+++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
@@ -10,6 +10,7 @@
#include <linux/spi/spi.h>
#include <video/mipi_display.h>
+#include <linux/media-bus-format.h>
#include <drm/drm_device.h>
#include <drm/drm_modes.h>
@@ -110,6 +111,7 @@
struct st7789_panel_info {
const struct drm_display_mode *mode;
+ u32 bus_format;
};
struct st7789v {
@@ -169,6 +171,7 @@ static const struct drm_display_mode default_mode = {
struct st7789_panel_info default_panel = {
.mode = &default_mode,
+ .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
};
static int st7789v_get_modes(struct drm_panel *panel,
@@ -190,8 +193,11 @@ static int st7789v_get_modes(struct drm_panel *panel,
mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
drm_mode_probed_add(connector, mode);
+ connector->display_info.bpc = 6;
connector->display_info.width_mm = ctx->info->mode->width_mm;
connector->display_info.height_mm = ctx->info->mode->height_mm;
+ drm_display_info_set_bus_formats(&connector->display_info,
+ &ctx->info->bus_format, 1);
return 1;
}
@@ -199,8 +205,24 @@ static int st7789v_get_modes(struct drm_panel *panel,
static int st7789v_prepare(struct drm_panel *panel)
{
struct st7789v *ctx = panel_to_st7789v(panel);
+ u8 pixel_fmt;
int ret;
+ switch (ctx->info->bus_format) {
+ case MEDIA_BUS_FMT_RGB666_1X18:
+ pixel_fmt = MIPI_DCS_PIXEL_FMT_18BIT;
+ break;
+ case MEDIA_BUS_FMT_RGB565_1X16:
+ pixel_fmt = MIPI_DCS_PIXEL_FMT_16BIT;
+ break;
+ default:
+ dev_err(panel->dev, "unsupported bus format: %d\n",
+ ctx->info->bus_format);
+ return -EINVAL;
+ }
+
+ pixel_fmt = (pixel_fmt << 4) | pixel_fmt;
+
ret = regulator_enable(ctx->power);
if (ret)
return ret;
@@ -221,9 +243,7 @@ static int st7789v_prepare(struct drm_panel *panel)
ST7789V_TEST(ret, st7789v_write_command(ctx,
MIPI_DCS_SET_PIXEL_FORMAT));
- ST7789V_TEST(ret, st7789v_write_data(ctx,
- (MIPI_DCS_PIXEL_FMT_18BIT << 4) |
- (MIPI_DCS_PIXEL_FMT_18BIT)));
+ ST7789V_TEST(ret, st7789v_write_data(ctx, pixel_fmt));
ST7789V_TEST(ret, st7789v_write_command(ctx, ST7789V_PORCTRL_CMD));
ST7789V_TEST(ret, st7789v_write_data(ctx, 0xc));
--
2.39.2
next prev parent reply other threads:[~2023-04-22 20:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-22 20:49 [PATCH v2 00/13] Add Inanbo T28CP45TN89 panel support Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 01/13] dt-bindings: vendor-prefixes: add Inanbo Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 02/13] dt-bindings: display: st7789v: add Inanbo T28CP45TN89 Sebastian Reichel
2023-04-25 18:49 ` Rob Herring
2023-04-22 20:50 ` [PATCH v2 03/13] drm/panel: sitronix-st7789v: add SPI ID table Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 04/13] drm/panel: sitronix-st7789v: remove unused constants Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 05/13] drm/panel: sitronix-st7789v: make reset GPIO optional Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 06/13] drm/panel: sitronix-st7789v: simplify st7789v_spi_write Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 07/13] drm/panel: sitronix-st7789v: improve error handling Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 08/13] drm/panel: sitronix-st7789v: avoid hardcoding mode info Sebastian Reichel
2023-05-05 12:33 ` Michael Riesch
2023-04-22 20:50 ` [PATCH v2 09/13] drm/panel: sitronix-st7789v: avoid hardcoding panel size Sebastian Reichel
2023-04-22 20:50 ` Sebastian Reichel [this message]
2023-04-22 20:50 ` [PATCH v2 11/13] drm/panel: sitronix-st7789v: avoid hardcoding invert mode Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 12/13] drm/panel: sitronix-st7789v: avoid hardcoding polarity info Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 13/13] drm/panel: sitronix-st7789v: add Inanbo T28CP45TN89 support Sebastian Reichel
2023-07-12 16:31 ` [PATCH v2 00/13] Add Inanbo T28CP45TN89 panel support Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230422205012.2464933-11-sre@kernel.org \
--to=sre@kernel.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gerald.loacker@wolfvision.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.riesch@wolfvision.net \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).