devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Sebastian Reichel <sre@kernel.org>
Cc: Gerald Loacker <gerald.loacker@wolfvision.net>,
	Michael Riesch <michael.riesch@wolfvision.net>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	devicetree@vger.kernel.org
Subject: [PATCH v2 08/13] drm/panel: sitronix-st7789v: avoid hardcoding mode info
Date: Sat, 22 Apr 2023 22:50:07 +0200	[thread overview]
Message-ID: <20230422205012.2464933-9-sre@kernel.org> (raw)
In-Reply-To: <20230422205012.2464933-1-sre@kernel.org>

Avoid hard-coding the default_mode and supply it from match data. One
additional layer of abstraction has been introduced, which will be
needed for specifying other panel information (e.g. bus flags) in the
next steps.

Signed-off-by: Sebastian Reichel <sre@kernel.org>
---
 .../gpu/drm/panel/panel-sitronix-st7789v.c    | 24 ++++++++++++++-----
 1 file changed, 18 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
index a6d6155ef45c..29c2a91f8299 100644
--- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
+++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
@@ -108,8 +108,13 @@
 			return val;		\
 	} while (0)
 
+struct st7789_panel_info {
+	const struct drm_display_mode *mode;
+};
+
 struct st7789v {
 	struct drm_panel panel;
+	const struct st7789_panel_info *info;
 	struct spi_device *spi;
 	struct gpio_desc *reset;
 	struct regulator *power;
@@ -160,16 +165,21 @@ static const struct drm_display_mode default_mode = {
 	.vtotal = 320 + 8 + 4 + 4,
 };
 
+struct st7789_panel_info default_panel = {
+	.mode = &default_mode,
+};
+
 static int st7789v_get_modes(struct drm_panel *panel,
 			     struct drm_connector *connector)
 {
+	struct st7789v *ctx = panel_to_st7789v(panel);
 	struct drm_display_mode *mode;
 
-	mode = drm_mode_duplicate(connector->dev, &default_mode);
+	mode = drm_mode_duplicate(connector->dev, ctx->info->mode);
 	if (!mode) {
-		dev_err(panel->dev, "failed to add mode %ux%ux@%u\n",
-			default_mode.hdisplay, default_mode.vdisplay,
-			drm_mode_vrefresh(&default_mode));
+		dev_err(panel->dev, "failed to add mode %ux%u@%u\n",
+			ctx->info->mode->hdisplay, ctx->info->mode->vdisplay,
+			drm_mode_vrefresh(ctx->info->mode));
 		return -ENOMEM;
 	}
 
@@ -359,6 +369,8 @@ static int st7789v_probe(struct spi_device *spi)
 	spi_set_drvdata(spi, ctx);
 	ctx->spi = spi;
 
+	ctx->info = device_get_match_data(&spi->dev);
+
 	drm_panel_init(&ctx->panel, dev, &st7789v_drm_funcs,
 		       DRM_MODE_CONNECTOR_DPI);
 
@@ -389,13 +401,13 @@ static void st7789v_remove(struct spi_device *spi)
 }
 
 static const struct spi_device_id st7789v_spi_id[] = {
-	{ "st7789v" },
+	{ "st7789v", (unsigned long) &default_panel },
 	{ }
 };
 MODULE_DEVICE_TABLE(spi, st7789v_spi_id);
 
 static const struct of_device_id st7789v_of_match[] = {
-	{ .compatible = "sitronix,st7789v" },
+	{ .compatible = "sitronix,st7789v", .data = &default_panel },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, st7789v_of_match);
-- 
2.39.2


  parent reply	other threads:[~2023-04-22 20:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-22 20:49 [PATCH v2 00/13] Add Inanbo T28CP45TN89 panel support Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 01/13] dt-bindings: vendor-prefixes: add Inanbo Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 02/13] dt-bindings: display: st7789v: add Inanbo T28CP45TN89 Sebastian Reichel
2023-04-25 18:49   ` Rob Herring
2023-04-22 20:50 ` [PATCH v2 03/13] drm/panel: sitronix-st7789v: add SPI ID table Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 04/13] drm/panel: sitronix-st7789v: remove unused constants Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 05/13] drm/panel: sitronix-st7789v: make reset GPIO optional Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 06/13] drm/panel: sitronix-st7789v: simplify st7789v_spi_write Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 07/13] drm/panel: sitronix-st7789v: improve error handling Sebastian Reichel
2023-04-22 20:50 ` Sebastian Reichel [this message]
2023-05-05 12:33   ` [PATCH v2 08/13] drm/panel: sitronix-st7789v: avoid hardcoding mode info Michael Riesch
2023-04-22 20:50 ` [PATCH v2 09/13] drm/panel: sitronix-st7789v: avoid hardcoding panel size Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 10/13] drm/panel: sitronix-st7789v: add media bus format Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 11/13] drm/panel: sitronix-st7789v: avoid hardcoding invert mode Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 12/13] drm/panel: sitronix-st7789v: avoid hardcoding polarity info Sebastian Reichel
2023-04-22 20:50 ` [PATCH v2 13/13] drm/panel: sitronix-st7789v: add Inanbo T28CP45TN89 support Sebastian Reichel
2023-07-12 16:31 ` [PATCH v2 00/13] Add Inanbo T28CP45TN89 panel support Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230422205012.2464933-9-sre@kernel.org \
    --to=sre@kernel.org \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gerald.loacker@wolfvision.net \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.riesch@wolfvision.net \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).