* [PATCH 1/7] dt-bindings: display: panel: Add synaptics r63353 panel controller
2023-04-21 15:43 [PATCH 0/7] add displays support for bsh-smm-s2/pro boards Dario Binacchi
@ 2023-04-21 15:43 ` Dario Binacchi
2023-04-25 18:10 ` Rob Herring
2023-04-21 15:43 ` [PATCH 3/7] arm64: dts: imx8mn-bsh-smm-s2/pro: add display setup Dario Binacchi
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Dario Binacchi @ 2023-04-21 15:43 UTC (permalink / raw)
To: linux-kernel
Cc: michael, Amarula patchwork, Dario Binacchi, Daniel Vetter,
David Airlie, Krzysztof Kozlowski, Rob Herring, Sam Ravnborg,
Thierry Reding, devicetree, dri-devel
From: Michael Trimarchi <michael@amarulasolutions.com>
Add documentation for "synaptics,r63353" panel.
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
.../display/panel/synaptics,r63353.yaml | 58 +++++++++++++++++++
1 file changed, 58 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml b/Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml
new file mode 100644
index 000000000000..13e6ed39e124
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/synaptics,r63353.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Synaptics R63353 based MIPI-DSI panels
+
+maintainers:
+ - Michael Trimarchi <michael@amarulasolutions.com>
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - sharp,ls068b3sx02
+ - const: synaptics,r63353
+
+ avdd-supply: true
+ dvdd-supply: true
+ port: true
+ reg: true
+ reset-gpios: true
+ backlight: true
+
+required:
+ - compatible
+ - avdd-supply
+ - dvdd-supply
+ - reg
+ - reset-gpios
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ panel@0 {
+ compatible = "sharp,ls068b3sx02", "synaptics,r63353";
+ reg = <0>;
+ avdd-supply = <&avdd_display>;
+ dvdd-supply = <&dvdd_display>;
+ reset-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL05 */
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&mipi_dsi_out>;
+ };
+ };
+ };
+ };
+
+...
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/7] dt-bindings: display: panel: Add synaptics r63353 panel controller
2023-04-21 15:43 ` [PATCH 1/7] dt-bindings: display: panel: Add synaptics r63353 panel controller Dario Binacchi
@ 2023-04-25 18:10 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2023-04-25 18:10 UTC (permalink / raw)
To: Dario Binacchi
Cc: linux-kernel, michael, Amarula patchwork, Daniel Vetter,
David Airlie, Krzysztof Kozlowski, Sam Ravnborg, Thierry Reding,
devicetree, dri-devel
On Fri, Apr 21, 2023 at 05:43:02PM +0200, Dario Binacchi wrote:
> From: Michael Trimarchi <michael@amarulasolutions.com>
>
> Add documentation for "synaptics,r63353" panel.
>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
> .../display/panel/synaptics,r63353.yaml | 58 +++++++++++++++++++
> 1 file changed, 58 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml b/Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml
> new file mode 100644
> index 000000000000..13e6ed39e124
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/synaptics,r63353.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Synaptics R63353 based MIPI-DSI panels
> +
> +maintainers:
> + - Michael Trimarchi <michael@amarulasolutions.com>
> +
You need a $ref to panel-common.yaml.
> +properties:
> + compatible:
> + items:
> + - enum:
> + - sharp,ls068b3sx02
> + - const: synaptics,r63353
> +
> + avdd-supply: true
> + dvdd-supply: true
> + port: true
> + reg: true
> + reset-gpios: true
> + backlight: true
And then drop port, reset-gpios, and backlight.
> +
> +required:
> + - compatible
> + - avdd-supply
> + - dvdd-supply
> + - reg
> + - reset-gpios
> +
> +additionalProperties: false
And then 'unevaluatedProperties: false' here instead.
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + panel@0 {
> + compatible = "sharp,ls068b3sx02", "synaptics,r63353";
> + reg = <0>;
> + avdd-supply = <&avdd_display>;
> + dvdd-supply = <&dvdd_display>;
> + reset-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL05 */
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&mipi_dsi_out>;
> + };
> + };
> + };
> + };
> +
> +...
> --
> 2.32.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/7] arm64: dts: imx8mn-bsh-smm-s2/pro: add display setup
2023-04-21 15:43 [PATCH 0/7] add displays support for bsh-smm-s2/pro boards Dario Binacchi
2023-04-21 15:43 ` [PATCH 1/7] dt-bindings: display: panel: Add synaptics r63353 panel controller Dario Binacchi
@ 2023-04-21 15:43 ` Dario Binacchi
2023-04-22 1:44 ` kernel test robot
2023-04-21 15:43 ` [PATCH 4/7] dt-bindings: display: panel: Add Ilitek ili9805 panel controller Dario Binacchi
2023-04-21 15:43 ` [PATCH 6/7] dt-bindings: ili9805: add compatible string for Tianma TM041XDHG01 Dario Binacchi
3 siblings, 1 reply; 8+ messages in thread
From: Dario Binacchi @ 2023-04-21 15:43 UTC (permalink / raw)
To: linux-kernel
Cc: michael, Amarula patchwork, Dario Binacchi, Fabio Estevam,
Krzysztof Kozlowski, NXP Linux Team, Pengutronix Kernel Team,
Rob Herring, Sascha Hauer, Shawn Guo, devicetree,
linux-arm-kernel
From: Michael Trimarchi <michael@amarulasolutions.com>
Add the display and nodes required for its operation.
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
.../freescale/imx8mn-bsh-smm-s2-common.dtsi | 1 +
.../freescale/imx8mn-bsh-smm-s2-display.dtsi | 111 ++++++++++++++++++
2 files changed, 112 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi
index c11895d9d582..5f9c0df0ec7d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi
@@ -7,6 +7,7 @@
/dts-v1/;
#include "imx8mn.dtsi"
+#include "imx8mn-bsh-smm-s2-display.dtsi"
/ {
chosen {
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi
new file mode 100644
index 000000000000..bac987d76f1e
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi
@@ -0,0 +1,111 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2021 BSH
+ */
+
+/ {
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm1 0 700000 0>; /* 700000 ns = 1337Hz */
+ brightness-levels = <0 100>;
+ num-interpolated-steps = <100>;
+ default-brightness-level = <50>;
+ status = "okay";
+ };
+
+ reg_3v3_dvdd: regulator-3v3-O3 {
+ compatible = "regulator-fixed";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_dvdd>;
+ regulator-name = "3v3-dvdd-supply";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpio = <&gpio1 7 GPIO_ACTIVE_LOW>;
+ };
+
+ reg_v3v3_avdd: regulator-3v3-O2 {
+ compatible = "regulator-fixed";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_avdd>;
+ regulator-name = "3v3-avdd-supply";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpio = <&gpio1 5 GPIO_ACTIVE_LOW>;
+ };
+};
+
+&pwm1 {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_bl>;
+};
+
+&lcdif {
+ status = "okay";
+};
+
+&dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ panel@0 {
+ compatible = "sharp,ls068b3sx02", "synaptics,r63353";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_panel>;
+ reg = <0>;
+
+ backlight = <&backlight>;
+ dvdd-supply = <®_3v3_dvdd>;
+ avdd-supply = <®_v3v3_avdd>;
+ reset-gpios = <&gpio4 29 GPIO_ACTIVE_HIGH>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&mipi_dsi_out>;
+ };
+ };
+
+ };
+
+ ports {
+ port@1 {
+ reg = <1>;
+ mipi_dsi_out: endpoint {
+ remote-endpoint = <&panel_in>;
+ };
+ };
+ };
+};
+
+&gpu {
+ status = "okay";
+};
+
+&iomuxc {
+
+ /* This is for both PWM and voltage regulators for display */
+ pinctrl_bl: pwm1grp {
+ fsl,pins = <
+ MX8MN_IOMUXC_GPIO1_IO01_PWM1_OUT 0x16
+ >;
+ };
+
+ pinctrl_panel: panelgrp {
+ fsl,pins = <
+ MX8MN_IOMUXC_SAI3_RXC_GPIO4_IO29 0x16 /* panel reset */
+ >;
+ };
+
+ pinctrl_dvdd: dvddgrp {
+ fsl,pins = <
+ MX8MN_IOMUXC_GPIO1_IO07_GPIO1_IO7 0x16 /* VDD 3V3_VO3 */
+ >;
+ };
+
+ pinctrl_avdd: avddgrp {
+ fsl,pins = <
+ MX8MN_IOMUXC_GPIO1_IO05_GPIO1_IO5 0x16 /* VDD 3V3_VO2 */
+ >;
+ };
+};
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 3/7] arm64: dts: imx8mn-bsh-smm-s2/pro: add display setup
2023-04-21 15:43 ` [PATCH 3/7] arm64: dts: imx8mn-bsh-smm-s2/pro: add display setup Dario Binacchi
@ 2023-04-22 1:44 ` kernel test robot
0 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2023-04-22 1:44 UTC (permalink / raw)
To: Dario Binacchi, linux-kernel
Cc: oe-kbuild-all, michael, Amarula patchwork, Dario Binacchi,
Fabio Estevam, Krzysztof Kozlowski, NXP Linux Team,
Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo,
devicetree, linux-arm-kernel
Hi Dario,
kernel test robot noticed the following build errors:
[auto build test ERROR on shawnguo/for-next]
[also build test ERROR on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.3-rc7 next-20230421]
[cannot apply to drm-misc/drm-misc-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Dario-Binacchi/dt-bindings-display-panel-Add-synaptics-r63353-panel-controller/20230421-234627
base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
patch link: https://lore.kernel.org/r/20230421154308.527128-4-dario.binacchi%40amarulasolutions.com
patch subject: [PATCH 3/7] arm64: dts: imx8mn-bsh-smm-s2/pro: add display setup
config: arm64-buildonly-randconfig-r004-20230421 (https://download.01.org/0day-ci/archive/20230422/202304220932.cK8RhITJ-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/eb3fd6ddb6525c2084455d38de459aaaf0213471
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Dario-Binacchi/dt-bindings-display-panel-Add-synaptics-r63353-panel-controller/20230421-234627
git checkout eb3fd6ddb6525c2084455d38de459aaaf0213471
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304220932.cK8RhITJ-lkp@intel.com/
All errors (new ones prefixed by >>):
>> Error: arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi:47.1-5 Label or path dsi not found
>> FATAL ERROR: Syntax error parsing input tree
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 4/7] dt-bindings: display: panel: Add Ilitek ili9805 panel controller
2023-04-21 15:43 [PATCH 0/7] add displays support for bsh-smm-s2/pro boards Dario Binacchi
2023-04-21 15:43 ` [PATCH 1/7] dt-bindings: display: panel: Add synaptics r63353 panel controller Dario Binacchi
2023-04-21 15:43 ` [PATCH 3/7] arm64: dts: imx8mn-bsh-smm-s2/pro: add display setup Dario Binacchi
@ 2023-04-21 15:43 ` Dario Binacchi
2023-04-25 18:11 ` Rob Herring
2023-04-21 15:43 ` [PATCH 6/7] dt-bindings: ili9805: add compatible string for Tianma TM041XDHG01 Dario Binacchi
3 siblings, 1 reply; 8+ messages in thread
From: Dario Binacchi @ 2023-04-21 15:43 UTC (permalink / raw)
To: linux-kernel
Cc: michael, Amarula patchwork, Dario Binacchi, Daniel Vetter,
David Airlie, Krzysztof Kozlowski, Rob Herring, Sam Ravnborg,
Thierry Reding, devicetree, dri-devel
From: Michael Trimarchi <michael@amarulasolutions.com>
Add documentation for "ilitek,ili9805" panel.
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
.../display/panel/ilitek,ili9805.yaml | 60 +++++++++++++++++++
1 file changed, 60 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9805.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9805.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9805.yaml
new file mode 100644
index 000000000000..57c36cf22e4a
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9805.yaml
@@ -0,0 +1,60 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/ilitek,ili9805.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Ilitek ILI9805 based MIPI-DSI panels
+
+maintainers:
+ - Michael Trimarchi <michael@amarulasolutions.com>
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - giantplus,gpm1790a0
+ - const: ilitek,ili9805
+
+ avdd-supply: true
+ dvdd-supply: true
+ power-supply: true
+ port: true
+ reg: true
+ reset-gpios: true
+ backlight: true
+
+required:
+ - compatible
+ - avdd-supply
+ - dvdd-supply
+ - reg
+ - reset-gpios
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ panel@0 {
+ compatible = "giantplus,gpm1790a0", "ilitek,ili9805";
+ reg = <0>;
+ power-supply = <®_display>;
+ avdd-supply = <&avdd_display>;
+ dvdd-supply = <&dvdd_display>;
+ reset-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL05 */
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&mipi_dsi_out>;
+ };
+ };
+ };
+ };
+
+...
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 4/7] dt-bindings: display: panel: Add Ilitek ili9805 panel controller
2023-04-21 15:43 ` [PATCH 4/7] dt-bindings: display: panel: Add Ilitek ili9805 panel controller Dario Binacchi
@ 2023-04-25 18:11 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2023-04-25 18:11 UTC (permalink / raw)
To: Dario Binacchi
Cc: linux-kernel, michael, Amarula patchwork, Daniel Vetter,
David Airlie, Krzysztof Kozlowski, Sam Ravnborg, Thierry Reding,
devicetree, dri-devel
On Fri, Apr 21, 2023 at 05:43:05PM +0200, Dario Binacchi wrote:
> From: Michael Trimarchi <michael@amarulasolutions.com>
>
> Add documentation for "ilitek,ili9805" panel.
>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
> .../display/panel/ilitek,ili9805.yaml | 60 +++++++++++++++++++
> 1 file changed, 60 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9805.yaml
Same comments on this one.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 6/7] dt-bindings: ili9805: add compatible string for Tianma TM041XDHG01
2023-04-21 15:43 [PATCH 0/7] add displays support for bsh-smm-s2/pro boards Dario Binacchi
` (2 preceding siblings ...)
2023-04-21 15:43 ` [PATCH 4/7] dt-bindings: display: panel: Add Ilitek ili9805 panel controller Dario Binacchi
@ 2023-04-21 15:43 ` Dario Binacchi
3 siblings, 0 replies; 8+ messages in thread
From: Dario Binacchi @ 2023-04-21 15:43 UTC (permalink / raw)
To: linux-kernel
Cc: michael, Amarula patchwork, Dario Binacchi, Daniel Vetter,
David Airlie, Krzysztof Kozlowski, Rob Herring, Sam Ravnborg,
Thierry Reding, devicetree, dri-devel
From: Michael Trimarchi <michael@amarulasolutions.com>
Add Tianma TM041XDHG01 that utilizes an Ilitek ILI9805 controller chip,
so its compatible string should be added to ilitek,ili9805 file.
Add the compatible string for it.
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
.../devicetree/bindings/display/panel/ilitek,ili9805.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9805.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9805.yaml
index 57c36cf22e4a..6065ef5ec385 100644
--- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9805.yaml
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9805.yaml
@@ -14,6 +14,7 @@ properties:
items:
- enum:
- giantplus,gpm1790a0
+ - tianma,tm041xdhg01
- const: ilitek,ili9805
avdd-supply: true
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread