devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Udit Kumar <u-kumar1@ti.com>
Cc: nm@ti.com, vigneshr@ti.com, kristo@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, m-chawdhry@ti.com,
	n-francis@ti.com
Subject: Re: [PATCH 1/5] arm64: dts: ti: k3-j7200: Add general purpose timers
Date: Thu, 27 Apr 2023 11:00:49 +0300	[thread overview]
Message-ID: <20230427080049.GH14287@atomide.com> (raw)
In-Reply-To: <20230426103219.1565266-2-u-kumar1@ti.com>

Hi,

* Udit Kumar <u-kumar1@ti.com> [230426 10:38]:
> There are 20 general purpose timers on j7200 that can be used for things
> like PWM using pwm-omap-dmtimer driver. There are also additional ten
> timers in the MCU domain.
...

> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> index 331b4e482e41..1c09e442b379 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> @@ -34,6 +34,126 @@ k3_reset: reset-controller {
>  		};
>  	};
>  
> +	mcu_timer0: timer@40400000 {
> +		compatible = "ti,am654-timer";
> +		reg = <0x00 0x40400000 0x00 0x400>;
> +		interrupts = <GIC_SPI 816 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&k3_clks 35 1>;
> +		clock-names = "fck";
> +		assigned-clocks = <&k3_clks 35 1>;
> +		assigned-clock-parents = <&k3_clks 35 2>;
> +		power-domains = <&k3_pds 35 TI_SCI_PD_EXCLUSIVE>;
> +		ti,timer-pwm;
> +	};

Oh so also the MCU timers now have interrupts, nice. Can you please check
if what we have in the comments the other SoCs in the dtsi files for MCU
timers not having routable interrupts is correct?

Also, should the MCU timers be still tagged with status = "reserved"?

See the comments in k3-am62-mcu.dtsi for example for both questions.

Regards,

Tony

  reply	other threads:[~2023-04-27  8:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-26 10:32 [PATCH 0/5] arm64: dts: ti: k3-j7200: Add properties and sync with uboot Udit Kumar
2023-04-26 10:32 ` [PATCH 1/5] arm64: dts: ti: k3-j7200: Add general purpose timers Udit Kumar
2023-04-27  8:00   ` Tony Lindgren [this message]
2023-04-27 10:09     ` [EXTERNAL] " Kumar, Udit
2023-04-28  5:49       ` Tony Lindgren
2023-05-31 21:51   ` Nishanth Menon
2023-04-26 10:32 ` [PATCH 2/5] arm64: dts: ti: k3-j7200: Configure pinctrl for timer IO Udit Kumar
2023-04-26 10:32 ` [PATCH 3/5] arm64: dts: ti: k3-j7200: main_pmx0 clean up Udit Kumar
2023-04-26 12:51   ` Nishanth Menon
2023-04-26 14:17     ` Kumar, Udit
2023-04-26 10:32 ` [PATCH 4/5] arm64: dts: ti: k3-j7200: Add uart pin mux in wkup_pmx0 Udit Kumar
2023-04-26 10:32 ` [PATCH 5/5] arm64: dts: ti: k3-j7200: Add bootph-pre-ram for u-boot Udit Kumar
2023-04-26 12:48   ` Nishanth Menon
2023-04-26 14:19     ` Kumar, Udit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230427080049.GH14287@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-chawdhry@ti.com \
    --cc=n-francis@ti.com \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).