From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04EFDC7EE23 for ; Sun, 30 Apr 2023 17:00:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231157AbjD3RAl (ORCPT ); Sun, 30 Apr 2023 13:00:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231153AbjD3RAh (ORCPT ); Sun, 30 Apr 2023 13:00:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6653F3AA0; Sun, 30 Apr 2023 10:00:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0B6D360DF5; Sun, 30 Apr 2023 17:00:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4940C433EF; Sun, 30 Apr 2023 17:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682874014; bh=vMagLB0T24aEnGIYaVLE/dTFO6A15JIDpqUIewEjwd8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BXbo5RN40/Wzdi59ooW090ZAmDKYM1vN4r0hPV4FpE4Bs/eOT+VJPa63xtHZQm2PF LT5ItpNJV/9kRyyWFHPq39Xr3Ss0H85s/twuPjRb2yf28jTtnif0C5VN0Wik2uGXp7 nJa/dNsDsz0PXm0aHv4lN4+eIXyKWWpvvuWlBy3Wiq3OaGderss5xj3kv5/8WTAqcJ tOK6jUl4LHJFHnnZ/t6G5L4jOz4VbRvdpndwnCKXzZfJ4RiHCs94krXVDgU5tFcwvY wf9Ob628bSd4dnrYVD7naMKMK+CSzz4uQWHawJQPJQCoYRgwN3/07kG9qDi1PjbnT8 sVNcaqtw8H+Ww== Date: Sun, 30 Apr 2023 18:15:58 +0100 From: Jonathan Cameron To: Alexander Stein Cc: Cai Huoqing , Haibo Chen , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marco Felsch Subject: Re: [PATCH v2 1/1] dt-bindings: iio: imx8qxp-adc: add missing vref-supply Message-ID: <20230430181558.7614cbfc@jic23-huawei> In-Reply-To: <20230424092312.61746-1-alexander.stein@ew.tq-group.com> References: <20230424092312.61746-1-alexander.stein@ew.tq-group.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 24 Apr 2023 11:23:12 +0200 Alexander Stein wrote: > Although this property is used right now for IIO_CHAN_INFO_SCALE, > this ADC has two internal reference voltages, which the driver currently > doesn't make use of. > > Fixes: db73419d8c06 ("dt-bindings: iio: adc: Add binding documentation for NXP IMX8QXP ADC") > Signed-off-by: Alexander Stein Interesting that we are talking her only about vrefh, what about vrefp? I guess the assumption is that will be wired to 0V? The first reference I found didn't seem to imply that was necessarily the case. https://www.mouser.com/pdfDocs/IMX8QXPAEC.pdf Jonathan > --- > Thanks for your inputs. This improved descritpion should make it clear > that this property is only about the external reference voltage, not > about the optional, internal voltages. > > Changes in v2: > * Improved commit message subject as suggested > * Add hint about feature flag regarding multiple, internal, reference > voltages > > .../devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > index 63369ba388e4..878e67054d7c 100644 > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > @@ -39,6 +39,12 @@ properties: > power-domains: > maxItems: 1 > > + vref-supply: > + description: | > + External ADC reference voltage supply on VREFH pad. If VERID[MVI] is > + set, there are additional, internal reference voltages selectable. > + VREFH1 is always from VREFH pad. > + > "#io-channel-cells": > const: 1 > > @@ -72,6 +78,7 @@ examples: > assigned-clocks = <&clk IMX_SC_R_ADC_0>; > assigned-clock-rates = <24000000>; > power-domains = <&pd IMX_SC_R_ADC_0>; > + vref-supply = <®_1v8>; > #io-channel-cells = <1>; > }; > };