From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: <agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <amitk@kernel.org>,
<thara.gopinath@gmail.com>, <rafael@kernel.org>,
<daniel.lezcano@linaro.org>, <rui.zhang@intel.com>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Praveenkumar I <quic_ipkumar@quicinc.com>
Subject: Re: [PATCH 4/4] arm64: dts: qcom: ipq9574: add thermal zone nodes
Date: Tue, 2 May 2023 13:34:41 +0530 [thread overview]
Message-ID: <20230502080440.GA26126@varda-linux.qualcomm.com> (raw)
In-Reply-To: <CAA8EJpq0RXGf8_oBa_XF0+nOg31ouMUVJ3LhNRh_HtmgJvCJHQ@mail.gmail.com>
On Fri, Apr 28, 2023 at 10:49:34PM +0300, Dmitry Baryshkov wrote:
> On Fri, 28 Apr 2023 at 17:53, Varadarajan Narayanan
> <quic_varada@quicinc.com> wrote:
> >
> > This patch adds thermal zone nodes for the various
> > sensors present in IPQ9574
> >
> > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> > ---
> > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 208 ++++++++++++++++++++++++++++++++++
> > 1 file changed, 208 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> > index 7cd5bdb..a7cb2b4c 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> > @@ -947,6 +947,214 @@
> > };
> > };
> >
> > + thermal_zones: thermal-zones {
> > + tsens_tz_sensor3 {
>
> Please provide sensible names for all thermal zones. Please follow the
> examples in other DT files.
Ok.
> > + polling-delay-passive = <0>;
> > + polling-delay = <0>;
> > + thermal-sensors = <&tsens 3>;
> > +
> > + trips {
> > + cpu-critical {
> > + temperature = <125000>;
>
> Can it really go up to 125 °C?
The SoC product requirement is 120°C. It is capable of 125°C.
This was tested inside a thermal chamber and ensured that it
hits 125°C and system reboots at that temperature.
> > + hysteresis = <1000>;
> > + type = "critical";
> > + };
>
> Please provide also a passive trip point, so that the passive cooling
> can be engaged.
The linux kernel cannot take any steps to initiate cooling for
components other than the 4 CPU cores. The f/w that runs on these
IP blocks have to take steps to initiate cooling. Additionally,
the passive temperature for the non-cpu sensors are not
characterised yet and I don't have the values now.
We have these nodes to be able to read the temperature of the
other blocks via the sysfs entry /sys/devices/virtual/thermal/*/temp
Have given the critical trip point so that the setup is rebooted
if the critical temperature is reached.
Have given passive trip point for the CPU core related thermal
nodes (tsens_tz_sensor10, tsens_tz_sensor11, tsens_tz_sensor12
and tsens_tz_sensor13).
If this is not acceptable, please let me know. Will remove the
non-cpu nodes and post a patch with just the CPU entries.
Thanks
Varada
> > + };
> > + };
> > +
> > + tsens_tz_sensor4 {
> > + polling-delay-passive = <0>;
> > + polling-delay = <0>;
> > + thermal-sensors = <&tsens 4>;
> > +
> > + trips {
> > + cpu-critical {
> > + temperature = <125000>;
> > + hysteresis = <1000>;
> > + type = "critical";
> > + };
> > + };
> > + };
> > +
> > + tsens_tz_sensor5 {
> > + polling-delay-passive = <0>;
> > + polling-delay = <0>;
> > + thermal-sensors = <&tsens 5>;
> > +
> > + trips {
> > + cpu-critical {
> > + temperature = <125000>;
> > + hysteresis = <1000>;
> > + type = "critical";
> > + };
> > + };
> > + };
> > +
> > + tsens_tz_sensor6 {
> > + polling-delay-passive = <0>;
> > + polling-delay = <0>;
> > + thermal-sensors = <&tsens 6>;
> > +
> > + trips {
> > + cpu-critical {
> > + temperature = <125000>;
> > + hysteresis = <1000>;
> > + type = "critical";
> > + };
> > + };
> > + };
> > +
> > + tsens_tz_sensor7 {
> > + polling-delay-passive = <0>;
> > + polling-delay = <0>;
> > + thermal-sensors = <&tsens 7>;
> > +
> > + trips {
> > + cpu-critical {
> > + temperature = <125000>;
> > + hysteresis = <1000>;
> > + type = "critical";
> > + };
> > + };
> > + };
> > +
> > + tsens_tz_sensor8 {
> > + polling-delay-passive = <0>;
> > + polling-delay = <0>;
> > + thermal-sensors = <&tsens 8>;
> > +
> > + trips {
> > + cpu-critical {
> > + temperature = <125000>;
> > + hysteresis = <1000>;
> > + type = "critical";
> > + };
> > + };
> > + };
> > +
> > + tsens_tz_sensor9 {
> > + polling-delay-passive = <0>;
> > + polling-delay = <0>;
> > + thermal-sensors = <&tsens 9>;
> > +
> > + trips {
> > + cpu-critical {
> > + temperature = <125000>;
> > + hysteresis = <1000>;
> > + type = "critical";
> > + };
> > + };
> > + };
> > +
> > + tsens_tz_sensor10 {
> > + polling-delay-passive = <0>;
> > + polling-delay = <0>;
> > + thermal-sensors = <&tsens 10>;
> > +
> > + trips {
> > + cpu-critical {
> > + temperature = <120000>;
> > + hysteresis = <10000>;
> > + type = "critical";
> > + };
> > +
> > + cpu-passive {
> > + temperature = <110000>;
> > + hysteresis = <1000>;
> > + type = "passive";
> > + };
> > + };
> > + };
> > +
> > + tsens_tz_sensor11 {
> > + polling-delay-passive = <0>;
> > + polling-delay = <0>;
> > + thermal-sensors = <&tsens 11>;
> > +
> > + trips {
> > + cpu-critical {
> > + temperature = <120000>;
> > + hysteresis = <10000>;
> > + type = "critical";
> > + };
> > +
> > + cpu-passive {
> > + temperature = <110000>;
> > + hysteresis = <1000>;
> > + type = "passive";
> > + };
> > + };
> > + };
> > +
> > + tsens_tz_sensor12 {
> > + polling-delay-passive = <0>;
> > + polling-delay = <0>;
> > + thermal-sensors = <&tsens 12>;
> > +
> > + trips {
> > + cpu-critical {
> > + temperature = <120000>;
> > + hysteresis = <10000>;
> > + type = "critical";
> > + };
> > +
> > + cpu-passive {
> > + temperature = <110000>;
> > + hysteresis = <1000>;
> > + type = "passive";
> > + };
> > + };
> > + };
> > +
> > + tsens_tz_sensor13 {
> > + polling-delay-passive = <0>;
> > + polling-delay = <0>;
> > + thermal-sensors = <&tsens 13>;
> > +
> > + trips {
> > + cpu-critical {
> > + temperature = <120000>;
> > + hysteresis = <10000>;
> > + type = "critical";
> > + };
> > +
> > + cpu-passive {
> > + temperature = <110000>;
> > + hysteresis = <1000>;
> > + type = "passive";
> > + };
> > + };
> > + };
> > +
> > + tsens_tz_sensor14 {
> > + polling-delay-passive = <0>;
> > + polling-delay = <0>;
> > + thermal-sensors = <&tsens 14>;
> > +
> > + trips {
> > + cpu-critical {
> > + temperature = <125000>;
> > + hysteresis = <1000>;
> > + type = "critical";
> > + };
> > + };
> > + };
> > +
> > + tsens_tz_sensor15 {
> > + polling-delay-passive = <0>;
> > + polling-delay = <0>;
> > + thermal-sensors = <&tsens 15>;
> > +
> > + trips {
> > + cpu-critical {
> > + temperature = <125000>;
> > + hysteresis = <1000>;
> > + type = "critical";
> > + };
> > + };
> > + };
> > + };
> > +
> > timer {
> > compatible = "arm,armv8-timer";
> > interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
> > --
> > 2.7.4
> >
>
>
> --
> With best wishes
> Dmitry
next prev parent reply other threads:[~2023-05-02 8:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 14:52 [PATCH 0/4] Enable IPQ9574 TSENS support Varadarajan Narayanan
2023-04-28 14:52 ` [PATCH 1/4] dt-bindings: thermal: tsens: Add ipq9574 compatible Varadarajan Narayanan
2023-05-01 7:08 ` Krzysztof Kozlowski
2023-05-03 7:10 ` Varadarajan Narayanan
2023-05-03 7:42 ` Krzysztof Kozlowski
2023-05-04 4:57 ` Varadarajan Narayanan
2023-05-04 6:22 ` Krzysztof Kozlowski
2023-05-05 10:18 ` Varadarajan Narayanan
2023-04-28 14:52 ` [PATCH 2/4] thermal/drivers/tsens: Add IPQ9574 support Varadarajan Narayanan
2023-04-28 14:52 ` [PATCH 3/4] arm64: dts: qcom: ipq9574: add tsens node Varadarajan Narayanan
2023-04-28 14:52 ` [PATCH 4/4] arm64: dts: qcom: ipq9574: add thermal zone nodes Varadarajan Narayanan
2023-04-28 19:49 ` Dmitry Baryshkov
2023-05-02 8:04 ` Varadarajan Narayanan [this message]
2023-05-02 8:39 ` Dmitry Baryshkov
2023-05-01 7:14 ` Krzysztof Kozlowski
2023-05-02 8:06 ` Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230502080440.GA26126@varda-linux.qualcomm.com \
--to=quic_varada@quicinc.com \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_ipkumar@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).