From: Tony Lindgren <tony@atomide.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Julien Panis <jpanis@baylibre.com>,
arnd@arndb.de, olof@lixom.net, soc@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] arm: dts: Add am335x-boneblack-pps.dts
Date: Wed, 3 May 2023 09:07:39 +0300 [thread overview]
Message-ID: <20230503060739.GM14287@atomide.com> (raw)
In-Reply-To: <8e1ee169-603f-4aa4-9f02-68520d708d57@linaro.org>
Hi,
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [230428 13:50]:
> On 28/04/2023 12:54, Julien Panis wrote:
> > From: Lokesh Vutla <lokeshvutla@ti.com>
> > + compatible = "ti,omap-dmtimer-pwm";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pwm7_pins>;
> > + #pwm-cells = <3>;
> > + ti,timers = <&timer7>;
> > + ti,clock-source = <0x00>; /* timer_sys_ck */
>
> Why this is hex? Should be just 0/1/2?
I think the ti,clock-source can be left out now, this can be done
with assigned-clocks and parents instead. Please grep for some
examples in the current mainline kernel dts files.
Regards,
Tony
next prev parent reply other threads:[~2023-05-03 6:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 10:54 [PATCH] arm: dts: Add am335x-boneblack-pps.dts Julien Panis
2023-04-28 13:50 ` Krzysztof Kozlowski
2023-05-03 6:07 ` Tony Lindgren [this message]
2023-04-28 14:44 ` Robert Nelson
2023-04-28 20:53 ` Robert Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230503060739.GM14287@atomide.com \
--to=tony@atomide.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jpanis@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).