Re: [PATCH] dt-bindings: misc: brcm,kona-smc: convert to YAML

Krzysztof Kozlowski
2023-05-05T06:50:02Z

On 04/05/2023 21:02, Stanislav Jakubek wrote:
> Convert Broadcom Kona family Secure Monitor bounce buffer bindings
> to DT schema.
>
> Change during conversion:
> - add used, but previously undocumented SoC-specific compatibles
>
> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
> ---
> .../bindings/misc/brcm,kona-smc.txt | 15 -------
> .../bindings/misc/brcm,kona-smc.yaml | 44 +++++++++++++++++++

Please put SMC stuff in firmware subdirectory.

> 2 files changed, 44 insertions(+), 15 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/misc/brcm,kona-smc.txt
> create mode 100644 Documentation/devicetree/bindings/misc/brcm,kona-smc.yaml
>
> diff --git a/Documentation/devicetree/bindings/misc/brcm,kona-smc.txt b/Documentation/devicetree/bindings/misc/brcm,kona-smc.txt
> deleted file mode 100644
> index 05b47232ed9e..000000000000
> --- a/Documentation/devicetree/bindings/misc/brcm,kona-smc.txt
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -Broadcom Secure Monitor Bounce buffer
> ------------------------------------------------------
> -This binding defines the location of the bounce buffer
> -used for non-secure to secure communications.
> -
> -Required properties:
> -- compatible : "brcm,kona-smc"
> -- DEPRECATED: compatible : "bcm,kona-smc"
> -- reg : Location and size of bounce buffer
> -
> -Example:
> - smc@3404c000 {
> - compatible = "brcm,bcm11351-smc", "brcm,kona-smc";
> - reg = <0x3404c000 0x400>; //1 KiB in SRAM
> - };
> diff --git a/Documentation/devicetree/bindings/misc/brcm,kona-smc.yaml b/Documentation/devicetree/bindings/misc/brcm,kona-smc.yaml
> new file mode 100644
> index 000000000000..ba0312a20083
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/brcm,kona-smc.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/misc/brcm,kona-smc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom Kona family Secure Monitor bounce buffer
> +
> +description:
> + A bounce buffer used for non-secure to secure communications.
> +
> +maintainers:
> + - Florian Fainelli <f.fainelli@gmail.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - brcm,bcm11351-smc
> + - brcm,bcm21664-smc
> + - brcm,bcm23550-smc
> + - const: brcm,kona-smc
> + - items:
> + - const: bcm,bcm11351-smc
> + - const: bcm,kona-smc
> + deprecated: true

That's not correct. You deprecate the same set as you allow before. I
think you wanted to deprecated kona-smc alone.

> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg

Best regards,
Krzysztof