Re: [PATCH] dt-bindings: misc: brcm,kona-smc: convert to YAML

Krzysztof Kozlowski
2023-05-05T10:36:45Z

On 05/05/2023 09:18, Stanislav Jakubek wrote:

>>> + - items:
>>> + - enum:
>>> + - brcm,bcm11351-smc
>>> + - brcm,bcm21664-smc
>>> + - brcm,bcm23550-smc
>>> + - const: brcm,kona-smc
>>> + - items:
>>> + - const: bcm,bcm11351-smc
>>> + - const: bcm,kona-smc
>>> + deprecated: true
>>
>> That's not correct. You deprecate the same set as you allow before. I
>> think you wanted to deprecated kona-smc alone.
>
> What I'm trying to do here is to deprecate both compatibles with the
> "bcm" vendor prefix, as these were initially introduced in [1]. bcm11351 is the
> only one that ever had the "bcm" prefix, both bcm21664 [2] and bcm23550 [3]
> were introduced with the "brcm" prefix (though they were never documented).
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=7f6c62e2695bcb1547afdeb4ad3bcdf8c610be2c
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=2eba905e860f8aed5f2743b45259bb2e92548a55
> [3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=fcd4138653f049c8fa45b48dc5f2806ced68e304

Ah, right, I missed the difference in prefix. I propose to just drop it.
It was deprecated 10 years ago!

Best regards,
Krzysztof