* [PATCH v2 1/2] dt-bindings: display: novatek,nt35950: define ports
@ 2023-05-02 12:00 Krzysztof Kozlowski
2023-05-02 12:00 ` [PATCH v2 2/2] dt-bindings: display: novatek,nt36523: " Krzysztof Kozlowski
2023-05-05 21:45 ` [PATCH v2 1/2] dt-bindings: display: novatek,nt35950: " Rob Herring
0 siblings, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-02 12:00 UTC (permalink / raw)
To: Neil Armstrong, Sam Ravnborg, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Jianhua Lu, Del Regno,
dri-devel, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The panel-common schema does not define what "ports" property is, so
bring the definition to enforce the type. Panels can be single- or
dual-link, thus require only one port@0.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v1:
1. Rework to add ports to device schema, not to panel-common.
https://lore.kernel.org/all/20230420160905.GA2952736-robh@kernel.org/
---
.../bindings/display/panel/novatek,nt35950.yaml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml
index 377a05d48a02..c93cc1018b41 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml
@@ -47,8 +47,13 @@ properties:
vddio-supply:
description: regulator that supplies the I/O voltage
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ required:
+ - port@0
+
backlight: true
- ports: true
reg: true
required:
@@ -59,6 +64,7 @@ required:
- avee-supply
- dvdd-supply
- vddio-supply
+ - ports
additionalProperties: false
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 2/2] dt-bindings: display: novatek,nt36523: define ports
2023-05-02 12:00 [PATCH v2 1/2] dt-bindings: display: novatek,nt35950: define ports Krzysztof Kozlowski
@ 2023-05-02 12:00 ` Krzysztof Kozlowski
2023-05-02 12:44 ` Jianhua Lu
2023-05-05 21:43 ` Rob Herring
2023-05-05 21:45 ` [PATCH v2 1/2] dt-bindings: display: novatek,nt35950: " Rob Herring
1 sibling, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-02 12:00 UTC (permalink / raw)
To: Neil Armstrong, Sam Ravnborg, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Jianhua Lu, Del Regno,
dri-devel, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The panel-common schema does not define what "ports" property is, so
bring the definition to enforce the type. All panels described by
binding are dual-link, thus require both ports.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v1:
1. Rework to add ports to device schema, not to panel-common.
https://lore.kernel.org/all/20230420160905.GA2952736-robh@kernel.org/
---
.../bindings/display/panel/novatek,nt36523.yaml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
index 0039561ef04c..a2a8c4e39573 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
@@ -32,8 +32,14 @@ properties:
vddio-supply:
description: regulator that supplies the I/O voltage
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ required:
+ - port@0
+ - port@1
+
reg: true
- ports: true
backlight: true
required:
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2 2/2] dt-bindings: display: novatek,nt36523: define ports
2023-05-02 12:00 ` [PATCH v2 2/2] dt-bindings: display: novatek,nt36523: " Krzysztof Kozlowski
@ 2023-05-02 12:44 ` Jianhua Lu
2023-05-02 13:08 ` Krzysztof Kozlowski
2023-05-05 21:43 ` Rob Herring
1 sibling, 1 reply; 6+ messages in thread
From: Jianhua Lu @ 2023-05-02 12:44 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Neil Armstrong, Sam Ravnborg, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Del Regno, dri-devel,
devicetree, linux-kernel
On Tue, May 02, 2023 at 02:00:36PM +0200, Krzysztof Kozlowski wrote:
> description: regulator that supplies the I/O voltage
[..]
>
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + required:
> + - port@0
> + - port@1
Konrad has added a single DSI panel to this bindings, so we should
drop port@1 to allow it.
See https://lore.kernel.org/lkml/20230412-topic-lenovopanel-v3-1-bcf9ba4de46f@linaro.org/
> +
> reg: true
> - ports: true
> backlight: true
>
> required:
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: display: novatek,nt36523: define ports
2023-05-02 12:44 ` Jianhua Lu
@ 2023-05-02 13:08 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-02 13:08 UTC (permalink / raw)
To: Jianhua Lu
Cc: Neil Armstrong, Sam Ravnborg, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Del Regno, dri-devel,
devicetree, linux-kernel
On 02/05/2023 14:44, Jianhua Lu wrote:
> On Tue, May 02, 2023 at 02:00:36PM +0200, Krzysztof Kozlowski wrote:
>> description: regulator that supplies the I/O voltage
> [..]
>>
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
>> + required:
>> + - port@0
>> + - port@1
> Konrad has added a single DSI panel to this bindings, so we should
> drop port@1 to allow it.
>
> See https://lore.kernel.org/lkml/20230412-topic-lenovopanel-v3-1-bcf9ba4de46f@linaro.org/
Thanks, I'll send a v2 ~tomorrow.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: display: novatek,nt36523: define ports
2023-05-02 12:00 ` [PATCH v2 2/2] dt-bindings: display: novatek,nt36523: " Krzysztof Kozlowski
2023-05-02 12:44 ` Jianhua Lu
@ 2023-05-05 21:43 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-05-05 21:43 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Neil Armstrong, Sam Ravnborg, David Airlie, Daniel Vetter,
Krzysztof Kozlowski, Jianhua Lu, Del Regno, dri-devel, devicetree,
linux-kernel
On Tue, May 02, 2023 at 02:00:36PM +0200, Krzysztof Kozlowski wrote:
> The panel-common schema does not define what "ports" property is, so
> bring the definition to enforce the type. All panels described by
> binding are dual-link, thus require both ports.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Changes since v1:
> 1. Rework to add ports to device schema, not to panel-common.
> https://lore.kernel.org/all/20230420160905.GA2952736-robh@kernel.org/
> ---
> .../bindings/display/panel/novatek,nt36523.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> index 0039561ef04c..a2a8c4e39573 100644
> --- a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> @@ -32,8 +32,14 @@ properties:
> vddio-supply:
> description: regulator that supplies the I/O voltage
>
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + required:
> + - port@0
> + - port@1
What is each port?
You need:
additionalProperties: false
properties:
port@0:
$ref: ...
description: ...
port@1:
$ref: ...
description: ...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: display: novatek,nt35950: define ports
2023-05-02 12:00 [PATCH v2 1/2] dt-bindings: display: novatek,nt35950: define ports Krzysztof Kozlowski
2023-05-02 12:00 ` [PATCH v2 2/2] dt-bindings: display: novatek,nt36523: " Krzysztof Kozlowski
@ 2023-05-05 21:45 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-05-05 21:45 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Neil Armstrong, Sam Ravnborg, David Airlie, Daniel Vetter,
Krzysztof Kozlowski, Jianhua Lu, Del Regno, dri-devel, devicetree,
linux-kernel
On Tue, May 02, 2023 at 02:00:35PM +0200, Krzysztof Kozlowski wrote:
> The panel-common schema does not define what "ports" property is, so
> bring the definition to enforce the type. Panels can be single- or
> dual-link, thus require only one port@0.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Changes since v1:
> 1. Rework to add ports to device schema, not to panel-common.
> https://lore.kernel.org/all/20230420160905.GA2952736-robh@kernel.org/
> ---
> .../bindings/display/panel/novatek,nt35950.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml
> index 377a05d48a02..c93cc1018b41 100644
> --- a/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml
> @@ -47,8 +47,13 @@ properties:
> vddio-supply:
> description: regulator that supplies the I/O voltage
>
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
Similarly needed on this one.
Perhaps what you want here is a dual-link panel schema?
> +
> + required:
> + - port@0
> +
> backlight: true
> - ports: true
> reg: true
>
> required:
> @@ -59,6 +64,7 @@ required:
> - avee-supply
> - dvdd-supply
> - vddio-supply
> + - ports
>
> additionalProperties: false
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-05 21:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-02 12:00 [PATCH v2 1/2] dt-bindings: display: novatek,nt35950: define ports Krzysztof Kozlowski
2023-05-02 12:00 ` [PATCH v2 2/2] dt-bindings: display: novatek,nt36523: " Krzysztof Kozlowski
2023-05-02 12:44 ` Jianhua Lu
2023-05-02 13:08 ` Krzysztof Kozlowski
2023-05-05 21:43 ` Rob Herring
2023-05-05 21:45 ` [PATCH v2 1/2] dt-bindings: display: novatek,nt35950: " Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).