From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
freedreno@lists.freedesktop.org
Subject: [PATCH 3/3] drm/bridge: display-connector: handle hdmi-pwr supply
Date: Sun, 7 May 2023 23:12:18 +0300 [thread overview]
Message-ID: <20230507201218.2339014-4-dmitry.baryshkov@linaro.org> (raw)
In-Reply-To: <20230507201218.2339014-1-dmitry.baryshkov@linaro.org>
On some devices the 5V pin of the HDMI connector and/or the ESD
protection logic is powered on by a separate regulator. Instead of
declaring this regulator as always-on, make hdmi-connector support the
additional hdmi-pwr supply.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/gpu/drm/bridge/display-connector.c | 37 +++++++++++++++++-----
1 file changed, 29 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c
index 0d94e6edea50..037ba2eb5a2f 100644
--- a/drivers/gpu/drm/bridge/display-connector.c
+++ b/drivers/gpu/drm/bridge/display-connector.c
@@ -337,18 +337,12 @@ static int display_connector_probe(struct platform_device *pdev)
return ret;
}
}
-
- if (conn->connector_pwr) {
- ret = regulator_enable(conn->connector_pwr);
- if (ret) {
- dev_err(&pdev->dev, "failed to enable DP PWR regulator: %d\n", ret);
- return ret;
- }
- }
}
/* enable DDC */
if (type == DRM_MODE_CONNECTOR_HDMIA) {
+ int ret;
+
conn->ddc_en = devm_gpiod_get_optional(&pdev->dev, "ddc-en",
GPIOD_OUT_HIGH);
@@ -356,6 +350,33 @@ static int display_connector_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "Couldn't get ddc-en gpio\n");
return PTR_ERR(conn->ddc_en);
}
+
+ conn->connector_pwr = devm_regulator_get_optional(&pdev->dev, "hdmi-pwr");
+
+ if (IS_ERR(conn->connector_pwr)) {
+ ret = PTR_ERR(conn->connector_pwr);
+
+ switch (ret) {
+ case -ENODEV:
+ conn->connector_pwr = NULL;
+ break;
+
+ case -EPROBE_DEFER:
+ return -EPROBE_DEFER;
+
+ default:
+ dev_err(&pdev->dev, "failed to get HDMI PWR regulator: %d\n", ret);
+ return ret;
+ }
+ }
+ }
+
+ if (conn->connector_pwr) {
+ ret = regulator_enable(conn->connector_pwr);
+ if (ret) {
+ dev_err(&pdev->dev, "failed to enable DP PWR regulator: %d\n", ret);
+ return ret;
+ }
}
conn->bridge.funcs = &display_connector_bridge_funcs;
--
2.39.2
next prev parent reply other threads:[~2023-05-07 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-07 20:12 [PATCH 0/3] drm/bridge: display-connector: add external supply support Dmitry Baryshkov
2023-05-07 20:12 ` [PATCH 1/3] dt-bindings: display: hdmi-connector: add hdmi-pwr supply Dmitry Baryshkov
2023-05-07 21:25 ` Rob Herring
2023-05-08 2:56 ` Laurent Pinchart
2023-05-09 17:27 ` Krzysztof Kozlowski
2023-05-08 3:00 ` Laurent Pinchart
2023-05-09 17:27 ` Krzysztof Kozlowski
2023-05-07 20:12 ` [PATCH 2/3] drm/bridge: display-connector: rename dp_pwr to connector_pwr Dmitry Baryshkov
2023-05-08 2:51 ` Laurent Pinchart
2023-05-07 20:12 ` Dmitry Baryshkov [this message]
2023-05-08 2:54 ` [PATCH 3/3] drm/bridge: display-connector: handle hdmi-pwr supply Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230507201218.2339014-4-dmitry.baryshkov@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).