* [PATCH] dt-bindings: power: reset: qcom-pon: Only allow reboot-mode pre-pmk8350
@ 2023-04-19 10:41 Konrad Dybcio
2023-04-21 19:07 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Konrad Dybcio @ 2023-04-19 10:41 UTC (permalink / raw)
To: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, Vinod Koul,
Anjelique Melendez, David Collins
Cc: Marijn Suijten, Sebastian Reichel, Krzysztof Kozlowski, linux-pm,
devicetree, linux-kernel, Konrad Dybcio
As pointed out by Shazad [1], PMICs using a separate HLOS+PBS scheme
(so PMK8350 and newer) are expected to pass reboot mode data through SDAM,
as the reboot mode registers are absent in the HLOS reg space.
Limit the reboot-mode.yaml inclusion to PMICs without a separate PBS
region.
[1] https://lore.kernel.org/linux-arm-msm/12f13183-c381-25f7-459e-62e0c2b19498@quicinc.com/
Fixes: 03fccdc76dce ("dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon"")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
index d96170eecbd2..0b1eca734d3b 100644
--- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
+++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
@@ -56,7 +56,6 @@ required:
unevaluatedProperties: false
allOf:
- - $ref: reboot-mode.yaml#
- if:
properties:
compatible:
@@ -66,6 +65,9 @@ allOf:
- qcom,pms405-pon
- qcom,pm8998-pon
then:
+ allOf:
+ - $ref: reboot-mode.yaml#
+
properties:
reg:
maxItems: 1
---
base-commit: 67d5d9f013d6c3829383c08162939cabff14fccc
change-id: 20230419-topic-pmic_pon_bindings-ffdd6c088f8e
Best regards,
--
Konrad Dybcio <konrad.dybcio@linaro.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: power: reset: qcom-pon: Only allow reboot-mode pre-pmk8350
2023-04-19 10:41 [PATCH] dt-bindings: power: reset: qcom-pon: Only allow reboot-mode pre-pmk8350 Konrad Dybcio
@ 2023-04-21 19:07 ` Rob Herring
2023-05-08 12:29 ` Sebastian Reichel
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2023-04-21 19:07 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Anjelique Melendez, David Collins, Krzysztof Kozlowski,
devicetree, Krzysztof Kozlowski, linux-pm, linux-kernel,
Rob Herring, Sebastian Reichel, Vinod Koul, Marijn Suijten,
Sebastian Reichel
On Wed, 19 Apr 2023 12:41:06 +0200, Konrad Dybcio wrote:
> As pointed out by Shazad [1], PMICs using a separate HLOS+PBS scheme
> (so PMK8350 and newer) are expected to pass reboot mode data through SDAM,
> as the reboot mode registers are absent in the HLOS reg space.
>
> Limit the reboot-mode.yaml inclusion to PMICs without a separate PBS
> region.
>
> [1] https://lore.kernel.org/linux-arm-msm/12f13183-c381-25f7-459e-62e0c2b19498@quicinc.com/
>
> Fixes: 03fccdc76dce ("dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon"")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: power: reset: qcom-pon: Only allow reboot-mode pre-pmk8350
2023-04-21 19:07 ` Rob Herring
@ 2023-05-08 12:29 ` Sebastian Reichel
0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2023-05-08 12:29 UTC (permalink / raw)
To: Rob Herring
Cc: Konrad Dybcio, Anjelique Melendez, David Collins,
Krzysztof Kozlowski, devicetree, Krzysztof Kozlowski, linux-pm,
linux-kernel, Rob Herring, Vinod Koul, Marijn Suijten
[-- Attachment #1: Type: text/plain, Size: 937 bytes --]
Hi,
On Fri, Apr 21, 2023 at 02:07:11PM -0500, Rob Herring wrote:
> On Wed, 19 Apr 2023 12:41:06 +0200, Konrad Dybcio wrote:
> > As pointed out by Shazad [1], PMICs using a separate HLOS+PBS scheme
> > (so PMK8350 and newer) are expected to pass reboot mode data through SDAM,
> > as the reboot mode registers are absent in the HLOS reg space.
> >
> > Limit the reboot-mode.yaml inclusion to PMICs without a separate PBS
> > region.
> >
> > [1] https://lore.kernel.org/linux-arm-msm/12f13183-c381-25f7-459e-62e0c2b19498@quicinc.com/
> >
> > Fixes: 03fccdc76dce ("dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon"")
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> > ---
> > Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Acked-by: Rob Herring <robh@kernel.org>
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-08 16:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-19 10:41 [PATCH] dt-bindings: power: reset: qcom-pon: Only allow reboot-mode pre-pmk8350 Konrad Dybcio
2023-04-21 19:07 ` Rob Herring
2023-05-08 12:29 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).