From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DC9FC7EE22 for ; Wed, 10 May 2023 16:40:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230023AbjEJQkG (ORCPT ); Wed, 10 May 2023 12:40:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbjEJQkF (ORCPT ); Wed, 10 May 2023 12:40:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 581EFE4C; Wed, 10 May 2023 09:40:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DCECF639C1; Wed, 10 May 2023 16:40:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83420C433EF; Wed, 10 May 2023 16:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683736803; bh=iIjY05MJDxb4YGVapwMatlpjavNhv7TxmUelXD6rsYc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OdtjRXXdH1PuvJW5JHcdNukjpnpFkoykoEVj+JxYdhzHsv2mFkwCutsPYcfntDCZK yNqHh4uLUtxmUgTIDIIwSqEFsIPT38NAthMI270nisStniq2/cZ+Ebp1YSkNcrmv9w U6uVYh4ahbufC0Dgjaer1w94z0FrwiPGn1Vh0po+ecQIujHcwUEyr9AfgB+Lyb3kVZ 2i37Biuod1HpqX1IrB0MKbPKPejH+Uh8jw7k98T34GYvaKc4hyJdLqHWBZuHy1n4bJ nKCSas+jhWkTqkTmm6WxLMea2ZPjT7/MUrkIooVlV5ufQxWIja1E2UgIYpdQzPVhzP 8784VUdWgVFkQ== Date: Wed, 10 May 2023 17:39:59 +0100 From: Conor Dooley To: Aidan MacDonald Cc: lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, wens@csie.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] dt-bindings: mfd: add bindings for AXP192 MFD device Message-ID: <20230510-rage-amazingly-d090d1e838f0@spud> References: <20230510151542.312588-1-aidanmacdonald.0x0@gmail.com> <20230510151542.312588-2-aidanmacdonald.0x0@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QLYvXStqnogFz2C7" Content-Disposition: inline In-Reply-To: <20230510151542.312588-2-aidanmacdonald.0x0@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --QLYvXStqnogFz2C7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 10, 2023 at 04:15:42PM +0100, Aidan MacDonald wrote: > The AXP192 is another X-Powers PMIC similar to the existing ones. In the driver patch the commit message says: | The AXP192 PMIC is similar to the AXP202/AXP209, but with different | regulators, additional GPIOs, and a different IRQ register layout. That'd be nice to have in the commit message here too, to explain why you're adding to the enum rather than listing a fallback. Otherwise, Acked-by: Conor Dooley Thanks, Conor. >=20 > Signed-off-by: Aidan MacDonald > --- > Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b= /Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > index f7f0f2c0421a..9ad55746133b 100644 > --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > @@ -90,6 +90,7 @@ properties: > oneOf: > - enum: > - x-powers,axp152 > + - x-powers,axp192 > - x-powers,axp202 > - x-powers,axp209 > - x-powers,axp221 > --=20 > 2.39.2 >=20 --QLYvXStqnogFz2C7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZFvI3gAKCRB4tDGHoIJi 0n8PAP9fNkh8u2UdkP4PFZmusgp4d0W3u+5Xyt6N4s1FbPVBKwEAu748aE6aAPZ+ 71lHhWp4o3bXDXC5SDGJWLBnAUBReQQ= =rCPv -----END PGP SIGNATURE----- --QLYvXStqnogFz2C7--