From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8871C7EE2D for ; Thu, 11 May 2023 16:30:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238879AbjEKQan (ORCPT ); Thu, 11 May 2023 12:30:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238931AbjEKQaW (ORCPT ); Thu, 11 May 2023 12:30:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDB2519B7; Thu, 11 May 2023 09:30:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6D9D060DE1; Thu, 11 May 2023 16:30:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB9F5C433EF; Thu, 11 May 2023 16:30:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683822615; bh=Zs6HS+LhQsL65kXS1dDBGurrU/0i4pxZb2uUlUCbWFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ngk3IDFvzbk44ahJBMRCL7/6ykr6qw1ibcNGNb8wKaN7/5TtT9RPwrw+1Rc1KnFKQ IDS3saOhr3E+OZ9r953ZCBbtF01MM1+w8j07vqaL8SyRGxC6/ZW8GaL7ftZzISmKKf qYO49B0k+ukEgB97k/z1o1EVqZHXeOdRqGy3FJO83XNNn0l4cBEiK4PDEB8a2D8ME0 DC4BTHewwmy8ZwEVQyBFdTTlBTt0gZtkdGwpa/bJc6aMi5ETQ2kYRSyLrzChlY1fPN oqqBrt8UHg68Nca/Y014wk1mL1qWo+YMNS+nErNX6C2ht3xySw/Zy9JDLj5bgMQzfN xnAuaNfUtNstA== Date: Thu, 11 May 2023 09:33:52 -0700 From: Bjorn Andersson To: Rohit Agarwal Cc: agross@kernel.org, konrad.dybcio@linaro.org, linus.walleij@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, richardcochran@gmail.com, manivannan.sadhasivam@linaro.org, andy.shevchenko@gmail.com, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v7 2/4] pinctrl: qcom: Remove the msm_function struct Message-ID: <20230511163352.kfjpvagh2rysyelo@ripper> References: <1683730825-15668-1-git-send-email-quic_rohiagar@quicinc.com> <1683730825-15668-3-git-send-email-quic_rohiagar@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1683730825-15668-3-git-send-email-quic_rohiagar@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, May 10, 2023 at 08:30:23PM +0530, Rohit Agarwal wrote: > Remove the msm_function struct to reuse the generic pinfunction > struct. Also, define a generic PINFUNCTION macro that can be used across > qcom target specific pinctrl files to avoid code repetition. > Looks nice! No need to carry our own structs for things that has made it into the framework. Reviewed-by: Bjorn Andersson But, ipq9574.c has made it into linux-next now, so this breaks the build of that driver. So please update this patch. And please send the two refactoring patches on their own, followed by the SDX75 based on that, so we can get those merged quickly, before any other impediments are introduced. Regards, Bjorn