* [PATCH] arm64: dts: rockchip: Update leds for Anbernic RGxx3 Series
@ 2023-05-12 19:16 Chris Morgan
2023-05-13 16:49 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Chris Morgan @ 2023-05-12 19:16 UTC (permalink / raw)
To: linux-rockchip
Cc: devicetree, heiko, conor+dt, krzysztof.kozlowski+dt, robh+dt,
Chris Morgan
From: Chris Morgan <macromorgan@hotmail.com>
Each of the LEDs on the RGxx3 which is currently controlled via GPIO
can also be controlled via a PWM. Change each of the LEDs to PWM so
that users have the ability to adjust the brightness of the LEDs
according to their preference.
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
.../dts/rockchip/rk3566-anbernic-rgxx3.dtsi | 39 +++++++++++--------
1 file changed, 22 insertions(+), 17 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi
index 8fadd8afb190..69f332738d24 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi
@@ -191,30 +191,30 @@ hdmi_con_in: endpoint {
};
};
- leds: gpio-leds {
- compatible = "gpio-leds";
- pinctrl-0 = <&led_pins>;
- pinctrl-names = "default";
+ leds: pwm-leds {
+ compatible = "pwm-leds";
green_led: led-0 {
color = <LED_COLOR_ID_GREEN>;
default-state = "on";
function = LED_FUNCTION_POWER;
- gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_HIGH>;
+ max-brightness = <255>;
+ pwms = <&pwm6 0 25000 0>;
};
amber_led: led-1 {
color = <LED_COLOR_ID_AMBER>;
function = LED_FUNCTION_CHARGING;
- gpios = <&gpio0 RK_PC6 GPIO_ACTIVE_HIGH>;
- retain-state-suspended;
+ max-brightness = <255>;
+ pwms = <&pwm7 0 25000 0>;
};
red_led: led-2 {
color = <LED_COLOR_ID_RED>;
default-state = "off";
function = LED_FUNCTION_STATUS;
- gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
+ max-brightness = <255>;
+ pwms = <&pwm0 0 25000 0>;
};
};
@@ -597,15 +597,6 @@ btn_pins_vol: btn-pins-vol {
};
};
- gpio-led {
- led_pins: led-pins {
- rockchip,pins =
- <0 RK_PC5 RK_FUNC_GPIO &pcfg_pull_none>,
- <0 RK_PC6 RK_FUNC_GPIO &pcfg_pull_none>,
- <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
- };
- };
-
joy-mux {
joy_mux_en: joy-mux-en {
rockchip,pins =
@@ -654,10 +645,24 @@ &pmu_io_domains {
vccio7-supply = <&vcc_3v3>;
};
+&pwm0 {
+ pinctrl-0 = <&pwm0m1_pins>;
+ pinctrl-names = "default";
+ status = "okay";
+};
+
&pwm5 {
status = "okay";
};
+&pwm6 {
+ status = "okay";
+};
+
+&pwm7 {
+ status = "okay";
+};
+
&saradc {
vref-supply = <&vcc_1v8>;
status = "okay";
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Update leds for Anbernic RGxx3 Series
2023-05-12 19:16 [PATCH] arm64: dts: rockchip: Update leds for Anbernic RGxx3 Series Chris Morgan
@ 2023-05-13 16:49 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2023-05-13 16:49 UTC (permalink / raw)
To: Chris Morgan, linux-rockchip
Cc: Heiko Stuebner, devicetree, Chris Morgan, robh+dt,
krzysztof.kozlowski+dt, conor+dt
On Fri, 12 May 2023 14:16:33 -0500, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Each of the LEDs on the RGxx3 which is currently controlled via GPIO
> can also be controlled via a PWM. Change each of the LEDs to PWM so
> that users have the ability to adjust the brightness of the LEDs
> according to their preference.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: Update leds for Anbernic RGxx3 Series
commit: 87c692fde46a511aa365d220588d0566125f4035
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-13 16:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-12 19:16 [PATCH] arm64: dts: rockchip: Update leds for Anbernic RGxx3 Series Chris Morgan
2023-05-13 16:49 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).