From: Jonathan Cameron <jic23@kernel.org>
To: Herve Codina <herve.codina@bootlin.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v4 2/3] iio: potentiometer: Add support for the Renesas X9250 potentiometers
Date: Sat, 13 May 2023 19:35:25 +0100 [thread overview]
Message-ID: <20230513193525.43a4475f@jic23-huawei> (raw)
In-Reply-To: <20230509160852.158101-3-herve.codina@bootlin.com>
On Tue, 9 May 2023 18:08:51 +0200
Herve Codina <herve.codina@bootlin.com> wrote:
> The Renesas X9250 integrates four digitally controlled potentiometers.
> On each potentiometer, the X9250T has a 100 kOhms total resistance and
> the X9250U has a 50 kOhms total resistance.
>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
As I only noticed one trivial thing I made the change whilst applying.
diff --git a/drivers/iio/potentiometer/x9250.c b/drivers/iio/potentiometer/x9250.c
index 3d4ca18d1f14..7e145d7d14f1 100644
--- a/drivers/iio/potentiometer/x9250.c
+++ b/drivers/iio/potentiometer/x9250.c
@@ -176,10 +176,7 @@ static int x9250_probe(struct spi_device *spi)
x9250 = iio_priv(indio_dev);
x9250->spi = spi;
- x9250->cfg = device_get_match_data(&spi->dev);
- if (!x9250->cfg)
- x9250->cfg = &x9250_cfg[spi_get_device_id(spi)->driver_data];
-
+ x9250->cfg = spi_get_device_match_data(spi);
x9250->wp_gpio = devm_gpiod_get_optional(&spi->dev, "wp", GPIOD_OUT_LOW);
if (IS_ERR(x9250->wp_gpio))
return dev_err_probe(&spi->dev, PTR_ERR(x9250->wp_gpio),
next prev parent reply other threads:[~2023-05-13 18:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 16:08 [PATCH v4 0/3] Add the Renesas X9250 potentiometers IIO support Herve Codina
2023-05-09 16:08 ` [PATCH v4 1/3] dt-bindings: iio: potentiometer: Add the Renesas X9250 potentiometers Herve Codina
2023-05-09 17:34 ` Krzysztof Kozlowski
2023-05-09 16:08 ` [PATCH v4 2/3] iio: potentiometer: Add support for " Herve Codina
2023-05-13 18:35 ` Jonathan Cameron [this message]
2023-05-14 14:32 ` Herve Codina
2023-05-14 17:19 ` Jonathan Cameron
2023-05-15 6:44 ` Herve Codina
2023-05-20 16:30 ` Jonathan Cameron
2023-05-29 15:57 ` andy.shevchenko
2023-06-04 12:57 ` Jonathan Cameron
2023-05-28 22:35 ` andy.shevchenko
2023-05-09 16:08 ` [PATCH v4 3/3] MAINTAINERS: add the Renesas X9250 driver entry Herve Codina
2023-05-13 18:35 ` [PATCH v4 0/3] Add the Renesas X9250 potentiometers IIO support Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230513193525.43a4475f@jic23-huawei \
--to=jic23@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=devicetree@vger.kernel.org \
--cc=herve.codina@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).