From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E15C77B7A for ; Sat, 13 May 2023 18:34:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232683AbjEMSeg (ORCPT ); Sat, 13 May 2023 14:34:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbjEMSec (ORCPT ); Sat, 13 May 2023 14:34:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 355B81FDA; Sat, 13 May 2023 11:34:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9D4FC61D6D; Sat, 13 May 2023 18:34:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4039C433EF; Sat, 13 May 2023 18:34:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684002871; bh=1G6HrXzM7Id2ujGj9Oq8Pmzskf+4RRUT5zQBHJ8W0gw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=caQnOqYsRwRdfuYAs/4x6koWVCac4R4fM8w3ZQCCG3q7t0WBUMAxfqq5BTrK2FMSZ PngBF46Dn0+8zqFiC7mz83QgX26+4PgpqCW/4wewTb/6rurIrS4h1AuSaP591NfZtx l1cEgVItGt5cbgQIxSwx06AMere1SDLrm1ROk5fY2hqjFODQpb5+e65uxiuj/YbD8a azAG8aRxU4zOc0m6eYvgEwN1cMl1cxq1DTFw379J0CE1IvmdZKz/w/8lBcvanQ3obC Db2uCOLaBFdyQ1dRXT9jKLDW2+4OGdaXTvo9Egd1qauK1/E9HEat9bX5y3i3rlsbMT DUd88t1ZWQyDA== Date: Sat, 13 May 2023 19:50:30 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski Cc: Anup Sharma , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald , broonie@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: iio: temperature: Add DT bindings for TMP006 Message-ID: <20230513195030.57b7939e@jic23-huawei> In-Reply-To: <4d18eb55-a44c-4033-93cd-35c02cb179b3@linaro.org> References: <4d18eb55-a44c-4033-93cd-35c02cb179b3@linaro.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 12 May 2023 08:28:29 +0200 Krzysztof Kozlowski wrote: > On 11/05/2023 21:06, Anup Sharma wrote: > > On Thu, May 11, 2023 at 11:28:50AM +0200, Krzysztof Kozlowski wrote: > >> On 10/05/2023 20:56, Anup Sharma wrote: > >>> Add devicetree binding document for TMP006, IR thermopile sensor. > >> > >> Why? Where is any user of this? DTS? Driver? > >> > > > > The support for TMP006 is available at driver/iio/temperature > > There is no such compatible in the kernel. If you add OF support, you > should change the driver. (Very) old driver, so it uses the fallback method that i2c provides to bind to the compatible with the vendor id dropped via i2c_device_id entry. Having said that, I'd also prefer the addition of an explicit of_device_id table. As there is only one supported device in this driver should be trivial. Thanks, Jonathan > > > Best regards, > Krzysztof >