[PATCH 1/3] ARM: dts: imx6qdl-mba6: Add missing pvcie-supply regulator

[PATCH 1/3] ARM: dts: imx6qdl-mba6: Add missing pvcie-supply regulator

[Alexander Stein]

This worked before by coincidence, as the regulator was probed and enabled
before PCI RC probe. But probe order changed since commit 259b93b21a9f
("regulator: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in
4.14") and PCIe supply is enabled after RC.
Fix this by adding the regulator to RC node.

The PCIe vaux regulator still needs to be enabled unconditionally for
Mini-PCIe USB-only devices.

Fixes: ef3846247b41 ("ARM: dts: imx6qdl: add TQ-Systems MBa6x device trees")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm/boot/dts/imx6qdl-mba6.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/imx6qdl-mba6.dtsi b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
index 78555a618851..7b7e6c2ad190 100644
--- a/arch/arm/boot/dts/imx6qdl-mba6.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
@@ -209,6 +209,7 @@ &pcie {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_pcie>;
 	reset-gpio = <&gpio6 7 GPIO_ACTIVE_LOW>;
+	vpcie-supply = <&reg_pcie>;
 	status = "okay";
 };
 
-- 
2.34.1

[PATCH 2/3] ARM: dts: imx6qdl-mba6: add mac address for USB ethernet controller

[Alexander Stein]

The mac address is stored in mainboard eeprom.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm/boot/dts/imx6qdl-mba6.dtsi  | 16 ++++++++++++++++
 arch/arm/boot/dts/imx6qdl-mba6a.dtsi |  6 ++++++
 arch/arm/boot/dts/imx6qdl-mba6b.dtsi |  6 ++++++
 3 files changed, 28 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-mba6.dtsi b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
index 7b7e6c2ad190..9d90d7647024 100644
--- a/arch/arm/boot/dts/imx6qdl-mba6.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
@@ -272,6 +272,22 @@ &uart5 {
 &usbh1 {
 	disable-over-current;
 	status = "okay";
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	hub@1 {
+		compatible = "usb424,2517";
+		reg = <1>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethernet@1 {
+			compatible = "usb424,9e00";
+			reg = <1>;
+			nvmem-cells = <&mba_mac_address>;
+			nvmem-cell-names = "mac-address";
+		};
+	};
 };
 
 &usbotg {
diff --git a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
index df8fa169e9f6..c3f3a25133ca 100644
--- a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
@@ -21,6 +21,12 @@ m24c64_57: eeprom@57 {
 		compatible = "atmel,24c64";
 		reg = <0x57>;
 		pagesize = <32>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+
+		mba_mac_address: mac-address@20 {
+				reg = <0x20 0x6>;
+		};
 	};
 
 	rtc0: rtc@68 {
diff --git a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
index 7d1cd7454c7f..85866cfed965 100644
--- a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
@@ -31,6 +31,12 @@ m24c64_57: eeprom@57 {
 		compatible = "atmel,24c64";
 		reg = <0x57>;
 		pagesize = <32>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+
+		mba_mac_address: mac-address@20 {
+				reg = <0x20 0x6>;
+		};
 	};
 
 	rtc0: rtc@68 {
-- 
2.34.1

Re: [PATCH 2/3] ARM: dts: imx6qdl-mba6: add mac address for USB ethernet controller

[Shawn Guo]

On Wed, May 03, 2023 at 01:31:11PM +0200, Alexander Stein wrote:
> The mac address is stored in mainboard eeprom.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  arch/arm/boot/dts/imx6qdl-mba6.dtsi  | 16 ++++++++++++++++
>  arch/arm/boot/dts/imx6qdl-mba6a.dtsi |  6 ++++++
>  arch/arm/boot/dts/imx6qdl-mba6b.dtsi |  6 ++++++
>  3 files changed, 28 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-mba6.dtsi b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> index 7b7e6c2ad190..9d90d7647024 100644
> --- a/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> @@ -272,6 +272,22 @@ &uart5 {
>  &usbh1 {
>  	disable-over-current;
>  	status = "okay";
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	hub@1 {
> +		compatible = "usb424,2517";
> +		reg = <1>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethernet@1 {
> +			compatible = "usb424,9e00";
> +			reg = <1>;
> +			nvmem-cells = <&mba_mac_address>;
> +			nvmem-cell-names = "mac-address";
> +		};
> +	};
>  };
>  
>  &usbotg {
> diff --git a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> index df8fa169e9f6..c3f3a25133ca 100644
> --- a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> @@ -21,6 +21,12 @@ m24c64_57: eeprom@57 {
>  		compatible = "atmel,24c64";
>  		reg = <0x57>;
>  		pagesize = <32>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +
> +		mba_mac_address: mac-address@20 {
> +				reg = <0x20 0x6>;

Incorrect indent?

Shawn

> +		};
>  	};
>  
>  	rtc0: rtc@68 {
> diff --git a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> index 7d1cd7454c7f..85866cfed965 100644
> --- a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> @@ -31,6 +31,12 @@ m24c64_57: eeprom@57 {
>  		compatible = "atmel,24c64";
>  		reg = <0x57>;
>  		pagesize = <32>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +
> +		mba_mac_address: mac-address@20 {
> +				reg = <0x20 0x6>;
> +		};
>  	};
>  
>  	rtc0: rtc@68 {
> -- 
> 2.34.1
> 

[PATCH 3/3] ARM: dts: imx6qdl-mba6: Add missing supply regulator for lm75 and at24

[Alexander Stein]

Fixes the warnings:
at24 0-0057: supply vcc not found, using dummy regulator
lm75 0-0049: supply vs not found, using dummy regulator

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm/boot/dts/imx6qdl-mba6a.dtsi | 2 ++
 arch/arm/boot/dts/imx6qdl-mba6b.dtsi | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
index c3f3a25133ca..3ca028c2dbe9 100644
--- a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
@@ -15,6 +15,7 @@ &i2c1 {
 	lm75: temperature-sensor@49 {
 		compatible = "national,lm75";
 		reg = <0x49>;
+		vs-supply = <&reg_mba6_3p3v>;
 	};
 
 	m24c64_57: eeprom@57 {
@@ -23,6 +24,7 @@ m24c64_57: eeprom@57 {
 		pagesize = <32>;
 		#address-cells = <1>;
 		#size-cells = <1>;
+		vcc-supply = <&reg_mba6_3p3v>;
 
 		mba_mac_address: mac-address@20 {
 				reg = <0x20 0x6>;
diff --git a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
index 85866cfed965..c97bd67462e7 100644
--- a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
@@ -25,6 +25,7 @@ &i2c3 {
 	lm75: temperature-sensor@49 {
 		compatible = "national,lm75";
 		reg = <0x49>;
+		vs-supply = <&reg_mba6_3p3v>;
 	};
 
 	m24c64_57: eeprom@57 {
@@ -33,6 +34,7 @@ m24c64_57: eeprom@57 {
 		pagesize = <32>;
 		#address-cells = <1>;
 		#size-cells = <1>;
+		vcc-supply = <&reg_mba6_3p3v>;
 
 		mba_mac_address: mac-address@20 {
 				reg = <0x20 0x6>;
-- 
2.34.1

Re: [PATCH 3/3] ARM: dts: imx6qdl-mba6: Add missing supply regulator for lm75 and at24

[Alexander Stein]

Hi Shawn,

Am Mittwoch, 3. Mai 2023, 13:31:12 CEST schrieb Alexander Stein:
> Fixes the warnings:
> at24 0-0057: supply vcc not found, using dummy regulator
> lm75 0-0049: supply vs not found, using dummy regulator
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

You applied patch 1 & 2. Is something missing for this patch to be applied?

Best regards,
Alexander

> ---
>  arch/arm/boot/dts/imx6qdl-mba6a.dtsi | 2 ++
>  arch/arm/boot/dts/imx6qdl-mba6b.dtsi | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi index c3f3a25133ca..3ca028c2dbe9
> 100644
> --- a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> @@ -15,6 +15,7 @@ &i2c1 {
>  	lm75: temperature-sensor@49 {
>  		compatible = "national,lm75";
>  		reg = <0x49>;
> +		vs-supply = <&reg_mba6_3p3v>;
>  	};
> 
>  	m24c64_57: eeprom@57 {
> @@ -23,6 +24,7 @@ m24c64_57: eeprom@57 {
>  		pagesize = <32>;
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> +		vcc-supply = <&reg_mba6_3p3v>;
> 
>  		mba_mac_address: mac-address@20 {
>  				reg = <0x20 0x6>;
> diff --git a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi index 85866cfed965..c97bd67462e7
> 100644
> --- a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> @@ -25,6 +25,7 @@ &i2c3 {
>  	lm75: temperature-sensor@49 {
>  		compatible = "national,lm75";
>  		reg = <0x49>;
> +		vs-supply = <&reg_mba6_3p3v>;
>  	};
> 
>  	m24c64_57: eeprom@57 {
> @@ -33,6 +34,7 @@ m24c64_57: eeprom@57 {
>  		pagesize = <32>;
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> +		vcc-supply = <&reg_mba6_3p3v>;
> 
>  		mba_mac_address: mac-address@20 {
>  				reg = <0x20 0x6>;


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Re: [PATCH 3/3] ARM: dts: imx6qdl-mba6: Add missing supply regulator for lm75 and at24

[Shawn Guo]

On Fri, Jun 16, 2023 at 11:42:19AM +0200, Alexander Stein wrote:
> Hi Shawn,
> 
> Am Mittwoch, 3. Mai 2023, 13:31:12 CEST schrieb Alexander Stein:
> > Fixes the warnings:
> > at24 0-0057: supply vcc not found, using dummy regulator
> > lm75 0-0049: supply vs not found, using dummy regulator
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> You applied patch 1 & 2. Is something missing for this patch to be applied?

Sorry.  I missed it.  Could you rebase and resend?

Shawn

Re: [PATCH 1/3] ARM: dts: imx6qdl-mba6: Add missing pvcie-supply regulator

[Shawn Guo]

On Wed, May 03, 2023 at 01:31:10PM +0200, Alexander Stein wrote:
> This worked before by coincidence, as the regulator was probed and enabled
> before PCI RC probe. But probe order changed since commit 259b93b21a9f
> ("regulator: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in
> 4.14") and PCIe supply is enabled after RC.
> Fix this by adding the regulator to RC node.
> 
> The PCIe vaux regulator still needs to be enabled unconditionally for
> Mini-PCIe USB-only devices.
> 
> Fixes: ef3846247b41 ("ARM: dts: imx6qdl: add TQ-Systems MBa6x device trees")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Applied, thanks!