From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACE1CC7EE2F for ; Mon, 15 May 2023 10:03:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240485AbjEOKDa (ORCPT ); Mon, 15 May 2023 06:03:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240943AbjEOKDM (ORCPT ); Mon, 15 May 2023 06:03:12 -0400 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4661DE5D; Mon, 15 May 2023 03:02:53 -0700 (PDT) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34F5WRGW024445; Mon, 15 May 2023 05:02:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=Dbath1udrCW8z6DIMjvXKGKZ7Y0Y4bUg2k1Qq4nsa8I=; b=N1Y9RrrdtpkyWCO3O79I/Z0dre7bjVf29OofkQJhCM0EJx0kG5nJpveDUEJLEpNZs5ko nLkSe5Ojx+AZ09GgFc6hjPxracRbkpKHrpKqB7XQtFZmlp3Rj5owfrnE/FE2uXtEIJWc B8amnGLzY/zG8u3y0UIKLN7+7s8vUIzpZMLnSz9hOaM7gcCV8A4vyxtYaJgpNLAmC2QI ZVh8XFv5Sc4gf+RkkbA9NqqodZYjaX+oVXaOAGYi4U3N29FU8FB3N97LSv5h4j0hWWsh eLTWD+7+xG5csTtLpKKZahLGAL/q3/ZmvR/1BhRbZHuqI6damknQB4oQfEmZKUwW/hWo 8w== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3qj7y12q01-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 May 2023 05:02:28 -0500 Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Mon, 15 May 2023 05:02:25 -0500 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Mon, 15 May 2023 05:02:25 -0500 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id C2B8845; Mon, 15 May 2023 10:02:25 +0000 (UTC) Date: Mon, 15 May 2023 10:02:25 +0000 From: Charles Keepax To: Krzysztof Kozlowski CC: , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 05/10] dt-bindings: mfd: cirrus,cs42l43: Add initial DT binding Message-ID: <20230515100225.GR68926@ediswmail.ad.cirrus.com> References: <20230512122838.243002-1-ckeepax@opensource.cirrus.com> <20230512122838.243002-6-ckeepax@opensource.cirrus.com> <5969fe82-69cd-34d6-edd1-d16ea741d9cb@linaro.org> <20230512161803.GM68926@ediswmail.ad.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: GnlTQhIlwLNY3S7LBUO1FLvr8l9zp2hX X-Proofpoint-ORIG-GUID: GnlTQhIlwLNY3S7LBUO1FLvr8l9zp2hX X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, May 13, 2023 at 08:08:05PM +0200, Krzysztof Kozlowski wrote: > On 12/05/2023 18:18, Charles Keepax wrote: > > On Fri, May 12, 2023 at 05:25:52PM +0200, Krzysztof Kozlowski wrote: > >> On 12/05/2023 14:28, Charles Keepax wrote: > >>> The CS42L43 is an audio CODEC with integrated MIPI SoundWire interface > >>> (Version 1.2.1 compliant), I2C, SPI, and I2S/TDM interfaces designed > >>> for portable applications. It provides a high dynamic range, stereo > >>> DAC for headphone output, two integrated Class D amplifiers for > >> > >> ... > >> > >>> + > >>> + interrupt-controller: true > >>> + > >>> + '#interrupt-cells': > >>> + const: 2 > >> > >> Hm, are you sure? Who is the consumer/user of this interrupt controller? > >> > > > > Anyone who wants the device has GPIOs that can signal IRQs. Some > > of the other IRQs could be more generally useful, such as some of > > the jack detection ones. > > > OK, makes sense, but it is a bit odd then to have: > codec { > which is GPIO and interrupt controller, but not pin controller > pinctrl { > pin controller, which is not GPIO and not interrupt controller > } > } > Maybe all the GPIO/pin/related interrupt properties should be moved to > pinctrl node? > I will have a look at that although I have a vague memory that this made the pinctrl very sad doing this. Presumably a bug somewhere but might take me a while to figure that out. The interrupt controller is a bit of a grey area as well since it has a bunch of IRQs that don't relate to the pins as well as some that do. So logically it might be better suited on the root node. Thanks, Charles